hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

Explicitely use no-arg constructor

Browse Source 
- Inadvertly I was using the constructor that received an int as
   initial capacity, which instantiated massive collections leading to
   an increase in memory usage.
This commit is contained in:
Juan Martín Sotuyo Dodero
2024-06-27 20:29:15 -03:00
parent 06ba547811
commit 10bfa395e5
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pmd-core/src/main/java/net/sourceforge/pmd/cpd/MatchCollector.java
View File

@ -68,7 +68,7 @@ class MatchCollector {
* - BC * - BC
* It should be reduced to a single match with 3 marks * It should be reduced to a single match with 3 marks
*/ */
if (tokenMatchSets.computeIfAbsent(mark1.getIndex(), HashSet::new).contains(mark2.getIndex())) { if (tokenMatchSets.computeIfAbsent(mark1.getIndex(), (i) -> new HashSet<>()).contains(mark2.getIndex())) {
return; return;
} }
@ -76,7 +76,7 @@ class MatchCollector {
// always rely on the lowest mark index, as that's the order in which process them // always rely on the lowest mark index, as that's the order in which process them
final int lowestKey = tokenMatchSets.get(mark1.getIndex()).stream().reduce(mark1.getIndex(), Math::min); final int lowestKey = tokenMatchSets.get(mark1.getIndex()).stream().reduce(mark1.getIndex(), Math::min);
List<Match> matches = matchTree.computeIfAbsent(lowestKey, ArrayList::new); List<Match> matches = matchTree.computeIfAbsent(lowestKey, (i) -> new ArrayList<>());
Iterator<Match> matchIterator = matches.iterator(); Iterator<Match> matchIterator = matches.iterator();
while (matchIterator.hasNext()) { while (matchIterator.hasNext()) {
Match m = matchIterator.next(); Match m = matchIterator.next();
@ -116,8 +116,8 @@ class MatchCollector {
} }
private void registerTokenMatch(TokenEntry mark1, TokenEntry mark2) { private void registerTokenMatch(TokenEntry mark1, TokenEntry mark2) {
tokenMatchSets.computeIfAbsent(mark1.getIndex(), HashSet::new).add(mark2.getIndex()); tokenMatchSets.computeIfAbsent(mark1.getIndex(), (i) -> new HashSet<>()).add(mark2.getIndex());
tokenMatchSets.computeIfAbsent(mark2.getIndex(), HashSet::new).add(mark1.getIndex()); tokenMatchSets.computeIfAbsent(mark2.getIndex(), (i) -> new HashSet<>()).add(mark1.getIndex());
} }
List<Match> getMatches() { List<Match> getMatches() {