[ci] Improve Dangerfile

- Fix FALSE -> false
- Add ?pr=123 to the download link for the report
This commit is contained in:
Andreas Dangel 2024-04-26 15:55:37 +02:00
parent 6a1c7de03c
commit 11b8fa2f45
No known key found for this signature in database
GPG Key ID: 93450DF2DF9A3FA3

View File

@ -44,7 +44,7 @@ def run_pmdtester
@base_branch = 'master' @base_branch = 'master'
@logger.info "\n\n--------------------------------------" @logger.info "\n\n--------------------------------------"
@logger.info "Run against #{@base_branch}" @logger.info "Run against #{@base_branch}"
@summary = PmdTester::Runner.new(get_args(@base_branch, FALSE, 'target/diff1/patch_config.xml')).run @summary = PmdTester::Runner.new(get_args(@base_branch, false, 'target/diff1/patch_config.xml')).run
# move the generated report out of the way # move the generated report out of the way
FileUtils.mv 'target/reports/diff', 'target/diff2' FileUtils.mv 'target/reports/diff', 'target/diff2'
@ -53,12 +53,12 @@ def run_pmdtester
tar_report tar_report
message1 += "[Download full report as build artifact](#{ENV['PMD_CI_JOB_URL']})" message1 += "[Download full report as build artifact](#{ENV['PMD_CI_JOB_URL']}?pr=#{ENV['PMD_CI_PULL_REQUEST_NUMBER']})"
# set value of sticky to true and the message is kept after new commits are submitted to the PR # set value of sticky to true and the message is kept after new commits are submitted to the PR
message(message1, sticky: true) message(message1, sticky: true)
if message2 if message2
message2 += "[Download full report as build artifact](#{ENV['PMD_CI_JOB_URL']})" message2 += "[Download full report as build artifact](#{ENV['PMD_CI_JOB_URL']}?pr=#{ENV['PMD_CI_PULL_REQUEST_NUMBER']})"
# set value of sticky to true and the message is kept after new commits are submitted to the PR # set value of sticky to true and the message is kept after new commits are submitted to the PR
message(message2, sticky: true) message(message2, sticky: true)
end end