hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

faster contains() test using Sets

Browse Source 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4619 51baf565-9d33-0410-a72c-fc3788e3496d
This commit is contained in:
Brian Remedios
2006-10-10 05:36:05 +00:00
parent 9fd45540f6
commit 23f2e78266
1 changed files with 10 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
pmd/src/net/sourceforge/pmd/rules/design/LooseCoupling.java
View File

@ -3,38 +3,28 @@
*/ */
package net.sourceforge.pmd.rules.design; package net.sourceforge.pmd.rules.design;
import java.util.Set;
import net.sourceforge.pmd.AbstractRule; import net.sourceforge.pmd.AbstractRule;
import net.sourceforge.pmd.ast.ASTClassOrInterfaceType; import net.sourceforge.pmd.ast.ASTClassOrInterfaceType;
import net.sourceforge.pmd.ast.ASTFieldDeclaration; import net.sourceforge.pmd.ast.ASTFieldDeclaration;
import net.sourceforge.pmd.ast.ASTFormalParameter; import net.sourceforge.pmd.ast.ASTFormalParameter;
import net.sourceforge.pmd.ast.ASTResultType; import net.sourceforge.pmd.ast.ASTResultType;
import net.sourceforge.pmd.ast.Node; import net.sourceforge.pmd.ast.Node;
import net.sourceforge.pmd.util.CollectionUtil;
import java.util.HashSet;
import java.util.Set;
public class LooseCoupling extends AbstractRule { public class LooseCoupling extends AbstractRule {
private Set implClassNames = new HashSet(); // TODO - these should be brought in via external properties
private static final Set implClassNames = CollectionUtil.asSet( new Object[] {
"ArrayList", "HashSet", "HashMap", "LinkedHashMap", "LinkedHashSet", "TreeSet", "TreeMap", "Vector",
"java.util.ArrayList", "java.util.HashSet", "java.util.HashMap",
"java.util.LinkedHashMap", "java.util.LinkedHashSet", "java.util.TreeSet",
"java.util.TreeMap", "java.util.Vector"
});
public LooseCoupling() { public LooseCoupling() {
super(); super();
implClassNames.add("ArrayList");
implClassNames.add("HashSet");
implClassNames.add("HashMap");
implClassNames.add("LinkedHashMap");
implClassNames.add("LinkedHashSet");
implClassNames.add("TreeSet");
implClassNames.add("TreeMap");
implClassNames.add("Vector");
implClassNames.add("java.util.ArrayList");
implClassNames.add("java.util.HashSet");
implClassNames.add("java.util.HashMap");
implClassNames.add("java.util.LinkedHashMap");
implClassNames.add("java.util.LinkedHashSet");
implClassNames.add("java.util.TreeSet");
implClassNames.add("java.util.TreeMap");
implClassNames.add("java.util.Vector");
} }
public Object visit(ASTClassOrInterfaceType node, Object data) { public Object visit(ASTClassOrInterfaceType node, Object data) {