hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

Fix PMD dogfood issues in pmd-cs, pmd-jsp, pmd-javascript, pmd-test

Browse Source
This commit is contained in:
Andreas Dangel
2014-11-16 00:15:47 +01:00
parent f7f89f2921
commit 3a4caa5c7c
11 changed files with 45 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pmd-jsp/src/main/java/net/sourceforge/pmd/lang/jsp/ast/DumpFacade.java
View File

@@ -17,7 +17,7 @@ public class DumpFacade extends JspParserVisitorAdapter {
private boolean recurse;
public void initializeWith(Writer writer, String prefix, boolean recurse, JspNode node) {
this.writer = (writer instanceof PrintWriter) ? (PrintWriter) writer : new PrintWriter(writer);
this.writer = writer instanceof PrintWriter ? (PrintWriter) writer : new PrintWriter(writer);
this.recurse = recurse;
this.visit(node, prefix);
try {

6
pmd-jsp/src/main/java/net/sourceforge/pmd/lang/jsp/ast/OpenTagRegister.java
View File

@@ -23,9 +23,10 @@ public class OpenTagRegister {
private List<ASTElement> tagList = new ArrayList<ASTElement>();
public void openTag(ASTElement elm) {
if (elm == null || StringUtil.isEmpty(elm.getName()))
if (elm == null || StringUtil.isEmpty(elm.getName())) {
throw new IllegalStateException(
"Tried to open a tag with empty name");
}
tagList.add(elm);
}
@@ -37,9 +38,10 @@ public class OpenTagRegister {
* was ever opened ( or registered )
*/
public boolean closeTag(String closingTagName) {
if (StringUtil.isEmpty(closingTagName))
if (StringUtil.isEmpty(closingTagName)) {
throw new IllegalStateException(
"Tried to close a tag with empty name");
}
int lastRegisteredTagIdx = tagList.size() - 1;
/*