hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

toUpperCase() should compare to a capitalized string

Browse Source
This commit is contained in:
ciufudean
2023-10-19 11:09:45 +03:00
committed by GitHub
parent 2bbb193d4e
commit 453685d6c4
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pmd-java/src/main/resources/category/java/errorprone.xml
View File

@ -3204,9 +3204,9 @@ Using equalsIgnoreCase() is faster than using toUpperCase/toLowerCase().equals()
<priority>3</priority>
<example>
<![CDATA[
boolean answer1 = buz.toUpperCase().equals("baz"); // should be buz.equalsIgnoreCase("baz")
boolean answer1 = buz.toUpperCase().equals("BAZ"); // should be buz.equalsIgnoreCase("BAZ")
boolean answer2 = buz.toUpperCase().equalsIgnoreCase("baz"); // another unnecessary toUpperCase()
boolean answer2 = buz.toUpperCase().equalsIgnoreCase("BAZ"); // another unnecessary toUpperCase()
]]>
</example>
</rule>