hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

Fix PMD dogfood: UnusedPrivateField

Browse Source 
Refs #361
This commit is contained in:
Andreas Dangel
2018-02-11 10:59:18 +01:00
parent e9abdf7a92
commit 4ace14899c
10 changed files with 17 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pmd-ui/src/main/java/net/sourceforge/pmd/util/fxdesigner/Designer.java
View File

@@ -53,10 +53,10 @@ public class Designer extends Application {
DesignerRoot owner = new DesignerRoot(stage);
MainDesignerController mainController = new MainDesignerController(owner);
NodeInfoPanelController nodeInfoPanelController = new NodeInfoPanelController(owner, mainController);
NodeInfoPanelController nodeInfoPanelController = new NodeInfoPanelController(mainController);
XPathPanelController xpathPanelController = new XPathPanelController(owner, mainController);
SourceEditorController sourceEditorController = new SourceEditorController(owner, mainController);
EventLogController eventLogController = new EventLogController(owner, mainController);
EventLogController eventLogController = new EventLogController(owner);
loader.setControllerFactory(type -> {
if (type == MainDesignerController.class) {

4
pmd-ui/src/main/java/net/sourceforge/pmd/util/fxdesigner/EventLogController.java
View File

@@ -31,7 +31,6 @@ import javafx.scene.control.cell.PropertyValueFactory;
public class EventLogController implements Initializable {
private final DesignerRoot designerRoot;
private final MainDesignerController parent;
@FXML
private TableView<LogEntry> eventLogTableView;
@@ -45,9 +44,8 @@ public class EventLogController implements Initializable {
private TextArea logDetailsTextArea;
public EventLogController(DesignerRoot owner, MainDesignerController mainController) {
public EventLogController(DesignerRoot owner) {
this.designerRoot = owner;
parent = mainController;
}

1
pmd-ui/src/main/java/net/sourceforge/pmd/util/fxdesigner/MainDesignerController.java
View File

@@ -66,6 +66,7 @@ import javafx.util.Duration;
* @see XPathPanelController
* @since 6.0.0
*/
@SuppressWarnings("PMD.UnusedPrivateField")
public class MainDesignerController implements Initializable, SettingsOwner {
/**

5
pmd-ui/src/main/java/net/sourceforge/pmd/util/fxdesigner/NodeInfoPanelController.java
View File

@@ -39,9 +39,9 @@ import javafx.scene.control.TreeView;
* @author Clément Fournier
* @since 6.0.0
*/
@SuppressWarnings("PMD.UnusedPrivateField")
public class NodeInfoPanelController implements Initializable {
private final DesignerRoot designerRoot;
private final MainDesignerController parent;
@FXML
@@ -61,8 +61,7 @@ public class NodeInfoPanelController implements Initializable {
private MetricEvaluator metricEvaluator = new MetricEvaluator();
public NodeInfoPanelController(DesignerRoot root, MainDesignerController mainController) {
this.designerRoot = root;
public NodeInfoPanelController(MainDesignerController mainController) {
parent = mainController;
}