hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

Merge branch 'pr-1366'

Browse Source
This commit is contained in:
Andreas Dangel
2018-10-04 19:03:41 +02:00
parent 04ba93bf0b d6d03ca868
commit 580e07cb20
3 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
docs/pages/release_notes.md
View File

@ -16,9 +16,14 @@ This is a {{ site.pmd.release_type }} release.
### Fixed Issues
* java-codestyle
* [#1356](https://github.com/pmd/pmd/issues/1356): \[java] UnnecessaryModifier wrong message public->static
### API Changes
### External Contributions
* [#1366](https://github.com/pmd/pmd/pull/1366): \[Java] Static Modifier on Internal Interface pmd #1356 - [avishvat](https://github.com/vishva007)
{% endtocmaker %}

2
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/codestyle/UnnecessaryModifierRule.java
View File

@ -169,7 +169,7 @@ public class UnnecessaryModifierRule extends AbstractJavaRule {
if ((node.isInterface() || isParentInterfaceOrAnnotation) && node.isStatic()) {
// a static interface or class nested within an interface
reportUnnecessaryModifiers(data, node, Modifier.PUBLIC, "types nested within an interface type are implicitly static");
reportUnnecessaryModifiers(data, node, Modifier.STATIC, "types nested within an interface type are implicitly static");
}
return data;

14
pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/UnnecessaryModifier.xml
View File

@ -673,6 +673,20 @@ enum Foo {
private Foo(String s) {
name = s;
}
}
]]></code>
</test-code>
<test-code>
<description>Static Modifier on interface</description>
<expected-problems>1</expected-problems>
<expected-messages>
<message>Unnecessary modifier 'static' on interface 'Bar': types nested within an interface type are implicitly static</message>
</expected-messages>
<code><![CDATA[
class Foo{
public static interface Bar{
void method(){ }
}
}
]]></code>
</test-code>