hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

[html] Test for a closing tag when determining node positions

Browse Source 
Fixes #5322
This commit is contained in:
Andreas Dangel 2024-11-14 17:07:37 +01:00
parent bb2782241e
commit 634a525286
No known key found for this signature in database
GPG Key ID: 93450DF2DF9A3FA3
7 changed files with 81 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/pages/release_notes.md
View File

@ -20,6 +20,8 @@ This is a {{ site.pmd.release_type }} release.
* java * java
* [#5293](https://github.com/pmd/pmd/issues/5293): \[java] Deadlock when executing PMD in multiple threads * [#5293](https://github.com/pmd/pmd/issues/5293): \[java] Deadlock when executing PMD in multiple threads
* [#5324](https://github.com/pmd/pmd/issues/5324): \[java] Issue with type inference of nested lambdas * [#5324](https://github.com/pmd/pmd/issues/5324): \[java] Issue with type inference of nested lambdas
* html
* [5322](https://github.com/pmd/pmd/issues/5322): \[html] CPD throws exception on when HTML file is missing closing tag
### 🚨 API Changes ### 🚨 API Changes

11
pmd-html/src/main/java/net/sourceforge/pmd/lang/html/ast/LineNumbers.java
View File

@ -50,15 +50,14 @@ class LineNumbers {
nextIndex = determineLocation((AbstractHtmlNode<?>) child, nextIndex); nextIndex = determineLocation((AbstractHtmlNode<?>) child, nextIndex);
} }
// autoclosing element, eg <a /> // explicitly closing element, eg. </a>
boolean isAutoClose = n.getNumChildren() == 0 boolean hasCloseElement = n instanceof ASTHtmlElement
&& n instanceof ASTHtmlElement // nextIndex is up to the closing tag at this point
// nextIndex is up to the closing > at this point && htmlString.startsWith("</" + n.getXPathNodeName() + ">", nextIndex);
&& htmlString.startsWith("/>", nextIndex - 2);
if (n instanceof ASTHtmlDocument) { if (n instanceof ASTHtmlDocument) {
nextIndex = htmlString.length(); nextIndex = htmlString.length();
} else if (n instanceof ASTHtmlElement && !isAutoClose) { } else if (n instanceof ASTHtmlElement && hasCloseElement) {
nextIndex += 2 + n.getXPathNodeName().length() + 1; // </nodename> nextIndex += 2 + n.getXPathNodeName().length() + 1; // </nodename>
} else if (n instanceof ASTHtmlComment) { } else if (n instanceof ASTHtmlComment) {
nextIndex += 4 + 3; // <!-- and --> nextIndex += 4 + 3; // <!-- and -->

9
pmd-html/src/test/java/net/sourceforge/pmd/lang/html/cpd/HtmlCpdLexerTest.java
View File

@ -21,4 +21,13 @@ class HtmlCpdLexerTest extends CpdTextComparisonTest {
doTest("SimpleHtmlFile"); doTest("SimpleHtmlFile");
} }
@Test
void invalidHtml() {
doTest("InvalidHtml");
}
@Test
void metaTag() {
doTest("MetaTag");
}
} }

7
pmd-html/src/test/resources/net/sourceforge/pmd/lang/html/cpd/testdata/InvalidHtml.html vendored Normal file
View File

@ -0,0 +1,7 @@
<!doctype html>
<html lang="en">
<body>
<!-- missing closing tag for div -->
<div class='wrapper'>
</body>
</html>

22
pmd-html/src/test/resources/net/sourceforge/pmd/lang/html/cpd/testdata/InvalidHtml.txt vendored Normal file
View File

@ -0,0 +1,22 @@
[Image] or [Truncated image[ Bcol Ecol
L1
[#document] 1 8
[#doctype] 1 15
[\n] 16 16
L2
[html] 1 7
[\n] 17 17
L3
[body] 1 7
[\n] 7 7
L4
[#comment] 1 36
[\n] 37 37
L5
[div] 1 22
[\n] 22 22
L6
[\n] 8 8
L7
[\n] 8 8
EOF

9
pmd-html/src/test/resources/net/sourceforge/pmd/lang/html/cpd/testdata/MetaTag.html vendored Normal file
View File

@ -0,0 +1,9 @@
<!doctype html>
<html lang="en">
<head>
<!-- meta tag doesn't have a closing tag and this is valid -->
<meta charset="UTF-8">
</head>
<body>
</body>
</html>

27
pmd-html/src/test/resources/net/sourceforge/pmd/lang/html/cpd/testdata/MetaTag.txt vendored Normal file
View File

@ -0,0 +1,27 @@
[Image] or [Truncated image[ Bcol Ecol
L1
[#document] 1 8
[#doctype] 1 15
[\n] 16 16
L2
[html] 1 7
[\n] 17 17
L3
[head] 1 7
[\n ] 7 4
L4
[#comment] 5 66
[\n ] 67 4
L5
[meta] 5 27
[\n] 27 27
L6
[\n] 8 8
L7
[body] 1 7
[\n] 7 7
L8
[\n] 8 8
L9
[\n] 8 8
EOF