hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

Merge pull request #3516 from kevingnet:kevingnet_branch

Browse Source 
[javascript] NPE while creating rule violation when specifying explicit
line numbers #3516
This commit is contained in:
Andreas Dangel
2021-09-25 10:17:23 +02:00
parent 4d49fd5fe2 3bb93c5ef6
commit 6d6d4c5769
3 changed files with 54 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
pmd-javascript/src/main/java/net/sourceforge/pmd/lang/ecmascript/rule/EcmascriptRuleViolationFactory.java
View File

@ -26,15 +26,16 @@ public final class EcmascriptRuleViolationFactory extends AbstractRuleViolationF
private EcmascriptRuleViolationFactory() {
}
@SuppressWarnings("rawtypes")
@Override
protected RuleViolation createRuleViolation(Rule rule, RuleContext ruleContext, Node node, String message) {
return new ParametricRuleViolation<>(rule, ruleContext, (EcmascriptNode) node, message);
return new ParametricRuleViolation<>(rule, ruleContext, (EcmascriptNode<?>) node, message);
}
@Override
protected RuleViolation createRuleViolation(Rule rule, RuleContext ruleContext, Node node, String message,
int beginLine, int endLine) {
return null; // FIXME
ParametricRuleViolation<EcmascriptNode<?>> ruleViolation = new ParametricRuleViolation<>(rule, ruleContext, (EcmascriptNode<?>) node, message);
ruleViolation.setLines(beginLine, endLine);
return ruleViolation;
}
}

46
pmd-javascript/src/test/java/net/sourceforge/pmd/lang/ecmascript/EcmasccriptLanguageModuleTest.java Normal file
View File

@ -0,0 +1,46 @@
/*
* BSD-style license; for more info see http://pmd.sourceforge.net/license.html
*/
package net.sourceforge.pmd.lang.ecmascript;
import org.junit.Assert;
import org.junit.Test;
import net.sourceforge.pmd.Rule;
import net.sourceforge.pmd.RuleContext;
import net.sourceforge.pmd.RuleViolation;
import net.sourceforge.pmd.lang.LanguageRegistry;
import net.sourceforge.pmd.lang.LanguageVersion;
import net.sourceforge.pmd.lang.LanguageVersionHandler;
import net.sourceforge.pmd.lang.ecmascript.ast.ASTAstRoot;
import net.sourceforge.pmd.lang.ecmascript.ast.JsParsingHelper;
import net.sourceforge.pmd.lang.ecmascript.rule.AbstractEcmascriptRule;
import net.sourceforge.pmd.lang.rule.RuleViolationFactory;
public class EcmasccriptLanguageModuleTest {
private Rule rule = new AbstractEcmascriptRule() { };
private ASTAstRoot node = JsParsingHelper.DEFAULT.parse("function a() {}");
private LanguageVersion js = LanguageRegistry.getLanguage(EcmascriptLanguageModule.NAME).getDefaultVersion();
private LanguageVersionHandler languageVersionHandler = js.getLanguageVersionHandler();
private RuleViolationFactory ruleViolationFactory = languageVersionHandler.getRuleViolationFactory();
@Test
public void canCreateRuleViolation() {
RuleContext context = new RuleContext();
ruleViolationFactory.addViolation(context, rule, node, "the message", new Object[0]);
Assert.assertEquals(1, context.getReport().getViolations().size());
RuleViolation ruleViolation = context.getReport().getViolations().get(0);
Assert.assertEquals(1, ruleViolation.getBeginLine());
}
@Test
public void canCreateRuleViolationWithLineNumbers() {
RuleContext context = new RuleContext();
ruleViolationFactory.addViolation(context, rule, node, "the message", 5, 7, new Object[0]);
Assert.assertEquals(1, context.getReport().getViolations().size());
RuleViolation ruleViolation = context.getReport().getViolations().get(0);
Assert.assertEquals(5, ruleViolation.getBeginLine());
Assert.assertEquals(7, ruleViolation.getEndLine());
}
}