hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

Fix violations of UnnecessaryVarargsArrayCreation

Browse Source
This commit is contained in:
Clément Fournier
2024-04-21 13:31:27 +02:00
parent 34e0b217a2
commit 75e284075b
14 changed files with 34 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
pmd-plsql/src/main/java/net/sourceforge/pmd/lang/plsql/rule/design/CyclomaticComplexityRule.java
View File

@@ -210,8 +210,8 @@ public class CyclomaticComplexityRule extends AbstractPLSQLRule {
classEntry.getComplexityAverage(), classEntry.highestDecisionPoints);
if (showClassesComplexity) {
if (classEntry.getComplexityAverage() >= reportLevel || classEntry.highestDecisionPoints >= reportLevel) {
asCtx(data).addViolation(node, new String[] { "class", node.getImage(),
classEntry.getComplexityAverage() + " (Highest = " + classEntry.highestDecisionPoints + ')', });
asCtx(data).addViolation(node, "class", node.getImage(),
classEntry.getComplexityAverage() + " (Highest = " + classEntry.highestDecisionPoints + ')');
}
}
return data;
@@ -227,8 +227,8 @@ public class CyclomaticComplexityRule extends AbstractPLSQLRule {
classEntry.highestDecisionPoints);
if (showClassesComplexity) {
if (classEntry.getComplexityAverage() >= reportLevel || classEntry.highestDecisionPoints >= reportLevel) {
asCtx(data).addViolation(node, new String[] { "class", node.getImage(),
classEntry.getComplexityAverage() + " (Highest = " + classEntry.highestDecisionPoints + ')', });
asCtx(data).addViolation(node, "class", node.getImage(),
classEntry.getComplexityAverage() + " (Highest = " + classEntry.highestDecisionPoints + ')');
}
}
return data;
@@ -276,8 +276,8 @@ public class CyclomaticComplexityRule extends AbstractPLSQLRule {
ASTMethodDeclarator methodDeclarator = node.firstChild(ASTMethodDeclarator.class);
if (methodEntry.decisionPoints >= reportLevel) {
asCtx(data).addViolation(node,
new String[] { "method", methodDeclarator == null ? "" : methodDeclarator.getImage(),
String.valueOf(methodEntry.decisionPoints), });
"method", methodDeclarator == null ? "" : methodDeclarator.getImage(),
String.valueOf(methodEntry.decisionPoints));
}
}
return data;
@@ -306,8 +306,8 @@ public class CyclomaticComplexityRule extends AbstractPLSQLRule {
ASTMethodDeclarator methodDeclarator = node.firstChild(ASTMethodDeclarator.class);
if (methodEntry.decisionPoints >= reportLevel) {
asCtx(data).addViolation(node,
new String[] { "method", methodDeclarator == null ? "" : methodDeclarator.getImage(),
String.valueOf(methodEntry.decisionPoints), });
"method", methodDeclarator == null ? "" : methodDeclarator.getImage(),
String.valueOf(methodEntry.decisionPoints));
}
}
return data;
@@ -334,8 +334,8 @@ public class CyclomaticComplexityRule extends AbstractPLSQLRule {
ASTMethodDeclarator methodDeclarator = node.firstChild(ASTMethodDeclarator.class);
if (methodEntry.decisionPoints >= reportLevel) {
asCtx(data).addViolation(node,
new String[] { "method", methodDeclarator == null ? "" : methodDeclarator.getImage(),
String.valueOf(methodEntry.decisionPoints), });
"method", methodDeclarator == null ? "" : methodDeclarator.getImage(),
String.valueOf(methodEntry.decisionPoints));
}
}
return data;