hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

Use current classloader instead of Thread's classloader

Browse Source 
This fixes #1788 by using the current's classloader instead of the
current Thread's ones. This is required if executing CPD in a separate
worker.
Also adjusts the release notes.
This commit is contained in:
Andreas Schmid
2019-04-22 16:21:13 +02:00
parent 829e9d4a9b
commit 8c7f19bdfe
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/pages/release_notes.md
View File

@ -49,6 +49,8 @@ Being based on a proper Antlr grammar, CPD can:
* [#1782](https://github.com/pmd/pmd/issues/1782): \[java] NoPackage: False Negative for enums
* java-design
* [#1760](https://github.com/pmd/pmd/issues/1760): \[java] UseObjectForClearerAPI flags private methods
* cpd-core
* [#1788](https://github.com/pmd/pmd/issues/1788): \[cpd] \[core] Use better `ClassLoader` for `ServiceLoader` in `LanguageFactory`
### API Changes

3
pmd-core/src/main/java/net/sourceforge/pmd/cpd/LanguageFactory.java
View File

@ -33,7 +33,8 @@ public final class LanguageFactory {
private LanguageFactory() {
List<Language> languagesList = new ArrayList<>();
ServiceLoader<Language> languageLoader = ServiceLoader.load(Language.class);
// Use current class' classloader instead of the threads context classloader, see https://github.com/pmd/pmd/issues/1788
ServiceLoader<Language> languageLoader = ServiceLoader.load(Language.class, getClass().getClassLoader());
Iterator<Language> iterator = languageLoader.iterator();
while (iterator.hasNext()) {
try {