hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

[apex] ClassNamingConventions - Improve tests for inner interfaces

Browse Source 
Refs #5048
This commit is contained in:
Andreas Dangel 2024-07-18 10:04:03 +02:00
parent 7023ea3d27
commit 909603d7e0
No known key found for this signature in database
GPG Key ID: 93450DF2DF9A3FA3
1 changed files with 11 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/codestyle/xml/ClassNamingConventions.xml
View File

@ -196,42 +196,40 @@ public enum FooEnum { }
</test-code>
<test-code>
<description>Inner class naming convention, class name failed to match RegEx #5048</description>
<description>#4800 #5048 Inner class/interface naming convention, names fail to match RegEx</description>
<rule-property name="innerClassPattern">[A-Za-z]</rule-property>
<expected-problems>1</expected-problems>
<rule-property name="innerInterfacePattern">[A-Za-z]</rule-property>
<expected-problems>2</expected-problems>
<code>
<![CDATA[
public class Outer {
public class inner_class_with_a_weird_name_1{
}
public class inner_class_with_a_weird_name_1 { }
public interface inner_interface_with_a_weird_name_2 { }
}
]]>
</code>
</test-code>
<test-code>
<description>
Inner class has one standard, outer class has another,
#4800 #5048 Inner class/interface has one standard, outer class has another,
and an inner enum has another (should pass.)
* Inner class should be camel case.
* Outer class should have a prefix (one character, all caps), underscore, then camel case.
* Enum name should be all caps (not best practice!)
* See #5048
</description>
<rule-property name="innerClassPattern">[A-Za-z]+</rule-property>
<rule-property name="classPattern">[A-Z]_[A-Za-z]+</rule-property>
<rule-property name="innerClassPattern">[A-Za-z]+</rule-property>
<rule-property name="innerInterfacePattern">[A-Za-z]+</rule-property>
<rule-property name="enumPattern">[A-Z]+</rule-property>
<expected-problems>0</expected-problems>
<code>
<![CDATA[
public class C_Outer {
public class InnerClass {}
public interface InnerInterface {}
public class InnerClass{
}
public enum SOMEVALUES{
public enum SOMEVALUES {
VALUE1,
VALUE2
}