hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

Turn violation suppression descriptors into Optional

Browse Source
This commit is contained in:
Clément Fournier
2019-09-19 00:02:40 +02:00
parent 1f28da5bf4
commit 99cb4bfd6f
8 changed files with 51 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pmd-test/src/main/java/net/sourceforge/pmd/AbstractRuleSetFactoryTest.java
View File

@@ -176,7 +176,7 @@ public abstract class AbstractRuleSetFactoryTest {
.append(PMD.EOL);
}
// Should not have violation suppress regex property
if (rule.getProperty(Rule.VIOLATION_SUPPRESS_REGEX_DESCRIPTOR) != null) {
if (rule.getProperty(Rule.VIOLATION_SUPPRESS_REGEX_DESCRIPTOR).isPresent()) {
invalidRegexSuppress++;
messages.append("Rule ")
.append(fileName)
@@ -188,7 +188,7 @@ public abstract class AbstractRuleSetFactoryTest {
.append(PMD.EOL);
}
// Should not have violation suppress xpath property
if (rule.getProperty(Rule.VIOLATION_SUPPRESS_XPATH_DESCRIPTOR) != null) {
if (rule.getProperty(Rule.VIOLATION_SUPPRESS_XPATH_DESCRIPTOR).isPresent()) {
invalidXPathSuppress++;
messages.append("Rule ").append(fileName).append("/").append(rule.getName()).append(" should not have '").append(Rule.VIOLATION_SUPPRESS_XPATH_DESCRIPTOR.name()).append("', this is intended for end user customization only.").append(PMD.EOL);
}