hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

Remove numbers from Java LPS names

Browse Source 
- The numbers relate to how they are executed, but don't necessarilly imply a required order
(ie: Comment Assignment could be done at any point)
 - Since the benchmark report sorts by time spent on each one, the numbered labels are simply confusing
This commit is contained in:
Juan Martín Sotuyo Dodero
2023-01-25 17:06:24 -03:00
parent 4aceb42e9c
commit c5d410367a
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/internal/JavaAstProcessor.java
View File

@ -165,7 +165,7 @@ public final class JavaAstProcessor {
*/ */
public void process(ASTCompilationUnit acu) { public void process(ASTCompilationUnit acu) {
SymbolResolver knownSyms = TimeTracker.bench("1. Symbol resolution", () -> SymbolResolutionPass.traverse(this, acu)); SymbolResolver knownSyms = TimeTracker.bench("Symbol resolution", () -> SymbolResolutionPass.traverse(this, acu));
// Now symbols are on the relevant nodes // Now symbols are on the relevant nodes
this.symResolver = SymbolResolver.layer(knownSyms, this.symResolver); this.symResolver = SymbolResolver.layer(knownSyms, this.symResolver);
@ -174,12 +174,12 @@ public final class JavaAstProcessor {
// as scopes depend on type resolution in some cases. // as scopes depend on type resolution in some cases.
InternalApiBridge.initTypeResolver(acu, this, typeInferenceLogger); InternalApiBridge.initTypeResolver(acu, this, typeInferenceLogger);
TimeTracker.bench("2. Symbol table resolution", () -> SymbolTableResolver.traverse(this, acu)); TimeTracker.bench("Symbol table resolution", () -> SymbolTableResolver.traverse(this, acu));
TimeTracker.bench("3. AST disambiguation", () -> InternalApiBridge.disambigWithCtx(NodeStream.of(acu), ReferenceCtx.root(this, acu))); TimeTracker.bench("AST disambiguation", () -> InternalApiBridge.disambigWithCtx(NodeStream.of(acu), ReferenceCtx.root(this, acu)));
TimeTracker.bench("4. Force type resolution", () -> InternalApiBridge.forceTypeResolutionPhase(this, acu)); TimeTracker.bench("Force type resolution", () -> InternalApiBridge.forceTypeResolutionPhase(this, acu));
TimeTracker.bench("5. Comment assignment", () -> InternalApiBridge.assignComments(acu)); TimeTracker.bench("Comment assignment", () -> InternalApiBridge.assignComments(acu));
TimeTracker.bench("6. Usage resolution", () -> InternalApiBridge.usageResolution(this, acu)); TimeTracker.bench("Usage resolution", () -> InternalApiBridge.usageResolution(this, acu));
TimeTracker.bench("7. Override resolution", () -> InternalApiBridge.overrideResolution(this, acu)); TimeTracker.bench("Override resolution", () -> InternalApiBridge.overrideResolution(this, acu));
} }
public TypeSystem getTypeSystem() { public TypeSystem getTypeSystem() {