hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

Ensure #1455 is fixed

Browse Source 
Fix #1455
This commit is contained in:
Andreas Dangel
2023-04-28 11:28:27 +02:00
parent c2b18ce229
commit cef70329f1
2 changed files with 56 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

57
pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/bestpractices/xml/JUnitTestsShouldIncludeAssert.xml
View File

@ -653,7 +653,7 @@ public class FooTest extends TestCase {
</test-code>
<test-code>
<description>AssertJ and JUnit5</description>
<description>AssertJ and JUnit5 #3339</description>
<expected-problems>0</expected-problems>
<code><![CDATA[
import org.assertj.core.api.Assertions;
@ -670,7 +670,7 @@ class JUnit5AssertJTest {
</test-code>
<test-code>
<description>JUnit5</description>
<description>JUnit5 #3339</description>
<expected-problems>0</expected-problems>
<code><![CDATA[
import org.junit.jupiter.api.Assertions;
@ -705,4 +705,57 @@ public class BigTest {
}
]]></code>
</test-code>
<test-code>
<description>[java] JUnitTestsShouldIncludeAssert: False positives for assert methods named "check" and "verify" #1455</description>
<expected-problems>0</expected-problems>
<code><![CDATA[
import org.junit.Test;
import java.time.LocalTime;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotNull;
public class CustomAssertTests {
private LocalTime localTime = LocalTime.of(5, 11, 33, 811*1_000_000);
private int hour = 1;
@Test
public void test1() { // false positive
check(localTime, hour);
}
@Test
public void test2() { // false positive
checkMore(localTime, hour);
}
@Test
public void test3() { // false positive
verify(localTime, hour);
}
@Test
public void test4() { // false positive
verifyOtherStuff(localTime, hour);
}
private void check(LocalTime localTime2, int hour) {
assertEquals(localTime2.getHour(), hour);
}
private void checkMore(LocalTime localTime2, int hour) {
assertEquals(localTime2.getHour(), hour);
}
private void verify(LocalTime localTime2, int hour) {
assertEquals(localTime2.getHour(), hour);
}
private void verifyOtherStuff(LocalTime localTime2, int hour) {
assertEquals(localTime2.getHour(), hour);
}
}
]]></code>
</test-code>
</test-data>