5547 Commits

Author SHA1 Message Date
Xavier Le Vourch
8f0b73c24e preparing 4.2rc2 release
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5909 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-22 00:46:16 +00:00
Xavier Le Vourch
5770de00f8 extra doc for testing correctness of new rule
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5908 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-21 02:28:25 +00:00
Xavier Le Vourch
5fc614d1ff xdocs: renaming finalising-rules.xml as rule-guidelines.xml
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5907 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-20 22:17:26 +00:00
Romain Pelisse
333d9f09b7 Correcting an erronous link.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5906 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-19 22:22:20 +00:00
Xavier Le Vourch
6619e19d35 Fixed formatting problems in loggers
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5905 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-19 21:47:08 +00:00
Romain Pelisse
7bb6e060ec Typo and TODO
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5904 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-19 12:42:01 +00:00
Xavier Le Vourch
e734404f20 code cleanup: extra debug log message removed
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5903 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-17 05:12:05 +00:00
Xavier Le Vourch
a58cd8442e auxclasspath nested element for Type Resolution classpath
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5902 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-17 05:08:02 +00:00
Romain Pelisse
01eb3cadad Upgraded documentation and code of the new maxProblemCount attribute in PmdAntTask:
failOnViolation == true + problemCount not setted => fail if one violation or more is reported.
failOnViolation == true + problemCount is setted => fail if the problemCount threshold is reached
failOnViolation not setted + problemCount is setted => fail if the problemCount threshold
failOnViolation to false + problemCount is setted => depends on the order ant to the setting, most likely going not to fail.

I think this is the more appropriate solution. maxProblemCount is no longer tied up to the failOnViolation parameter. 

When a use maxProblemCount, it will automaticly set failOnViolation to true.

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5901 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-15 10:54:56 +00:00
Ryan Gustafson
508e7ca7e2 Preserve checked rules across table sorts on Project PMD Preferences.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5900 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-15 08:31:13 +00:00
Ryan Gustafson
4c8b07d9a8 Remove unused JSmartPanel class.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5899 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-15 03:46:42 +00:00
Ryan Gustafson
2ca4f85eef Fixed bug 1913536 - Rule Designer does not recognize JSP(XML)
Remove duplicate knowledge of PMD language internals and replace with SourceTypeHandler.  Much cleaner!

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5898 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-15 03:37:00 +00:00
Ryan Gustafson
2fa65a65ab Fixed bug 1912831 - False + UnusedPrivateMethod with varargs
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5897 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-13 20:09:55 +00:00
Ryan Gustafson
635e29a219 Add on demand import test case for typeresolution/UnusedImports. For real this time. :)
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5896 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-13 20:07:28 +00:00
Ryan Gustafson
dcbb0f70d6 Add on demand import test case for typeresolution/UnusedImports.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5895 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-13 19:55:36 +00:00
Ryan Gustafson
4dfa856188 Clear Symbol Table view when code is re-parsed (e.g. Go button pressed).
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5894 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-13 19:23:49 +00:00
Ryan Gustafson
2ecbe0361a Added MethodNameDeclarations at ClassScope in the Designer Symbol Table view.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5893 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-13 19:17:13 +00:00
Ryan Gustafson
b01cb0139b Fix ClassCastException when not an ASTTreeNode (e.g. when browsing symbol table).
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5892 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-13 19:06:53 +00:00
Romain Pelisse
e77489b37a Applied patch 1849474 - New property for PMD ant task
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5891 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-12 15:38:35 +00:00
Ryan Gustafson
c595c61edd Add -auxclasspath option for specifying Type Resolution classpath from command line.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5890 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-11 20:03:29 +00:00
Ryan Gustafson
e9ccc61428 Fix 1909929 - clean violation review is not selective enough
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5889 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-11 01:21:18 +00:00
Ryan Gustafson
8c0e1d6b3d Fix 1909929 - clean violation review is not selective enough
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5888 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-11 01:21:10 +00:00
Ryan Gustafson
1e810aa4e1 Correct logger class.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5887 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-10 08:53:19 +00:00
Ryan Gustafson
058b983b55 Don't die when selecting multiple projects, and one happens to be a non-Java project.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5886 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-10 06:59:34 +00:00
Ryan Gustafson
29ba46ce41 Don't puke on Classes in the default package.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5885 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-10 06:45:38 +00:00
Tom Copeland
758c7865ee Removed wrong link
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5884 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-08 17:03:40 +00:00
Xavier Le Vourch
7bfac6fd95 version updated to 3.2.4.v200803071500
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5883 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-07 23:06:44 +00:00
Xavier Le Vourch
9cdb5b2f8d version updated to 3.2.4.v200803071500
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5882 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-07 23:05:10 +00:00
Xavier Le Vourch
25fe8e6021 update to pmd 4.2rc1
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5881 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-07 22:40:03 +00:00
Xavier Le Vourch
36644e4a09 updates to release script
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5880 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-07 21:44:53 +00:00
Xavier Le Vourch
d4f47ac9ee 4.2rc1 download and what's new links
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5879 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-07 21:24:13 +00:00
Xavier Le Vourch
6b1b6324e4 preparing for 4.2rc1:
- version number and release date updated

- maven2.beta used for deployment as this release should not be mirrored
on official mvn mirrors.

The use of two maven repositories should be configurable based on version
info in release script.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5877 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-07 20:53:38 +00:00
Xavier Le Vourch
39901cacec etc/updating_rulesets.sh modified to exclude rulesets referencing other rulesets
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5876 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-07 20:46:48 +00:00
Xavier Le Vourch
9e077e2c12 maven complains about missing </p>
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5875 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-07 19:03:29 +00:00
Xavier Le Vourch
5f8bf04a34 version number displayed in AST viewer
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5874 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-07 01:59:30 +00:00
Xavier Le Vourch
9c4ef51364 retroweaver updated to version 2.0.5
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5873 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-07 00:36:25 +00:00
Xavier Le Vourch
569fd197fc version number displayed in cpd and designer guis
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5872 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-07 00:25:50 +00:00
Xavier Le Vourch
18ee21de3c version update to 4.2rc1
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5871 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-07 00:25:22 +00:00
Xavier Le Vourch
dfd7a984b0 AST cleanup: class ASTEnumElement removed as it's not used
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5870 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-06 03:28:20 +00:00
Ryan Gustafson
a11337cab4 Handle scenario where missing dependent classes causes PMD to explode.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5869 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-06 02:35:36 +00:00
Ryan Gustafson
7b7f854635 Add tests cases and support for operators and expressions.
ASTName is now carrying over the type from it's Declaration when possible.

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5868 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-06 02:09:35 +00:00
Ryan Gustafson
065423d619 Add tests cases and support for unary and binary numeric promotion.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5867 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-06 00:15:04 +00:00
Ryan Gustafson
6aa4be951a Added more test cases for Type Resolution. Change so that test files are available both as .java and .class, this is really the only way to properly test Type Resolution.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5866 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-05 22:56:26 +00:00
Ryan Gustafson
4e78fbaba6 More TypeNodes, and fixes on ClassTypeResolver.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5865 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-05 22:53:29 +00:00
Xavier Le Vourch
541267c146 regeneration of Java Parser classes to reflect changes in grammar file.
using cvs version of JavaCC from March 05 2008


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5864 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-05 18:25:11 +00:00
Ryan Gustafson
8df01bae99 Update TODO comments for array treatment on allocation expressions (turns out to be more complex than I first thought).
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5863 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-05 09:00:44 +00:00
Ryan Gustafson
65c6faf511 Update grammar to indicate basic literal type on the ASTLiteral class. Type Resolution can use this to determine the proper Java type (int, long, float, double, char, String) as needed.
This will break the build as I don't have the magic version of JavaCC used to generate the parser.  It's not JavaCC 4.0.

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5862 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-05 08:40:13 +00:00
Ryan Gustafson
c05badf566 Comment and bug fix.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5861 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-05 06:38:52 +00:00
Ryan Gustafson
40a46d11a9 Vast expansion of Type Resolution scope on the AST to cover every possible (AFAIK) node which can meaningfully have a Type. Type information is being rolled up the AST to the top most nodes, based on expression and operator rules defined in the JLS.
The ternary operator, and PrimaryExpressions are not yet done.  This feature will not work very well until PrimaryExpression are handled, as this node appears very often.  A failure at this level could stop the progress of the rollup, seriously limiting utility.

Also, some Parser changes are needed to (1) annotate literals with their type, and (2) know the dimensionality of array types.

Yeah, need to write a boatload of test cases too. :)


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5860 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-05 06:36:33 +00:00
Ryan Gustafson
8253ad505c Change a bunch of the AST nodes to also be TypeNodes.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5859 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-05 06:22:49 +00:00