3929 Commits

Author SHA1 Message Date
Tom Copeland
f0a48190cf better test case... we should catch some of these...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4061 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-13 23:16:01 +00:00
Tom Copeland
8c465324e5 Fixed bug 1379701 - CompareObjectsWithEquals no longer flags comparisons of array elements. Thanks to George Sexton for the report!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4060 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-13 23:13:34 +00:00
Tom Copeland
e1021e2f39 More links for names
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4059 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-13 23:06:17 +00:00
Tom Copeland
924f5e42f4 Fixed bug 1277373 - InefficientStringBuffering no longer flags concatenations that involve a static final String.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4058 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-13 22:46:33 +00:00
Tom Copeland
c7304c93cc Some comments on a better symbol API
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4057 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-12 22:03:56 +00:00
Tom Copeland
771bca32bc Fixed a FIXME; NullAssignment is a bit faster now. Also moved a utility method up into SimpleNode; I think this is something that either Wouter or Allan had suggested a while back...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4056 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-12 21:56:24 +00:00
Tom Copeland
e673e02398 Fixed bug 1371741 - UncommentedEmptyConstructor no longer flags constructors that consist of a this() or a super() invocation. Thanks to Johan for the patch!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4055 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-12 14:31:10 +00:00
Tom Copeland
70c69f7e68 Fixed bug 1378358 - StringInstantiation no longer throws ClassCastExceptions on certain allocation patterns. Thanks to Bruce Kelly for the report!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4054 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-12 00:54:18 +00:00
Tom Copeland
7e46a5ac34 Fixed a FIXME; more symbol table usage and less aimless looping
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4053 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-10 01:54:01 +00:00
Tom Copeland
2a58a6ee31 Rebuilt JavaCC parser with JavaCC 4.0beta1. As far as I can see, the speed is about the same as JavaCC 3.2.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4052 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-10 01:30:24 +00:00
Tom Copeland
dc569f9c0c Added current CLASSPATH to pmd.bat.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4051 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-09 20:08:27 +00:00
Tom Copeland
d27c7d04c5 Tweaked textrenderer
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4050 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-09 19:20:14 +00:00
Tom Copeland
92bd69e8e1 Fixed bug 1376756 - UselessOverridingMethod no longer throws an exception on overloaded methods.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4049 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-09 16:46:12 +00:00
Tom Copeland
7ab93baff5 Renamed InefficientStringBufferAppend to AppendCharacterWithChar
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4048 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-09 14:22:12 +00:00
Tom Copeland
247f5d06cc Fixed bug 1376760 - InefficientStringBuffering no longer throws a NullPointerException when processing certain expressions.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4047 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-09 01:01:43 +00:00
Tom Copeland
4cdc84d6b1 Allan Caplan's implementation of InefficientStringBufferAppend, thanks Allan!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4046 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-08 22:43:59 +00:00
Tom Copeland
de503c7d68 Modified renderers to support disabling printing of suppressed warnings. Introduced a new AbstractRenderer class that all Renderers can extends to get the current behavior - that is, suppressed violations are printed. Thanks to Wouter Zelle for the suggestion!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4045 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-08 22:19:04 +00:00
Tom Copeland
2edee46592 rls preps
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4043 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-08 14:30:12 +00:00
Tom Copeland
68b29b63dd real name
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4042 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-07 14:43:34 +00:00
Tom Copeland
3c30f87645 Fixed a bug in UseStringBufferLength; it no longers fails with an exception on expressions like StringBuffer.toString.equals(x)
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4041 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-07 14:30:32 +00:00
Tom Copeland
0ffa485b78 Fixed bug 1375290 - @SuppressWarnings annotations are now implemented correctly; they accept one blank argument to suppress all warnings.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4040 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-07 14:13:15 +00:00
Tom Copeland
e36d15c239 Implemented UseAssertNullInsteadOfAssertTrue; thx to Wim Deblauwe for the suggestion!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4039 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-06 15:08:12 +00:00
Tom Copeland
845cf1e773 A bit more on bug 1373510 - UseAssertSameInsteadOfAssertTrue no longer has a typo in its message, and its message is more clear.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4038 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-06 14:51:27 +00:00
Tom Copeland
5888025a5c Fixed bug 1373510 - UseAssertSameInsteadOfAssertTrue no longer has a typo in its message, and its message is more clear.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4037 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-05 22:52:11 +00:00
Tom Copeland
bc65b92d52 UnusedFormalParameter now catches unused constructor parameters, and its warning message now reflects whether it caught a method or a constructor param.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4036 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-05 22:44:19 +00:00
Tom Copeland
1a0bf9097f New article
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4035 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-05 22:19:59 +00:00
Jiger Patel
a1af2b6e78 Updated to PMD 3.4
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4034 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-05 06:58:32 +00:00
Tom Copeland
200bf7d6e8 Added links to latest rls and notes; thx to Elliotte Rusty Harold for the suggestion
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4033 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-03 20:21:42 +00:00
Tom Copeland
72f8fcd08e import cleanup
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4032 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-02 21:43:22 +00:00
Tom Copeland
19c5f9f2dd Updated to PMD 3.4; cleaned up examples in preferences panel; new location for JDev installs
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4031 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-02 21:38:35 +00:00
Tom Copeland
60f5fa71bb Fixed bug 1371980 - InefficientStringBuffering no longer flags StringBuffer methods other than append().
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4030 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-02 21:16:22 +00:00
Tom Copeland
632d50d123 Partially fixed bug 1371753 - UnnecessaryLocalBeforeReturn message now reflects the fact that that rule flags all types
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4029 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-02 15:11:54 +00:00
Tom Copeland
1baf5b609a Fixed bug 1371757 - Misleading example in AvoidSynchronizedAtMethodLevel
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4028 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-02 15:08:21 +00:00
Tom Copeland
2df14d9c69 Fixed bug 1277373 - InefficientStringBuffering now catches more cases.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4027 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-01 22:31:16 +00:00
Tom Copeland
2098512e01 Applied Allan Caplan's IntegerInstantiation new rule patch, thanks Allan!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4026 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-01 22:11:14 +00:00
Tom Copeland
a7c4776e7d rls preps
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4024 51baf565-9d33-0410-a72c-fc3788e3496d
2005-11-30 21:24:31 +00:00
Tom Copeland
6ca9c49f29 rls preps
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4023 51baf565-9d33-0410-a72c-fc3788e3496d
2005-11-30 20:56:05 +00:00
Tom Copeland
725b6293d0 Skipping parts of JGraphT now
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4022 51baf565-9d33-0410-a72c-fc3788e3496d
2005-11-30 05:48:25 +00:00
Tom Copeland
959f08ce33 Added ArgoUML; new CPD argument style
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4021 51baf565-9d33-0410-a72c-fc3788e3496d
2005-11-30 05:08:23 +00:00
Tom Copeland
5d55205d14 CVSROOT now stored in jobs file
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4020 51baf565-9d33-0410-a72c-fc3788e3496d
2005-11-30 04:51:38 +00:00
Tom Copeland
b77c37e63a Updated to PMD 3.3, jobs file is in YAML now; generally, prepping to make it work on places other than sourceforge
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4019 51baf565-9d33-0410-a72c-fc3788e3496d
2005-11-29 23:11:18 +00:00
Tom Copeland
2d02c396dd typo
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4018 51baf565-9d33-0410-a72c-fc3788e3496d
2005-11-29 21:55:57 +00:00
Tom Copeland
a9c1f4d58b Fixed bug 1364816 - ImmutableField no longer reports false positives for fields assigned in a anonymous inner class in a constructor.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4017 51baf565-9d33-0410-a72c-fc3788e3496d
2005-11-29 21:47:35 +00:00
Tom Copeland
5bca7cfd86 Added Fabio Insaccanebbia's two new rules - ClassCastExceptionWithToArray and AvoidDecimalLiteralsInBigDecimalConstructor
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4016 51baf565-9d33-0410-a72c-fc3788e3496d
2005-11-29 14:50:17 +00:00
Tom Copeland
37fe1d78ce More externalInfoUrl additions
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4015 51baf565-9d33-0410-a72c-fc3788e3496d
2005-11-29 03:07:37 +00:00
Tom Copeland
0b06547f9d More externalInfoUrl additions
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4014 51baf565-9d33-0410-a72c-fc3788e3496d
2005-11-29 02:58:16 +00:00
Tom Copeland
9e8e4959a8 More externalInfoUrl additions
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4013 51baf565-9d33-0410-a72c-fc3788e3496d
2005-11-29 02:58:15 +00:00
Tom Copeland
7d4e60a428 More externalInfoUrl additions
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4012 51baf565-9d33-0410-a72c-fc3788e3496d
2005-11-29 02:22:52 +00:00
Tom Copeland
e9561cbd43 Added externalInfoUrl to all design rules
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4011 51baf565-9d33-0410-a72c-fc3788e3496d
2005-11-29 02:13:33 +00:00
Tom Copeland
0d045bad4b Applied Johan Stuyts' excellent patch for UncommentedEmptyMethod and UncommentedEmptyConstructor; thanks Johan!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4010 51baf565-9d33-0410-a72c-fc3788e3496d
2005-11-29 01:58:01 +00:00