hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity
4,285 Commits 16 Branches 123 Tags
Commit Graph

4285 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Tom Copeland
f9ce45ff1e Some fixes from Sven Jacob for the DFA layer 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4496 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-08-23 13:19:33 +00:00
Allan Caplan
9004416f52 1544564 - LooseCoupling rule doesn't check ArrayList 
Added ArrayList and java.util.ArrayList to the list of implementation classes for this test to cover.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4495 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-08-22 13:25:32 +00:00
Tom Copeland
918ec92547 More CPD GUI tweaks from Brian Remedios; thanks Brian! 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4494 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-08-17 13:29:23 +00:00
Jiger Patel
4af46645f7 1. Added new option "Print Rulename in ErrorList" which is helpful to trace down what rule is generating this error. 
2. Lots of code cleanup using PMD!


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4493 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-08-16 09:42:52 +00:00
Tom Copeland
f67b9f269d Added a nice new XML to HTML stylesheet for CPD 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4492 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-08-14 14:09:56 +00:00
Jiger Patel
6b6ef1e31b Removed SOP 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4491 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-08-09 09:41:39 +00:00
Jiger Patel
1cc144ac10 Changed the way Rules are managed and given for execution to PMD due to addition of new languages to PMD and was giving error due to language mismatch. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4490 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-08-09 09:25:08 +00:00
Tom Copeland
cd6b4fcb33 Fixed bug 1531236 - IdempotentOperations reports fewer false positives. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4489 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-08-09 04:44:00 +00:00
Tom Copeland
2404377dbb Fixed bug 1531152 - CloneThrowsCloneNotSupportedException now reports the proper line number. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4488 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-08-09 04:33:13 +00:00
Tom Copeland
95da3310a4 *** empty log message *** 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4487 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-08-09 04:16:57 +00:00
Tom Copeland
9626cb63c1 Modified C++ tokenizer to use the JavaCC STATIC option; this results in about a 30% speedup in tokenizing. Also improved error messages. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4486 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-08-09 04:14:41 +00:00
Tom Copeland
07376a9373 Cleaning this up so it doesn't use the deprecated methods... they will go away soon 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4485 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-08-09 04:14:22 +00:00
Jiger Patel
e8e04d79b6 Fixed UI Layout issues in PMD Options 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4484 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-08-08 11:58:44 +00:00
Tom Copeland
d30395dc3e *** empty log message *** 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4483 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-08-07 14:51:56 +00:00
Tom Copeland
a08ec714df rls preps 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4481 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-08-07 14:25:11 +00:00
Tom Copeland
5cb7088581 Fixed bug 1531593 - UnnecessaryConversionTemporary no longer reports false positives when toString() is invoked inside the call to 'new Long/Integer/etc()'. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4480 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-08-03 14:48:57 +00:00
Tom Copeland
656b7856ad Many improvements to CPD - mostly the GUI, but also efficiency tweaks in the renderers. Thanks to Brian Remedios for the code! 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4479 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-08-01 21:59:19 +00:00
Tom Copeland
008c2e2ffc updating to pmd 3.7 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4478 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-08-01 13:28:45 +00:00
Tom Copeland
83e9e58e52 Moved JSP/JSF rulesets to rulesets/jsprulesets.properties 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4477 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-08-01 02:01:50 +00:00
Tom Copeland
bf2c11d7f0 Added Paul Duvall's article 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4476 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-08-01 01:56:30 +00:00
Tom Copeland
5a99552371 Fixed bug 1529805 - UnusedModifier no longer throws NPEs on JDK 1.5 enums. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4475 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-07-28 12:59:35 +00:00
Tom Copeland
f9274c68bb Added AE since they wrote the JSP integration, good stuff 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4474 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-07-27 21:30:05 +00:00
Allan Caplan
ad5981d3ad Fixed bug 1462189 - InsufficientStringBufferDeclaration now resets when it reaches setLength the same way it does at a Constructor 
Fixed bug 1497815 - InsufficientStringBufferDeclaration rule now takes the length of the constructor into account, and adds the length of the initial string to its initial length


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4473 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-07-26 00:37:53 +00:00
Allan Caplan
7f1359d2b8 Performance improvement for the SingularField rule. 
Scanning PMD src goes from 2minutes down to 25 seconds. Performance improvement is huge on larger sources - 7,000 classes scanned in 4 minutes down from 55!

Also fixed defect 1526530 SingularField False Negativesrule now detects problems inside static and constructor blocks


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4472 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-07-23 23:58:15 +00:00
Tom Copeland
972b7499af Another optimization, thanks Brian! 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4471 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-07-21 21:50:48 +00:00
Tom Copeland
8f38c0cbca More cleanup of leftover stuff that was replaced by JJTree's conditional node descriptors 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4470 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-07-21 21:49:37 +00:00
Tom Copeland
93a4e04045 Oops, typo 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4469 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-07-21 21:33:53 +00:00
Tom Copeland
8d8a5dffaa More code cleanups from Brian Remedios - a new StringUtil method and mods to some rules to use it 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4468 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-07-21 21:27:11 +00:00
Tom Copeland
3841173de9 Added the image to the ASTEnumConstant nodes. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4467 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-07-21 13:22:47 +00:00
Tom Copeland
313e7487cc Added basic-js[p|f] 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4466 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-07-14 01:37:49 +00:00
Allan Caplan
323ac323e0 Performance improvement for the UseStringBufferForStringAppends rule. 
Scanning PMD src goes from 50 seconds down to 15 seconds. Performance improvement is more marked on larger sources - 7,000 classes scanned in 3 minutes down from 25!

Also fixed defect 1522056 UseStringBufferForStringAppends, rule now detects problems inside static and constructor blocks


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4465 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-07-14 00:44:29 +00:00
Allan Caplan
32cd292fa3 Performance improvement for the BooleanInstantiation rule. 
Scanning PMD src goes from 28 seconds down to 15 seconds. Performance improvement is more marked on larger sources - 7,000 classes scanned in 4 minutes down from 6.

Also fixed defect 1522054. Boolean instantiations inside method calls were not detected - they're now caught.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4464 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-07-14 00:36:03 +00:00
Allan Caplan
60c2d63928 Fix for defect 1500176 - PreserveStackTrace false positive 
The rule was only checking the throw statement - changed to look the exception declaration.

To confirm, ran against XOM. The use case submitted did not flag, though there were a few other valid violations


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4463 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-07-12 01:19:51 +00:00
Allan Caplan
44ca315a27 Performance improvement for the UnnecessaryReturn rule. 
Scanning PMD src goes from 30 seconds down to 15 seconds. Performance improvement is more marked on larger sources - 7,000 classes scanned in 2.5 minutes down from 5.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4462 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-07-12 00:57:38 +00:00
Allan Caplan
88b00ddc84 Performance improvement for the UseStringBufferForStringAppends rule. 
Scanning PMD src goes from 50 minute down to 15 seconds. Performance improvement is more marked on larger sources - 7,000 classes scanned in 3 minutes down from 25!

This is an initial check-in. I found some peculiar behavior with the original implementation, will update the optimizations.xml file once a question is answered.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4461 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-07-11 01:24:46 +00:00
Allan Caplan
9bd1ae6311 Performance improvement for the OverrideBothEqualsAndHashcode rule. 
Scanning PMD src goes from 30 minute down to 15 seconds. Performance improvement is more marked on larger sources - 7,000 classes scanned in 3 minutes down from 6.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4460 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-07-11 01:12:57 +00:00
Tom Copeland
a06d2be5b3 Fixed Ant docs bug 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4459 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-07-10 21:14:24 +00:00
Tom Copeland
2906ba0c0b Added Ctrl-L to C grammar SKIP spec 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4458 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-07-10 12:54:05 +00:00
Allan Caplan
da3fbd613b Performance improvement for the UselessOperationOnImmutable rule. 
Scanning PMD src goes from 1 minute down to 13 seconds.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4457 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-07-09 00:38:11 +00:00
Tom Copeland
fba11e3193 Last bit of patch from Brian Remedios 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4456 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-07-08 06:21:17 +00:00
Tom Copeland
82fe930160 new articles 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4455 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-07-08 06:03:13 +00:00
Tom Copeland
dc9f4d69a0 Another tweak to the C grammar, this time to the character token definition 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4454 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-07-08 05:49:25 +00:00
Tom Copeland
bbb332dc60 More improvements from Jarkko... can _almost_ parse entire Perl codebase now! 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4453 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-07-08 05:38:12 +00:00
Tom Copeland
19776ec84b Implemented RFE 1501850 - UnusedFormalParameter now catches cases where a parameter is assigned to but not used. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4452 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-07-08 04:10:23 +00:00
Tom Copeland
9ee96d6949 Improved Designer look and functionality thanks to Brian Remedios. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4451 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-07-08 03:38:20 +00:00
Tom Copeland
5ae23dde91 Hm, something's awry with consoleRenderer here 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4450 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-07-06 14:32:02 +00:00
Tom Copeland
7fd1531f86 Code cleanup; thanks to Brian Remedios! 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4449 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-07-06 12:47:25 +00:00
Tom Copeland
8dd1122290 Using the JavaCC CACHE_TOKENS option to optimize the parser slightly. This option makes the parser slightly smaller (about 2KB) and very slightly faster 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4448 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-07-06 12:13:31 +00:00
Tom Copeland
e85ed94ce5 *** empty log message *** 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4447 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-07-04 12:00:45 +00:00
Tom Copeland
10669885ac Fixed bug 1516728 - UselessOverridingMethod no longer raises an NPE on methods that use generics. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4446 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-07-04 11:58:29 +00:00