hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity
28,690 Commits 16 Branches 123 Tags 510 MiB
Commit Graph

8597 Commits

Author SHA1 Message Date
Andreas Dangel
f4941433ce Merge branch 'main' into rename-defaultlabelswitch 2024-10-18 16:39:12 +02:00
Andreas Dangel
ef0db9a166 Merge branch 'main' into issue-5249-5250 2024-10-18 16:30:01 +02:00
Andreas Dangel
dafdc964a5 Merge branch 'main' into issue-3362 2024-10-18 16:22:17 +02:00
Andreas Dangel
fb94e2493c Merge branch 'main' into issue-5030 2024-10-18 16:20:11 +02:00
Andreas Dangel
f317e8bee5 Merge branch 'main' into java-unit-test-rules 2024-10-18 16:15:51 +02:00
Andreas Dangel
5ffb953191 [java] CouplingBetweenObjects: improve violation message 
When we add the actual count to the message,
we can more easily verify that the rule works
as expected.
 2024-10-18 10:42:42 +02:00
Andreas Dangel
867b142ee4 Use plugin-classpath to simplify javacc-wrapper.xml 
javacc is on the antrun plugin's classpath.
The javacc jar file doesn't need to be copied
explicitly.
 2024-10-13 12:28:16 +02:00
Aryant Tripathi
9a123bff94 Support wrapper class in BooleanGetMethodName rule (#5253)\n \n - Updated XPath rule to include both primitive and wrapper class:\n (PrimitiveType[@Kind = 'boolean'] or ClassType[pmd-java:typeIs('java.lang.Boolean')])\n - Added test cases to ensure that methods returning are also flagged correctly.\n - Ensured the rule enforces consistent method naming for both primitive and wrapper types. 2024-10-11 22:37:01 +05:30
Aryant Tripathi
9077c6a71f Support wrapper class in BooleanGetMethodName rule (#5253)\n \n - Updated XPath rule to include both primitive and wrapper class:\n (PrimitiveType[@Kind = 'boolean'] or ClassType[pmd-java:typeIs('java.lang.Boolean')])\n - Added test cases to ensure that methods returning are also flagged correctly.\n - Ensured the rule enforces consistent method naming for both primitive and wrapper types. 2024-10-11 22:34:07 +05:30
Aryant Tripathi
36f713b4c7 Merge branch 'pmd:main' into 5253/feature/support-boolean-wrapper-in-get-method-rule 2024-10-11 22:30:29 +05:30
Aryant Tripathi
ed6312e3ba Support wrapper class in BooleanGetMethodName rule (#5253)\n \n - Updated XPath rule to include both primitive and wrapper class:\n (PrimitiveType[@Kind = 'boolean'] or ClassType[pmd-java:typeIs('java.lang.Boolean')])\n - Added test cases to ensure that methods returning are also flagged correctly.\n - Ensured the rule enforces consistent method naming for both primitive and wrapper types. 2024-10-11 22:29:42 +05:30
Aryant Tripathi
8b2af2db8a Support wrapper class in BooleanGetMethodName rule (#5253) 
- Updated XPath rule to include both  primitive and  wrapper class:
                  (PrimitiveType[@Kind = 'boolean'] or ClassType[pmd-java:typeIs('java.lang.Boolean')])
                - Added test cases to ensure that methods returning  are also flagged correctly.
                - Ensured the rule enforces consistent method naming for both primitive and wrapper types.
 2024-10-10 20:44:06 +05:30
Aryant Tripathi
54dfabea9b Support Boolean wrapper class for BooleanGetMethodName rule (#5253) 2024-10-09 10:00:02 +05:30
Andreas Dangel
07840cace2 [java] Rename rule SwitchStmtsShouldHaveDefault to NonExhaustiveSwitch 
Fixes #4286
 2024-10-08 17:33:32 +02:00
Andreas Dangel
ff1b9b2cdd [java] SwitchStmtsShouldHaveDefault - test for multiple case constants 2024-10-08 17:15:18 +02:00
Clément Fournier
b724b4dd33 Fix DataflowPassTest 2024-10-07 18:18:32 +02:00
Clément Fournier
2c1a7f026e Fix NPE with empty pattern list 2024-10-07 16:51:50 +02:00
Andreas Dangel
5ecc29245b Fix externalInfoUrl after rename 2024-10-05 11:37:45 +02:00
Andreas Dangel
079eb238b9 [java] NonCaseLabelInSwitch - support switch expressions 
Rename rule from NonCaseLabelInSwitchStatement

- as it applies to both switch statements and switch expressions
- extend the test cases to cover new java syntax
 2024-10-05 11:19:53 +02:00
Andreas Dangel
b3157825d8 [java] Rename rule DefaultLabelNotLastInSwitch 
- as it applies to both switch statements and switch expressions
- extend the test cases to cover new java syntax

Note: For patterns in switch, the java compiler already makes sure, that
default is the last case.
 2024-10-05 11:00:13 +02:00
Andreas Dangel
6f081e111a Update pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/performance/xml/TooFewBranchesForSwitch.xml 2024-10-05 10:41:10 +02:00
Andreas Dangel
59403fc9e1 [java] SwitchStmtsShouldHaveDefault - also ignore record pattern 2024-10-05 10:39:55 +02:00
Andreas Dangel
13cc79af62 [java] TooFewBranchesForSwitch - also ignore record pattern 2024-10-05 10:36:39 +02:00
Andreas Dangel
1f31f771ad [java] SwitchDensity - more tests with (record) patterns 2024-10-05 10:31:40 +02:00
Andreas Dangel
d9db4dbcab [java] Rename TooFewBranchesForSwitch in quickstart.xml 2024-10-05 10:19:03 +02:00
Andreas Dangel
855e5175d4 [java] Renamed rule TooFewBranchesForSwitch 
as it consider Switch Expressions now
additionally to Switch Statements.
 2024-10-04 17:48:56 +02:00
Andreas Dangel
b87944a565 [java] TooFewBranchesForSwitch should consider Switch Expressions 
Fixes #5250
 2024-10-04 17:48:49 +02:00
Andreas Dangel
90f436fd28 [java] TooFewBranchesForSwitch should ignore Pattern Matching 
Fixes #5249
 2024-10-04 17:47:21 +02:00
Andreas Dangel
375fb72f3c [java] Fix tree dump test 
New SwitchLabel#PatternLabel flag
 2024-10-04 17:32:46 +02:00
Andreas Dangel
49deb8d4a0 [java] SwitchDensity false positive with pattern matching 
Fixes #5030
 2024-10-04 17:12:29 +02:00
Andreas Dangel
312d8e46ae [java] ImplicitSwitchFallThrough should consider switch expressions 
Fixes #3362
 2024-10-04 16:45:29 +02:00
Andreas Dangel
0c858b0a7b [java] SwitchStmtsShouldHaveDefault should ignore patterns 
Fixes #4813
 2024-10-04 16:05:45 +02:00
Andreas Dangel
a0818d5ab2 [doc] Document renamed/old rule names 2024-10-04 15:54:21 +02:00
Andreas Dangel
c6fd064054 Merge branch 'main' into pr-5225 2024-10-04 10:02:40 +02:00
Andreas Dangel
c0023dd942 [java] Rename UnitTestShouldIncludeAssert again 
to make it consistent and always use singular "UnitTest"
Follow-up on #4532 and #4965
 2024-10-04 09:32:55 +02:00
Andreas Dangel
9fbaa4fbfb [java] Update quickstart.xml with renamed UnitTest* rules 2024-10-04 09:25:21 +02:00
Andreas Dangel
9337e5a7a2 [java] UnitTestShouldUseAfterAnnotation: Consider JUnit 5 and TestNG 2024-10-03 20:55:11 +02:00
Andreas Dangel
33c737718c [java] UnitTestShouldUseBeforeAnnotation: Consider JUnit 5 and TestNG 2024-10-03 20:55:10 +02:00
Andreas Dangel
463ca964dc [java] Rename JUnit rules with overly restrictive names (#4965) 
Merge pull request #4965 from Monits:issue-4532
 2024-10-03 20:07:50 +02:00
Andreas Dangel
525435bd68 [java] Keep bestpractices.xml sorted alphabetically 2024-10-03 19:59:29 +02:00
Andreas Dangel
c5246eca46 Renamed JUnit4TestShouldUseAfterAnnotation 
- call it UnitTest... to be agnostic to the testing framework
 2024-10-03 19:52:56 +02:00
Andreas Dangel
4796da0fb2 Renamed JUnit4TestShouldUseBeforeAnnotation 
- call it UnitTest... to be agnostic to the testing framework
 2024-10-03 19:51:13 +02:00
lukasgraef
7dcab3f189 Fix static analysis findings 2024-09-30 20:48:20 +02:00
lukasgraef
39b8bdf171 Review Finding: Check for type java.nio.FileSystems 2024-09-30 20:13:01 +02:00
Andreas Dangel
5fe19b2096 [release] Prepare next development version [skip ci] 2024-09-27 11:43:22 +02:00
Andreas Dangel
d8d4d3d061 [release] prepare release pmd_releases/7.6.0 2024-09-27 11:08:53 +02:00
Andreas Dangel
4930e98706 [java] Fix #5046 - FPs in LocalVariableCouldBeFinal (#5191) 
Merge pull request #5191 from oowekyala:issue5046-localVariableCouldBeFinal-fp-catch
 2024-09-26 15:21:51 +02:00
lukasgraef
ddb1eb8dd8 [java] Fix #5067: CloseResource: False positive for FileSystems.getDefault() 2024-09-21 16:03:36 +02:00
lukasgraef
8ea3f32f5f [java] Fix #5068: Class incorrectly identified as non-instantiatable 2024-09-21 14:12:12 +02:00
Juan Martín Sotuyo Dodero
59c88e9bb0 Adjust skip signature to fix #5207 2024-09-14 00:34:23 -03:00