Commit Graph
146 Commits
Author SHA1 Message Date
Brian Remedios 5e6bc27747 Numerous bugfixes, improved XPath rule creation validation
Specified default 'user-specified' priority names
Renamed remaining MSGKEY-prefixed String keys
New reset-to-default-values in rule properties menu (single item for now)
New PMD Name column in marker prefs table & new column tooltips for same
Commented-out original PMD preferences view from main preference tree
Repositioned Language min/max & priority fields
Updated to latest PMD core

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7137 51baf565-9d33-0410-a72c-fc3788e3496d
2010-09-15 08:43:46 +00:00
Brian Remedios e29823112f updated PMD jar
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7135 51baf565-9d33-0410-a72c-fc3788e3496d
2010-09-12 07:09:52 +00:00
Brian Remedios 18f544c28e updated PMD jar with latest changes
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7134 51baf565-9d33-0410-a72c-fc3788e3496d
2010-09-12 07:07:57 +00:00
Brian Remedios 2c28d1aac1 misc
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7131 51baf565-9d33-0410-a72c-fc3788e3496d
2010-09-11 03:32:35 +00:00
Brian Remedios 37d5ee01f4 RulePriority preferred name fixes
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7130 51baf565-9d33-0410-a72c-fc3788e3496d
2010-09-11 03:19:28 +00:00
Brian Remedios cc3fda5fe5 +minor enhancements
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7129 51baf565-9d33-0410-a72c-fc3788e3496d
2010-09-11 01:03:43 +00:00
Brian Remedios b9f22db286 misc
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7128 51baf565-9d33-0410-a72c-fc3788e3496d
2010-09-10 09:37:13 +00:00
Brian Remedios 39453cd5be bugfix
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7127 51baf565-9d33-0410-a72c-fc3788e3496d
2010-09-10 09:27:29 +00:00
Brian Remedios bc4305a73f refactoring priority-related items into new package
XPath rule handling
new bug list

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7126 51baf565-9d33-0410-a72c-fc3788e3496d
2010-09-10 08:51:18 +00:00
Brian Remedios af91a0f339 minor bugfixes
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7124 51baf565-9d33-0410-a72c-fc3788e3496d
2010-09-09 07:30:56 +00:00
Brian Remedios a06668b06a minor misc..
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7123 51baf565-9d33-0410-a72c-fc3788e3496d
2010-09-07 16:10:49 +00:00
Brian Remedios f90e41283f Refactored ASTView & DataflowView with new superclass, improved NewPropertyDialog error handling
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7122 51baf565-9d33-0410-a72c-fc3788e3496d
2010-09-07 08:39:18 +00:00
Brian Remedios 7c8c154316 Decorator-related bugfixes
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7121 51baf565-9d33-0410-a72c-fc3788e3496d
2010-09-02 09:02:55 +00:00
Brian Remedios 37a510861e reworked column hiding approach
+CollapseAll controls for more views
+Derivative labeling for AST nodes

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7120 51baf565-9d33-0410-a72c-fc3788e3496d
2010-09-02 07:28:18 +00:00
Brian Remedios dcb32eb683 misc
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7119 51baf565-9d33-0410-a72c-fc3788e3496d
2010-09-02 02:16:55 +00:00
Brian Remedios b36928b173 property change handlers for views, string updates
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7118 51baf565-9d33-0410-a72c-fc3788e3496d
2010-09-02 02:00:49 +00:00
Brian Remedios 9f3712c728 refactoring, removing redundant MSGKEY_ prefixes
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7117 51baf565-9d33-0410-a72c-fc3788e3496d
2010-09-01 04:57:16 +00:00
Brian Remedios 6dd9058c7f Better details in method lists, separate header/body menus in rule table, proper hide/show behaviour in Exclusion panel
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7116 51baf565-9d33-0410-a72c-fc3788e3496d
2010-08-31 09:46:56 +00:00
Brian Remedios 289d1dce9d Lots of nice updates:
* Colour syntax highlighting for all relevant editors & example viewers.
* User-selectable marker shapes and colours, violation decorators in the navigator tree
* New AST view and related XPath test editor
* Rule search (page form only, non-functional)

Disabled Quickfix views until its ready
Zapped several nevarious bugs in previous functionality

Note: for the time being, violation errors will not appear in the Problems
      page. There is a conflict between having unique markers and 'standard'
      error markers that denote inclusion in the error page. Will check out
      the use of annotations to deal with this...

For evaluation:
   The size and scope of the rule editor is (I believe) outgrowing its
   placement within its preference page and it needs to be parked within
   it own view. Besides, tracking all the edits being made to the rules
   goes beyond what the pref pages can handle (i.e. apply/cancel...
   which never worked properly for the rules in any case)

   To that end, I've copied the rule table into its own view for now and
   left the one in the preference page as is so we can compare & contrast.
   Only one will remain by the time the best approach is chosen.

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7115 51baf565-9d33-0410-a72c-fc3788e3496d
2010-08-31 05:31:48 +00:00
Brian Remedios 90a97847ec test commit, bugfix
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7114 51baf565-9d33-0410-a72c-fc3788e3496d
2010-08-31 02:55:25 +00:00
Brian Remedios c1f54d7444 +missing additional changes
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7113 51baf565-9d33-0410-a72c-fc3788e3496d
2010-08-03 03:48:48 +00:00
Brian Remedios e9ba34b45a New ability to use different shapes & colours to denote the various rule priorities (new UISettings class).
Will eventually allow these to be user-specified and part of the markup in the vertical rulers.
Revised ViolationView priority filter buttons to match.

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7112 51baf565-9d33-0410-a72c-fc3788e3496d
2010-08-03 03:46:13 +00:00
Brian Remedios c316c4363a + class missing from previous update
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7111 51baf565-9d33-0410-a72c-fc3788e3496d
2010-07-30 22:22:14 +00:00
Brian Remedios 088f9ad32c Updated priority displays, bugfix for enum property editor, revised labeling for group column header, separate column (&sorting) for checkboxes, revised own TODO list
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7110 51baf565-9d33-0410-a72c-fc3788e3496d
2010-07-30 22:20:48 +00:00
Brian Remedios 3e52bf6b27 +properties column now highlights non-default values (still a bit buggy)
+internals: new visitor pattern for manipulating all selections
+able to disable rules from the violation list
+grouped rules show all unique priority values
+revised filter column icons
+revised plugin.xml to export code for other plugins
+new opening Rule panel for Rule creation wizard

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7109 51baf565-9d33-0410-a72c-fc3788e3496d
2010-07-26 05:23:43 +00:00
Brian Remedios 3e134d9ccc upgraded all dependencies to v3.5
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7095 51baf565-9d33-0410-a72c-fc3788e3496d
2010-04-04 05:32:40 +00:00
Brian Remedios 46263cb479 upgraded jface dependency to v3.5
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7094 51baf565-9d33-0410-a72c-fc3788e3496d
2010-03-27 13:14:27 +00:00
Brian Remedios 92eea22e4a updated manifest for new Eclipse dependency
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7093 51baf565-9d33-0410-a72c-fc3788e3496d
2010-03-26 00:52:08 +00:00
Brian Remedios b767617542 Preferences
* Rule activation checkboxes now operational - only the checked rules are used to evaluate code. No longer need to physically remove rules from the ruleset to bypass them. Settings are stored in preferences and the number of active rules is shown in the dialog when PMD runs a scan. Minor UI bug in group-by mode doesn't render parent node checks initially.
* New SelectAll/None buttons and a SortByChecked items button. Replaced several text buttons with icon versions
* Selected rules & property tabs retained by UI preferences between sessions
	
Fixes
* New column in rule table showing number of available fixes per rule (just two for now). The new 'Fixes' tab in the properties folders needs additional work to complete it. The Fix menu option in the violations context menu works now for the two rules that have them. Need to provide better storage for rule-fix associations - current approach only stores fix classnames - should support classname + static instance var.

CPD
* Added launch button for the Swing version of the CPD UI to the preference page. Need to migrate its better functionality to the SWT version.

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7092 51baf565-9d33-0410-a72c-fc3788e3496d
2010-03-26 00:16:57 +00:00
Brian Remedios 4fc136dd9b Refined action enablement for showRule menu option
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7088 51baf565-9d33-0410-a72c-fc3788e3496d
2010-03-04 19:22:52 +00:00
Brian Remedios c5cf47854a Refactored error handling, disable actions when no violations are selected
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7087 51baf565-9d33-0410-a72c-fc3788e3496d
2010-03-04 18:52:30 +00:00
Brian Remedios a7d9d9297e Bugfix
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7086 51baf565-9d33-0410-a72c-fc3788e3496d
2010-03-03 20:58:33 +00:00
Brian Remedios ae0e87daa1 + missing utility class for repository access
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7085 51baf565-9d33-0410-a72c-fc3788e3496d
2010-03-03 16:03:02 +00:00
Brian Remedios c60d6c931c Rule table now shows sort column indicators
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7084 51baf565-9d33-0410-a72c-fc3788e3496d
2010-03-03 15:59:50 +00:00
Brian Remedios 99f1cfff8b new tab icons, updated changelog & plugin.xml
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7083 51baf565-9d33-0410-a72c-fc3788e3496d
2010-03-03 15:53:56 +00:00
Brian Remedios 5b0a32df4e Refactorings: new packages for CPD & dataflow views, new abstract superclasses for actions, commands, views. For-loop conversions, ArrayList -> List reference changes.
Rearranged context menu icons - still need some unique ones for three other entries
Dataflow: NPE fix post view closing, view always shows first method by default, labeled method list, new tab icon, outlined & positioned nodes.

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7082 51baf565-9d33-0410-a72c-fc3788e3496d
2010-03-03 15:51:45 +00:00
Brian Remedios 293f908f25 Centralized marker deletion & sourcing.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7081 51baf565-9d33-0410-a72c-fc3788e3496d
2010-03-03 15:37:07 +00:00
Brian Remedios 1b75a0519b Misc typos, no semantic changes
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7080 51baf565-9d33-0410-a72c-fc3788e3496d
2010-03-03 06:07:17 +00:00
Brian Remedios 167e73fdc8 A better empty string check
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7079 51baf565-9d33-0410-a72c-fc3788e3496d
2010-03-03 04:39:55 +00:00
Brian Remedios 480dda3e32 Updated text-numeric fields to use spinner widgets instead.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7078 51baf565-9d33-0410-a72c-fc3788e3496d
2010-03-03 04:38:29 +00:00
Brian Remedios 231a163f28 Updated dialog with modern spinner widget
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7077 51baf565-9d33-0410-a72c-fc3788e3496d
2010-03-02 02:33:00 +00:00
Brian Remedios 776c05d1f9 Now using native column sort indicators. Go Team Canada!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7076 51baf565-9d33-0410-a72c-fc3788e3496d
2010-02-28 21:35:12 +00:00
Brian Remedios 8751881f86 Bugfix & typos
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7075 51baf565-9d33-0410-a72c-fc3788e3496d
2010-02-27 23:12:57 +00:00
Brian Remedios a2a2c3c321 Minor: replaced icon file names with existing constants
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7074 51baf565-9d33-0410-a72c-fc3788e3496d
2010-02-16 16:23:20 +00:00
Brian Remedios 673e614a38 +Javadoc
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7064 51baf565-9d33-0410-a72c-fc3788e3496d
2010-01-12 01:04:04 +00:00
Brian Remedios 0bf768abb3 minor optimizations
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7063 51baf565-9d33-0410-a72c-fc3788e3496d
2010-01-12 01:00:10 +00:00
Brian Remedios 3d3f4d98eb update ToDo list
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7062 51baf565-9d33-0410-a72c-fc3788e3496d
2010-01-09 16:35:31 +00:00
Brian Remedios a21b1b320b Priority column now uses compact icons, new property editor tester
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7061 51baf565-9d33-0410-a72c-fc3788e3496d
2010-01-09 16:10:44 +00:00
Brian Remedios c114e27594 property editor improvements, i18l updates
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7059 51baf565-9d33-0410-a72c-fc3788e3496d
2010-01-07 05:16:57 +00:00
Brian Remedios 449d70262f Added new XPath filter column that renders coloured circle values.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7056 51baf565-9d33-0410-a72c-fc3788e3496d
2010-01-04 07:59:57 +00:00