4104 Commits

Author SHA1 Message Date
Tom Copeland
1a0e5b39c1 Fixed bug 1415326 - JUnitTestsShouldContainAsserts no longer errors out on JDK 1.5 generics.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4197 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-04 18:53:49 +00:00
Tom Copeland
63b99fbcbb Minor refactoring
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4196 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-03 23:20:31 +00:00
Tom Copeland
2d26de182f UseIndexOfChar now catches cases involving lastIndexOf.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4195 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-03 23:09:51 +00:00
Tom Copeland
8d8aa460a7 Removed duplicate copy of UseIndexOfChar definition
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4194 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-03 23:02:33 +00:00
Tom Copeland
0eb8b74ae7 Fixed bug 1416164 - InefficientStringBuffering no longer reports false positives on the three argument version of StringBuffer.append().
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4193 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-03 22:52:18 +00:00
Radim Kubacki
aa5af02970 http://www.netbeans.org/issues/show_bug.cgi?id=72215 - NPE when a rule has no example
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4192 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-03 16:21:40 +00:00
Allan Caplan
0a4214aeb1 Fixed to use getUsages
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4191 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-03 02:39:44 +00:00
Allan Caplan
709988e74e This is the rule proposed by Brian in
http://sourceforge.net/forum/forum.php?thread_id=1431090&forum_id=188194

This code finds any case where


string.trim().length()==0

comparison is made. Code only looks for 0 specifically,
so if a static instance variable is used to specify 0
it's ignored.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4190 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-03 01:04:18 +00:00
Tom Copeland
a3d1537618 Moved Allan up to the committers section, good times!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4189 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-02 02:26:54 +00:00
Radim Kubacki
74b6df5d7a http://www.netbeans.org/issues/show_bug.cgi?id=72017 - NPE when running on some non Java files
more reliably closing progress handle
and finally I've writen a test for this


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4188 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-01 15:29:59 +00:00
Tom Copeland
f204d3613a Fixed bug 1421409 - Ant task now has setter to allow minimumPriority attribute to be used. Thanks to Paul Smith for the patch!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4187 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-01 14:14:32 +00:00
Tom Copeland
546ec29849 Added 'releases' ruleset for 3.3
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4186 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-01 13:55:45 +00:00
Tom Copeland
916bc2849c Added more rules to 35.xml; added 34.xml
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4185 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-31 06:21:18 +00:00
Tom Copeland
17f255d314 noting Didier's recent reports
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4184 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-31 06:15:44 +00:00
Tom Copeland
5c06e89a6f Implemented RFE 1415487 - Added a rulesets/releases/35.xml ruleset contains rules new to release 3.5. Should retrofit previous releases as well. Thanks to Elliotte Rusty Harold for the suggestion!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4183 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-31 06:14:24 +00:00
Tom Copeland
39caedcfba Implemented RFE 1415487 - Added a rulesets/releases/35.xml ruleset contains rules new to release 3.5. Should retrofit previous releases as well. Thanks to Elliotte Rusty Harold for the suggestion!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4182 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-31 06:14:23 +00:00
Tom Copeland
fb15abd025 Fixed bug 1416167 - AppendCharacterWithChar now catches cases involving escaped characters. Thanks to Allan Caplan for the fix!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4181 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-31 05:58:42 +00:00
Tom Copeland
695fc2d64b Fixed bug 1418424 - ConsecutiveLiteralAppends no longer flags appends in separate methods
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4180 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-31 01:47:45 +00:00
Tom Copeland
17ba896996 *** empty log message ***
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4178 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-31 01:11:54 +00:00
Tom Copeland
bb3f37efa6 rls preps
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4177 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-31 01:08:43 +00:00
Tom Copeland
cda6ece2db corrected name
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4176 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-31 00:13:43 +00:00
Tom Copeland
6a4b879438 rls preps
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4175 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-30 23:14:11 +00:00
Tom Copeland
f5716a9fea rls preps; updated to work with 1013 final and pmd-3.5
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4174 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-30 16:47:48 +00:00
Tom Copeland
b1fa90e9e2 Added xml libs to Class-Path attribute, changed name of OptimalAdvisor
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4173 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-30 14:26:19 +00:00
Tom Copeland
f8b46ea1bd Erik Thauvin suggested this way to avoid problems with quotes in IDEA paths; thanks Erik!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4172 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-30 13:55:20 +00:00
Radim Kubacki
af1bff9706 not needed anymore
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4171 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-29 15:36:31 +00:00
Tom Copeland
72161d7bf2 Applied Allan's patch to fix bug in ConsecutiveLiteralAppends; thanks Allan!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4170 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-29 03:43:15 +00:00
Tom Copeland
da69fd3a0e Applied Allan's patch to fix bug in ConsecutiveLiteralAppends; thanks Allan!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4169 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-29 03:43:14 +00:00
Radim Kubacki
02e820f437 similar file names as before
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4167 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-27 15:06:48 +00:00
Radim Kubacki
4cc6862d8c updated to PMD-3.5, fixed deprecated RuleViolation.getLine(), dist files built with prefix, depends on NB5.0
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4166 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-27 15:04:08 +00:00
Philippe Herlin
deb944f7c5 Fix BUG#1365407 Problems with PMD in Eclipse/Issue 3
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4165 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-27 00:03:11 +00:00
Philippe Herlin
794aadc38a Fix NullPointerException and InvocationTargetException
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4164 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-26 23:57:55 +00:00
Philippe Herlin
6734bbfb10 Fix NullPointerException on marker Priority (??? don't knwon why this happens ???)
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4163 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-26 22:45:11 +00:00
Philippe Herlin
ca83213185 Eclipse environment: add jakarta-oro to the classpath and remove .classpath and .project from .cvsignore
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4162 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-26 21:48:43 +00:00
Philippe Herlin
8ba8a79489 Update the PMD 3.5
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4161 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-26 21:42:09 +00:00
Tom Copeland
e9e5af6452 rls preps
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4159 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-25 14:25:01 +00:00
Tom Copeland
46812705f2 rls preps
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4158 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-25 14:18:39 +00:00
Tom Copeland
e65649c565 Beginning 3.5 rls preps
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4157 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-25 03:18:02 +00:00
Philippe Herlin
88c322dae7 Fix BUG#1365407 Problems with PMD in Eclipse/Issue 1
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4156 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-19 22:49:59 +00:00
Philippe Herlin
6cec39ac3a Add Eclipse contributors
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4155 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-19 22:17:00 +00:00
Philippe Herlin
291ea3aba5 BUG#1359787 Incorrect packaging (eclipse): add additional information on Eclipse integration.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4154 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-19 22:10:22 +00:00
Philippe Herlin
8e08839d5d Fix BUG#1357798 Source file utf-8 charset problem
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4153 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-19 22:00:14 +00:00
Philippe Herlin
0d9985c57a Make the update site adde automatically
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4152 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-19 21:41:11 +00:00
Philippe Herlin
b280bff3ba Fill in release notes
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4150 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-17 22:08:53 +00:00
Philippe Herlin
31ebf5b9ed Add \n to correctly display license text
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4147 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-17 21:32:04 +00:00
Philippe Herlin
dc659118e5 Create a fake node instead of using SimpleNode
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4146 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-17 21:27:37 +00:00
Philippe Herlin
2db29a19c5 Ignore exceptions occuring inside the teardown operation
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4145 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-17 21:26:41 +00:00
Philippe Herlin
77876a2641 Update the PMD 3.4 librairy.
Add jakarta ORO for Regexp support.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4141 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-17 21:23:19 +00:00
Tom Copeland
e58d755134 Moved JDK 1.5 jobs to a different file until I can figure out how to count lines of code there
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4140 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-16 21:55:19 +00:00
Tom Copeland
7ed77999e6 Moved BooleanInversion to controversial ruleset until I can look at it a bit more
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4139 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-13 22:43:15 +00:00