4654 Commits

Author SHA1 Message Date
Radim Kubacki
4f2cc27c9d updating to pmd-3.9
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4920 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-05 16:59:08 +00:00
Allan Caplan
aba82176ff Added descriptions and priorities for the NCSS rules
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4919 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-05 13:55:55 +00:00
Wouter Zelle
f5ee7bd3f1 Bugfix for 1626715. UseAssertSameInsteadOfAssertTrue now works for classes which use the null constant.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4918 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-03 17:52:23 +00:00
Wouter Zelle
b4c3b965d0 Tweak for Ryan's Java rule generator, should also make the rule slightly fater and more robust
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4917 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-03 17:50:40 +00:00
Wouter Zelle
8056367f7a typo
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4916 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-03 17:46:49 +00:00
Allan Caplan
f7df1ce3d0 Fix test
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4915 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-03 13:17:37 +00:00
Allan Caplan
4f64aaa7a5 Applied patch 1612455 from Jason B
RFE 1411022 CompareObjectsWithEquals now catches the case where comparison is against new Object


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4914 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-03 02:45:46 +00:00
Wouter Zelle
dfd2dc3622 Tweak for Ryan's Java rule generator
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4913 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-02 21:58:07 +00:00
Wouter Zelle
6d578f87f9 Bugfixes for 1626232 and 1626201
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4912 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-02 18:14:00 +00:00
Wouter Zelle
9391aaba78 Broken null check rule rewritten to Java and now finds more problems
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4911 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-02 18:08:21 +00:00
Wouter Zelle
307e59391d Fixed serious bugs in both commons logging rules (bug 1626232)
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4910 51baf565-9d33-0410-a72c-fc3788e3496d
2007-01-02 18:01:13 +00:00
Tom Copeland
98762f13d6 Hm, somehow the xml|csv format handling got munged
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4909 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-29 05:55:41 +00:00
Tom Copeland
77797e9489 A hopeful comment...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4908 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-29 05:38:31 +00:00
Tom Copeland
ab576ff5c0 Added an optional --encoding parameter to CPD. It defaults to the file.encoding property, but this lets you specify another encoding for the input files if you're so inclined. Do we also need to allow an output encoding?
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4907 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-29 05:30:14 +00:00
Tom Copeland
45c4b31436 Getting the changelog rolling for 4.0
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4906 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-29 04:53:12 +00:00
Sven Jacob
8fdab14c82 fixed bug when pressing cancel
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4905 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-22 14:20:32 +00:00
Sven Jacob
7e57f6b6cb removed unused variable
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4904 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-22 14:19:39 +00:00
Sven Jacob
24e4419261 fixed bug when ressource changes and methods are deleted that are displayed in the CFG
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4903 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-22 14:17:46 +00:00
Sven Jacob
0bf2e1410e fixed bug
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4902 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-22 14:15:09 +00:00
Sven Jacob
48262206e5 removed unused imports
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4901 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-22 14:12:57 +00:00
Tom Copeland
671f9bf052 *** empty log message ***
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4900 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-22 02:21:18 +00:00
Tom Copeland
47287851b5 Added Maven bundle creation to release process
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4899 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-22 02:19:30 +00:00
Tom Copeland
1be2b58e9e Doh! I had forgotten to upload the site
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4898 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-22 01:52:33 +00:00
Xavier Le Vourch
463bd02c30 bug fix: //ConditionalExpression//ConditionalExpression raised a java.lang.StringIndexOutOfBoundsException
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4897 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-19 19:19:13 +00:00
Tom Copeland
fd96acd61d rls preps
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4895 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-19 14:23:15 +00:00
Tom Copeland
ad6246cdd0 More suppression tests; thanks to Ryan Gustafson for the patch!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4894 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-19 04:07:02 +00:00
Tom Copeland
df56bd7746 Added note about ignore PMD annotations; thank to Jason Bennett for the research
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4893 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-19 04:04:36 +00:00
Allan Caplan
9e7deee88f I've refactored this class to not cache the results any more. This is a
tradeoff in testing I've found the CPU tradeoff is negligeable. With the
cache, large codebases consumed a lot of memory and slowed down greatly when approaching 3,000 classes.

Also fixes some false positives.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4892 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-19 01:02:12 +00:00
Tom Copeland
9f6ee02e66 Patch [ 1615410 ] Various fixes for build with maven 1.x; thanks to Lukas Theussl!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4891 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-18 14:10:10 +00:00
Xavier Le Vourch
aa787a7e26 Oops, 1.5 constructs integrated in previous commit...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4890 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-17 01:54:49 +00:00
Xavier Le Vourch
70ef1ccc2f bug fixes: multithreading issues reported by Ryan Gustafson in the forum
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4889 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-17 01:44:19 +00:00
Allan Caplan
958c6bf91a Fixing some false positives Xavier pointed out
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4888 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-16 01:35:13 +00:00
Xavier Le Vourch
b24c8fe053 DynamicXPathRule is now generated automatically by parsing XPath expression and is transparent to rule writers (based on code by Ryan Gustafson)
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4887 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-15 02:29:37 +00:00
Allan Caplan
753bd13853 Mapping for inner classes had an issue.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4886 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-15 01:48:52 +00:00
Allan Caplan
713256dda1 Fixed bug 1571309 - CLI should recognize leading options
Modified CommandLineOptions to check if the first element starts with a -. If it does, the optional options are first, it therefore looks at the end for the optional args.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4885 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-15 01:10:50 +00:00
Allan Caplan
d0a8f7fedd Adding missing test resource
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4884 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-15 00:34:55 +00:00
Allan Caplan
6cf52f8267 Unit test for patch 1615546
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4883 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-15 00:28:49 +00:00
Allan Caplan
e2f2298ffa Applied patch 1615546 - Added option to command line to write directly to a file
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4882 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-15 00:17:27 +00:00
Allan Caplan
2ad29feced Updating test to reflect change in classloader
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4881 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-14 14:44:12 +00:00
Tom Copeland
d5f48b5146 Fixes from Ryan Gustafson
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4880 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-14 14:18:13 +00:00
Xavier Le Vourch
4269dede06 Applied patch 1615519 - controversial/DefaultPackage XPath rule is wrong
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4879 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-14 08:05:47 +00:00
Xavier Le Vourch
dea96e3059 Bug fix: creating InputStream in different thread lead to resource exhaustion on Linux...; unexepected exception in worker threads now shutdowns the ExecutorService right away
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4878 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-14 04:43:22 +00:00
Allan Caplan
1664005b21 Applied patch 1613674 - Support classpaths with spaces in pmd.bat
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4877 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-14 02:46:17 +00:00
Tom Copeland
7dc290d89e Renamed with Test suffix
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4876 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-14 02:13:30 +00:00
Allan Caplan
db33e92828 Fixed bug 1031966
Re-Implemented CloneMethodMustImplementCloneable as a typeresolution rule. This rule can now detect super classes/interfaces which are cloneable.

The JUnit test was a bit tricky - I've added the interface as an actual concrete interface inside the xml package, and reference it from the xml test definitions. The JUnit works, this sort of design may be needed for other type resolution rules


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4875 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-14 01:33:39 +00:00
Allan Caplan
ca180e0ac2 Adding JUnit tests for the type resolution facility.
This is just a start - more to come


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4874 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-14 01:29:38 +00:00
Allan Caplan
6fff435614 Adding JUnit tests for the type resolution facility.
This is just a start - more to come


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4873 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-14 01:22:19 +00:00
Xavier Le Vourch
fe18d61b70 -cpus command line option added
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4872 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-13 22:04:26 +00:00
Brian Remedios
62d1e9ee73 a minor optimization to test commits in CVS
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4871 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-12 22:19:28 +00:00
Xavier Le Vourch
0f44bce4e5 Multithreaded processing on multi core or multi cpu systems.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4870 51baf565-9d33-0410-a72c-fc3788e3496d
2006-12-12 01:33:39 +00:00