664 Commits

Author SHA1 Message Date
Clément Fournier
845e7ca7a8 Plug into RuleSetFactory 2017-11-08 18:56:09 +01:00
Clément Fournier
d933deed6b Fix merge conflicts 2017-11-08 18:52:53 +01:00
Clément Fournier
8a048fd18d Rule factory and builder 2017-11-08 18:52:53 +01:00
Andreas Dangel
6bba28acbe Add categories.properties files 2017-11-07 22:23:17 +01:00
Juan Martín Sotuyo Dodero
25da0c86f2 Merge branch 'pr-697' 2017-11-06 13:41:27 -03:00
Juan Martín Sotuyo Dodero
9e1342f30a Merge branch 'pr-696' 2017-11-04 19:48:28 -03:00
Juan Martín Sotuyo Dodero
8d381daeb3 Merge branch 'pr-669' 2017-11-04 19:40:14 -03:00
Juan Martín Sotuyo Dodero
5d6a03612e Rename builder method 2017-11-04 19:19:39 -03:00
Juan Martín Sotuyo Dodero
e7e5e13a7d Merge branch 'pr-703' 2017-11-04 18:18:13 -03:00
Andreas Dangel
e064efbad3 [apex] Move AvoidHardCodingId Rule to errorprone 2017-11-04 20:16:04 +01:00
Andreas Dangel
d0b3845ba0 Consider renamed rule MisleadingVariableName in RuleSetFactoryCompatibility 2017-11-04 19:57:31 +01:00
Andreas Dangel
e1a588f499 Merge branch 'master' into ruleset-categories 2017-11-04 19:53:21 +01:00
Andreas Dangel
04c8d0a6c9 Merge branch 'pr-687' 2017-11-04 19:40:56 +01:00
Andreas Dangel
e9425e34d8 [apex] Reorganize rules into categories 2017-11-03 14:05:40 +01:00
Andreas Dangel
c9952e613c [core] fix references to new rules for v6.0.0 2017-11-03 12:04:45 +01:00
Clément Fournier
fc0cb45f49 Merge branch 'master' into properties-builder 2017-11-01 18:21:54 +01:00
Clément Fournier
6b50104cb5 Corrections for PR #669 2017-11-01 18:17:57 +01:00
Juan Martín Sotuyo Dodero
c466179c2a Handle SecurityErrors on bad auxclasspath entries 2017-10-31 01:53:03 -03:00
Matias Comercio
9348c54afb Fix PR - 1
- Remove unnecessary asserts for checking setup
- Improve `for` loop performance in AbstractNode.removeChildAtIndex method
- Remove unnecessary detachment of the node being removed children
2017-10-30 15:39:16 -03:00
Andreas Dangel
42973c4291 [java] Reorganize rulesets into new categories
Best Practices, Code Style, Design, Documentation, Error Prone,
Multithreading, Performance, Security
2017-10-29 21:11:59 +01:00
Matias Comercio
2466ba7163 Add remove & removeChildAtIndex to Node interface
- Implement these methods at AbstractNode.
- Add AbstractNodeTest class with test cases for the implemented methods.
  - Add JUnitParams dependency: https://github.com/Pragmatists/JUnitParams
  - Implement these test cases using JUnitParams features
2017-10-29 13:18:06 -03:00
gonzalo
91b8a22b42 Update GenericToken specialToken method to obtain only comment tokens 2017-10-28 14:42:44 -03:00
gonzalo
e8fdbdbca4 Update GenericToken interface to expose directly region methods 2017-10-28 14:42:44 -03:00
gonzalo
26461e59c1 Simplify method name in GenericToken && improve ant task replacetoken 2017-10-28 14:42:44 -03:00
gonzalo
95835b8134 Update getter in GenericToken 2017-10-28 14:42:44 -03:00
gonzalo
00ed0a1eab Add RegionByLineImpl javadoc 2017-10-28 14:42:44 -03:00
gonzalo
2d01332635 Convert GenericToken from class to interface && Add RegionByLine 2017-10-28 14:42:44 -03:00
Juan Martín Sotuyo Dodero
1308b2c7fa [core] Changes to execution classpath invalidate cache
- Resolves #603
2017-10-25 18:03:13 -03:00
Juan Martín Sotuyo Dodero
20093c809a Rework ruleset loading
- ResourceLoader is now instantiable, and we can tell which classloader
to use to get resources
 - We will always use the execution classloader, or just add the paths
added by ant, but *never* the auxclasspath
 - The classpath added by Ant won't get into the auxclasspath either
2017-10-24 18:07:09 -03:00
Juan Martín Sotuyo Dodero
42d965844f Avoid duplicate code 2017-10-23 17:46:21 -03:00
Juan Martín Sotuyo Dodero
96bb1f4bc7 [core] Support parent-last classloading
- We will now always load classes from auxclasspath during
typeresolution, even if we have a class with the same name in PMD's
classpath
 - This prevents conflicts when using different versions of the same
dependencies
2017-10-23 14:23:05 -03:00
Juan Martín Sotuyo Dodero
fc3da283bd Merge branch 'pr-666' 2017-10-17 13:43:52 -03:00
Juan Martín Sotuyo Dodero
30aa7fca11 Add DoNotExtendJavaLangThrowable to release ruleset 2017-10-17 13:35:45 -03:00
Juan Martín Sotuyo Dodero
2e3e884426 Merge branch 'pr-665' 2017-10-17 13:13:06 -03:00
Andreas Dangel
4f2c7960e6 Update changelog, refs #668 2017-10-16 21:18:06 +02:00
Clément Fournier
c50311bd85 Correct formatter 2017-10-16 00:08:56 +02:00
Clément Fournier
a47471f742 Replace IntegerProperty 2017-10-15 22:22:36 +02:00
Clément Fournier
d891fe048a Fix javadoc warnings on pmd-core 2017-10-15 22:07:34 +02:00
Clément Fournier
13f3651048 Cleanup 2017-10-15 21:56:09 +02:00
Clément Fournier
57631bfb30 Few PoCs 2017-10-15 19:59:58 +02:00
Clément Fournier
12855d3cf2 Fix tests 2017-10-15 18:02:24 +02:00
Clément Fournier
6295a96783 Refactored everything 2017-10-15 17:50:02 +02:00
Clément Fournier
2c16faff36 Refactor numeric properties 2017-10-15 16:45:26 +02:00
Clément Fournier
2d449dbef6 Full builder hierarchy 2017-10-15 16:30:14 +02:00
Clément Fournier
610cd21a9c Clarify design 2017-10-15 15:58:23 +02:00
Clément Fournier
2e272c3f7b More mature design w/ small PoC 2017-10-15 14:42:44 +02:00
Clément Fournier
aff5f20112 Draft of builders 2017-10-15 13:08:47 +02:00
Andreas Dangel
944b2f448b [java] Move rule SignatureDeclareThrowsException from typeresolution to strictexception
Replace existing rule with the typeresolution-based implementation.
2017-10-13 14:04:27 +02:00
Andreas Dangel
8470d32322 [java] Move rule UnusedImports from typeresolution to imports
Replace existing rule with the typeresolution-based implementation.
2017-10-13 12:54:26 +02:00
Andreas Dangel
a89d449169 [java] Move rule CloneMethodMustImplementCloneable from typeresolution to clone
Replace existing rule with the typeresolution-based implementation.
2017-10-13 12:37:04 +02:00