3331 Commits

Author SHA1 Message Date
Tom Copeland
606e83b0f5 Fixed an apparent grammar bug - it wouldn't parse class declarations within methods. I wonder if I broke anything else, though... also, fixed AccessorClassGeneration
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3374 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 03:52:53 +00:00
Tom Copeland
ee2fd2fd2d Fixed CyclomaticComplexity
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3373 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 01:50:33 +00:00
Tom Copeland
4d9fc5a512 A bunch fixed at one fell swoop
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3372 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 01:41:40 +00:00
Tom Copeland
87fbfcb538 Fixed CloseConnection
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3371 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 01:30:35 +00:00
Tom Copeland
83e78918cc Fixed CouplingBetweenObjects
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3370 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 01:24:18 +00:00
Tom Copeland
2ffde8fa44 Fixed EmptyCatchBlock
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3369 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 01:19:41 +00:00
Tom Copeland
5b3efc7ad7 Fixed EmptyStaticInitializer
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3368 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 01:18:07 +00:00
Tom Copeland
0563e34b70 Fixed FinalFieldCouldBeStatic
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3367 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 01:16:30 +00:00
Tom Copeland
7a92aedc44 MethodWithSameNameAsEnclosingClass
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3366 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 01:13:37 +00:00
Tom Copeland
46ed3ec366 Fixed MissingStaticMethodInNonInstantiatable
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3365 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 01:04:38 +00:00
Tom Copeland
5c4ed921d8 Fixed NonStaticInitializer
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3364 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 01:02:36 +00:00
Tom Copeland
487ba9cfdc Fixed OverrideBothEqualsAndHashcode
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3363 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 00:51:23 +00:00
Tom Copeland
0571da05e5 Fixed SimpleDateFormatNeedsLocale
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3362 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 00:47:17 +00:00
Tom Copeland
91ff16f2b0 Fixed SuspiciousConstantFieldName
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3361 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 00:45:36 +00:00
Tom Copeland
19349e9d88 Fixed SuspiciousEqualsMethodName
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3360 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 00:40:36 +00:00
Tom Copeland
1bed68129f Fixed TestClassWithoutTestCases
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3359 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 00:37:54 +00:00
Tom Copeland
1c25dd374a Fixed UnnecessaryConstructor
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3358 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-09 23:33:45 +00:00
Tom Copeland
8502055ebb Fixed UnnecessaryFinalModifier
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3357 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-09 22:50:28 +00:00
Tom Copeland
bdf72f19a0 Fixed UnnecessaryTemporaries
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3356 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-09 22:37:50 +00:00
Tom Copeland
e9ccb76a8f Fixed UnusedImports
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3355 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-09 22:32:13 +00:00
Tom Copeland
1629d81cfe Fixed UnusedModifier
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3354 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-09 15:59:18 +00:00
Tom Copeland
d3ebbadea3 Fixed UnusedPrivateMethod
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3353 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-09 15:07:26 +00:00
Tom Copeland
a6ddfba16e Fixed VariableNamingConventions. I probably changed the behavior with respect to local variables (since I deleted that callback), but no tests are defined for that case, so, until someone has some test cases that define what this rule is supposed to do with locals, word.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3352 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-09 15:00:53 +00:00
Tom Copeland
7c958f3fcf Fixed CloneThrowsCloneNotSupportedException
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3351 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-09 14:27:04 +00:00
Tom Copeland
ef0f52dd26 Fixed CloneMethodMustImplementCloneable
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3350 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-09 14:24:39 +00:00
Tom Copeland
e1f4d90b2a Fixed ProperCloneImplementation
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3349 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-09 14:21:07 +00:00
Tom Copeland
af693f7d0a Fixed AvoidProtectedFieldInFinalClass
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3348 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-09 14:16:53 +00:00
Tom Copeland
2ce8964724 Fixed EmptyStatementNotInLoop
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3347 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-09 14:15:08 +00:00
Tom Copeland
e4ae774db6 Fixed LooseCoupling
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3346 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-09 14:11:36 +00:00
Tom Copeland
5e99dff1b8 Fixed TooManyFields
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3345 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-09 14:06:43 +00:00
Tom Copeland
69912a415d Fixed UseSingleton
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3344 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-09 00:34:23 +00:00
Tom Copeland
865f9f90cc Fixed MissingSerialVersionUID
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3343 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-09 00:19:50 +00:00
Tom Copeland
1639f8323c Import scrub, migrated test to new grammar
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3342 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-08 22:04:13 +00:00
Tom Copeland
487425bcff Fixed LoggerIsNotStaticFinal
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3341 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-08 21:58:08 +00:00
Tom Copeland
faf4f8c5cb Fixed MoreThanOneLogger
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3340 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-08 21:55:50 +00:00
Tom Copeland
20d333bdad Fixed AvoidCatchingNPE
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3339 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-08 21:48:57 +00:00
Tom Copeland
6e0f03a8f3 Fixed AvoidCatchingThrowable
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3338 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-08 21:45:04 +00:00
Tom Copeland
a29d62049b Fixed AvoidThrowingCertainExceptionTypes
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3337 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-08 21:41:38 +00:00
Tom Copeland
edf79e523d Fixed ExceptionAsFlowControl to work with new grammar
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3336 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-08 21:34:33 +00:00
Tom Copeland
858908a769 AvoidConcatenatingNonLiteralsInStringBuffer works with the new grammar now
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3335 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-08 21:24:48 +00:00
Tom Copeland
d35c89a5b8 StringInstantiation works with the new grammar now
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3334 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-08 21:19:23 +00:00
Tom Copeland
bdaacb65c3 StringToString works with the new grammar now
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3333 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-08 21:12:31 +00:00
Tom Copeland
1d8de6b34e Fixed bug 797742 - PMD now parses JDK 1.5 source code. Note that it's not perfect yet; it fails on some generics/annotations/enums. More testing and bug reports are welcome!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3332 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-08 20:23:28 +00:00
Miguel Griffa
9cc57fd3ea IPositionProvider refactor
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3331 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-08 17:08:46 +00:00
Miguel Griffa
8cc02c8e05 interface for refactor of position providers
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3330 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-08 16:47:55 +00:00
Miguel Griffa
d4d473a5e2 report violation in node instead of line number
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3329 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-08 15:51:24 +00:00
Miguel Griffa
f0134af904 report violation in node instead of line number
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3328 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-08 15:30:51 +00:00
Miguel Griffa
6f70ad2941 report violation in node instead of line number
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3327 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-08 15:23:15 +00:00
Miguel Griffa
fe333683ad added methods with Node param for rule violations where the methods had lineNumber
@depreacted was added pointin to the new method,
it is still to be defined if the future of decpreacted (eg: find valid uses or erase them)
I tagged them as deprecated to easily find usage and see if Node can be used


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3326 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-08 15:17:48 +00:00
Miguel Griffa
9ad918bfac adding support to set column information
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3325 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-08 14:56:19 +00:00