hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity
15,790 Commits 16 Branches 123 Tags
Commit Graph

1655 Commits

Author SHA1 Message Date
Clément Fournier
9f3a3dfb85 Merge branch 'master' into 7.0.x 2019-11-19 03:36:57 +01:00
Andreas Dangel
6bf6e2240c [doc] Update release notes, refs #2106, fixes #2105 2019-11-15 08:51:43 +01:00
Andreas Dangel
544ad701ba Merge remote-tracking branch 'origin/master' into pmd/7.0.x 2019-11-08 14:35:20 +01:00
Andreas Dangel
769408f25e [doc] Update release notes, closes #2091 2019-11-08 14:15:27 +01:00
Andreas Dangel
a93b6819b3 [doc] Update release notes, fixes #1861, refs #2088 2019-11-08 10:47:20 +01:00
Andreas Dangel
4c9816fc2e [doc] Update documentation about language versions 2019-11-08 10:40:33 +01:00
Andreas Dangel
ee7f6d0494 [core] RuleSetFactory - recognize rule reference for same ruleset 
There are two variants, how a renamed rule can be expressed in the
ruleset via a deprecated rule reference: referencing just the
new rule name or referencing the ruleset+new rule name. The latter
case was not covered yet, it was not detected, that the rule ref
references are rule in the same ruleset.

Fixes #2096
 2019-11-04 20:43:38 +01:00
Andreas Dangel
c75e2bd000 [apex] Really fix ApexLexer logging 
The fix introduced with #503 (fba00843bb523cbeb06157c4793ffc29bd9a6ee7)
was incomplete and didn't work:
* The logger uses the full class name insteand of simple name
* After we changed the log level of the logger, the logger
  could be garbage collected before ApexLexer retrieves it and
  thus the configuration could be lost
 2019-11-02 09:47:16 +01:00
Andreas Dangel
702b4c1e4c Merge branch 'pr-2089' 
[core] Minor unrelated improvements to code
 2019-11-01 09:05:54 +01:00
Andreas Dangel
6c4ff288d3 [doc] Update release notes, refs #2089 2019-11-01 09:05:08 +01:00
Andreas Dangel
31fdb59be0 Merge remote-tracking branch 'origin/master' into pmd/7.0.x 2019-10-31 20:59:13 +01:00
Andreas Dangel
8e745acf37 Prepare next development version 2019-10-31 19:24:21 +01:00
Andreas Dangel
433f8c06a2 Prepare pmd release 6.19.0 2019-10-31 18:27:57 +01:00
Andreas Dangel
73e48edaaa Merge branch 'pr-2054' 
[java] Rename rule InvalidSlf4jLoggingFormat to InvalidLogMessageFormat
 2019-10-30 19:30:44 +01:00
Andreas Dangel
39e07f6fbc Merge branch 'pr-2084' 
[core] Deprecate Parser#getSuppressMap
 2019-10-30 19:25:59 +01:00
Andreas Dangel
79fa9d2137 Merge branch 'pr-2083' 
[core] Enable type resolution by default for XPath rules
 2019-10-29 19:42:58 +01:00
Andreas Dangel
6e92282e24 Merge branch 'pr-2086' 
[core] Improve logging of deprecated/renamed rules and non-existing excluded rules
 2019-10-29 19:40:17 +01:00
Clément Fournier
34455b3051 Merge branch 'pr-2066' 2019-10-29 16:38:42 +01:00
Andreas Dangel
fc8f9b1c6e [doc] Clarify note about deprecated rules when referencing a complete ruleset 2019-10-28 21:46:39 +01:00
Andreas Dangel
f9d7b0891b Merge branch 'pr-2027' 
[doc,ci] Rework doc generation and release notes
 2019-10-28 19:39:39 +01:00
Andreas Dangel
0a94dec8f0 Merge branch 'pr-2044' 
[core] Wrong deprecation warnings for unused XPath attributes
 2019-10-28 19:27:52 +01:00
Andreas Dangel
2d4b01dca2 Upgrade embedded pmd-designer to 6.19.0 
Also fix integration test with the additional
language "text".
 2019-10-27 19:02:03 +01:00
Andreas Dangel
7e19b97e15 [doc] Update release notes, fixes #1978, fixes #2082 2019-10-27 11:40:37 +01:00
Andreas Dangel
b1adf5c97c [doc] Add note for referencing a complete category or ruleset 2019-10-27 11:28:13 +01:00
Andreas Dangel
d61d53092e [core] Deprecate Parser#getSuppressMap 
Refs #2055
 2019-10-26 17:27:11 +02:00
Andreas Dangel
92b8af8477 [core] Enable type resolution by default for XPath rules 
Fixes #2048

All XPath rules will have now type resolution enabled by default.
While this change is in core, it actually only affects Java, since
this is the only language which has a type resolution facade
registered in its language handler.
 2019-10-26 16:58:07 +02:00
Andreas Dangel
752e5f8ad5 [java] Deprecate AbstractJavaRule#getDeclaringType(Node) 
Refs #2034
 2019-10-26 12:17:43 +02:00
Andreas Dangel
37aaa675db Remove the generated rule documentation from repository 2019-10-26 11:51:32 +02:00
Juan Martín Sotuyo Dodero
d6f0192857 Merge branch 'master' into travis-windows 2019-10-25 17:05:45 -03:00
Andreas Dangel
c7f143534a [doc] Update generated rule doc 2019-10-25 18:42:50 +02:00
Andreas Dangel
c1f36d9d70 [java] Rename InvalidSlf4jMessageFormat to InvalidLogMessageFormat 
Follow-up on #2012
 2019-10-25 18:42:50 +02:00
Andreas Dangel
5c2bff403d Merge branch 'pr-2068' 2019-10-25 18:20:06 +02:00
Andreas Dangel
c2b484bbc0 [doc] Update release notes, refs #2068 2019-10-25 18:18:16 +02:00
Andreas Dangel
63395684c4 Merge branch 'pr-2076' 2019-10-25 15:01:58 +02:00
Andreas Dangel
e8a4b5f77e [doc] Update release notes, refs #2076 2019-10-25 15:01:04 +02:00
Andreas Dangel
ecc4e7558f [java] Use full name for CLASS_FAN_OUT metric for operations as well 2019-10-25 14:44:45 +02:00
Andreas Dangel
2b66fb76cb Merge branch 'master' into travis-windows 2019-10-25 14:27:17 +02:00
Juan Martín Sotuyo Dodero
9a2314ab5d Merge pull request #2079 from adangel/issue-1531-unusedprivatemethod 
[java] UnusedPrivateMethod false-positive with method result
 2019-10-23 19:46:48 -03:00
Andreas Dangel
abc048ce41 [doc] Update generated rule documentation 2019-10-21 20:41:10 +02:00
Andreas Dangel
c7786d9438 [doc] Update release notes, fixes #1627, refs #2078 2019-10-21 20:32:03 +02:00
Andreas Dangel
50f748e191 [java] UnusedPrivateMethod false-positive with method result 
Fixes #1531

In case we determined, that the method argument is a method call,
then we skip now completly trying to determine the correct argument
type. It was half-way fixed before for the first if condition, but
we still evaluated e.g. the allocation expression in

    print(new Integer(1).toString());

and wrongly assumed, the argument type would be an integer,
without taking into account the `toString()` method call.

The same happened with

    privateBooleanMethod(s, "true".equals(s));

where we took the 2nd argument as a literal and assumed
it is a "String", while the method call result actually
is a boolean.

With this change now, the false positive is fixed.

However, since we don't determine the argument type at all, the
method is matched solely on argument count. This will obviously
lead to wrong matches if method overloading is used.
 2019-10-20 15:54:10 +02:00
andi
7e48b4dcd3 fix documentation 2019-10-19 22:05:29 +02:00
Andreas Dangel
dde5d096d2 [doc] Update release notes, fixes #2071 2019-10-18 19:51:35 +02:00
Andreas Dangel
a1781422ca Merge branch 'pr-2073' 2019-10-17 21:05:43 +02:00
Andreas Dangel
dde5cb530a [doc] Update release notes, refs #2073, fixes #2072 2019-10-17 21:05:14 +02:00
Andreas Dangel
b76feef44e Merge branch 'pr-2070' 2019-10-17 20:34:00 +02:00
Andreas Dangel
a91803f157 [doc] Update release notes, refs #2070, fixes #2067 2019-10-17 20:32:59 +02:00
andi
1515209a48 add classfanoutcomplexity metric 2019-10-17 13:05:36 +02:00
Clément Fournier
1bfcd91cba Merge branch 'master' into 7.0.x 2019-10-16 17:29:34 +02:00
Andreas Dangel
e4e4c7ceae Merge branch 'pr-2060' 2019-10-14 19:36:45 +02:00