hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity
5,847 Commits 16 Branches 123 Tags
Commit Graph

5847 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Xavier Le Vourch
20b584bede code cleanup: import clauses 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6326 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-07-12 04:06:55 +00:00
Xavier Le Vourch
97ff0b6a84 snapshot script updates 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6325 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-07-11 20:22:21 +00:00
Xavier Le Vourch
2e14272b6c deprecation warnings are used for CI trend analysis 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6324 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-07-10 19:26:00 +00:00
Xavier Le Vourch
76056be0d1 code cleanup: depecated methods 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6323 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-07-03 17:48:24 +00:00
Xavier Le Vourch
4d9bd31228 clover report setup changes to accomodate hudson plugin 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6322 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-07-02 05:13:14 +00:00
Ryan Gustafson
16aa7132d7 Dogfood now contains LooseCoupling. 
Refactored usages of LinkedList to use ArrayList, primarily in the DFA area, but a few other places too.  AFAICT, a LinkedList wasn't strictly needed here (not insert/delete performance needs), and if used would likely be a tad bit slower due to the extra object creations which goes on behind the scenes for each item in the List compared to an ArrayList.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6321 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-07-02 04:18:58 +00:00
Tom Copeland
47db48d5e8 Meh, that space can be put to better use 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6320 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-07-02 04:16:32 +00:00
Xavier Le Vourch
13ada27140 clover target added 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6319 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-07-02 03:55:17 +00:00
Ryan Gustafson
85ff8d4d13 Dogfood now contains CompareObjectsWithEquals. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6318 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-07-02 02:37:46 +00:00
Ryan Gustafson
e2f9e373b6 Dogfood now contains SimplifyBooleanReturns. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6317 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-07-02 02:30:46 +00:00
Ryan Gustafson
fe2671e95d Dogfood now contains UseCollectionIsEmpty. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6316 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-07-02 02:18:49 +00:00
Ryan Gustafson
1459c8789c Dogfood now contains ClassWithOnlyPrivateConstructorsShouldBeFinal. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6315 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-07-02 02:15:36 +00:00
Ryan Gustafson
6b4aea9271 Dogfood now contains ClassWithOnlyPrivateConstructorsShouldBeFinal. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6314 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-07-02 02:10:12 +00:00
Ryan Gustafson
159e2443c3 Dogfood now contains SimplifyConditional. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6313 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-07-02 02:04:54 +00:00
Tom Copeland
3a470f06c5 Looks like the Ant task doesn't take 'debug' anymore 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6309 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-07-01 13:49:53 +00:00
Xavier Le Vourch
1fdd1e39f4 full file names needed for hudson pmd plugin 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6308 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-06-30 18:45:24 +00:00
Xavier Le Vourch
71cb7bbd08 new target "reports" 
it generates reports for checkstyle and pmd (using dogfood-goal.xml) in build/reports

also, reorganization of reports for junit tests in subdirectories of build/reports


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6307 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-06-30 17:59:14 +00:00
Ryan Gustafson
fa0d2e4a6b Dogfood now contains SuspiciousConstantFieldName. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6306 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-06-30 06:35:00 +00:00
Ryan Gustafson
e0a5913f8c Dogfood now contains VariableNamingConventions. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6305 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-06-30 06:28:58 +00:00
Ryan Gustafson
8ede80d646 Fix false positive in VariableNamingConventions on contents of inner classes in declarations. I had introduced this problem with recent improvements to the Rule. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6304 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-06-30 05:11:52 +00:00
Ryan Gustafson
8913660672 Widen return type from Node.findChildNodesWithXPath() to List<? extends Node> from List<Node> allow casting results to a List of subclasses of Node (e.g. List<ASTVariableDeclarator>). 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6303 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-06-30 05:05:51 +00:00
Ryan Gustafson
b35f990933 Widen return type from Node.findChildNodesWithXPath() to List<? extends Node> from List<Node> allow casting results to a List of subclasses of Node (e.g. List<ASTVariableDeclarator>). 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6302 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-06-30 05:04:17 +00:00
Ryan Gustafson
9308da2f4b Improve messages produced by VariableNamingConventions rules. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6301 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-06-30 04:40:41 +00:00
Ryan Gustafson
c82718df38 Dogfood goal. Delete this once we reach it. Xavier expressed interest in this for some reporting experiments. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6300 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-06-30 04:24:16 +00:00
Xavier Le Vourch
f8d1b52a2b new rule UseVarags added 
deprecated messages for basic ruleset rules

rules are sorted by ruleset


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6299 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-06-30 04:22:35 +00:00
Ryan Gustafson
b802756b80 Missed a file for recent VariableNamingConventions change. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6298 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-06-30 04:04:10 +00:00
Ryan Gustafson
f40a793de8 Added UseVarargs rule to the Java language Design ruleset, minimum language version of 1.5. 
Excluded from dogfood for now.

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6297 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-06-30 04:03:11 +00:00
Xavier Le Vourch
757c27e147 testTSM() disabled in regress mode: 
because of random failures during continuous integration,
tests are disabled in regress mode until somebody figures out
what the tests are supposed to measure and why they sometime fail


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6296 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-06-30 02:32:35 +00:00
Ryan Gustafson
492f926420 Fix false negative for non-primitive types for VariableNamingConventions, also expanded scope to local and method/constructors, and enhanced customization options to choose between members/locals/parameters (all checked by default). 
Yes, this Rule now reports on things it didn't report on before because of (1) a false negative fix, and (2) expansion of scope to cover locals and parameters.  I believe locals were always intended to be checked, but the implementation was non-functioning.



git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6295 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-06-30 01:53:11 +00:00
Xavier Le Vourch
876e85ffe3 -benchmark option displays rule average time for regular and chained rules 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6294 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-06-28 02:37:13 +00:00
Ryan Gustafson
af6869cb61 Dogfood now contains SuspiciousEqualsMethodName. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6293 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-06-28 01:18:44 +00:00
Ryan Gustafson
9133c30edf Dogfood now contains UseIndexOfChar. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6292 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-06-28 01:12:35 +00:00
Ryan Gustafson
24026cf487 Dogfood now contains SimplifyStartsWith. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6291 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-06-27 14:57:54 +00:00
Ryan Gustafson
924adc1c39 Dogfood now contains AddEmptyString. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6290 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-06-27 14:52:53 +00:00
Ryan Gustafson
d371a70e99 Dogfood now contains InsufficientStringBufferDeclaration. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6289 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-06-27 14:47:08 +00:00
Ryan Gustafson
5ff1e71e6c Fix false positive where StringBuffer.setLength(0) was using default constructor size of 16, instead of actual constructor size. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6288 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-06-27 08:12:23 +00:00
Ryan Gustafson
ffe0789340 Dogfood now contains AvoidStringBufferField. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6287 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-06-25 18:17:57 +00:00
Ryan Gustafson
922e656a17 Remove unused MyPrintStream class. 
Idea for a Rule: Don't use "My" (or any String from a comma separated list) as a prefix for class names.  Optional property 'topLevelOnly' to limit the Rule to top level classes only, I'm cool with it for inner classes.

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6286 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-06-25 18:15:58 +00:00
Ryan Gustafson
18aa199556 Dogfood now contains UnusedPrivateMethod. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6285 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-06-25 18:09:06 +00:00
Xavier Le Vourch
d534b35c31 snapshot can be uploaded to pmd.sourceforge.net/snapshot using 'tools/shell/generate_snapshot.sh <version>' 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6284 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-06-25 05:48:07 +00:00
Ryan Gustafson
e32813ae6b Dogfood now contains UnusedModifier. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6283 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-06-25 03:59:23 +00:00
Ryan Gustafson
51a769456d Dogfood now contains UselessParentheses. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6282 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-06-25 03:54:30 +00:00
Ryan Gustafson
ab11ffe82a Fix false positive on CastExpressions for UselessParentheses. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6281 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-06-25 03:52:26 +00:00
Ryan Gustafson
b664dc2846 Correct NPE by restoring code which initializes the method/constructor Lists. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6280 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-06-25 02:50:57 +00:00
Ryan Gustafson
2aaa9cd05c Dogfood now contains UnnecessaryReturn. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6279 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-06-25 02:31:02 +00:00
Ryan Gustafson
64bf201ca6 Dogfood now contains UnnecessaryFinalModifier. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6278 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-06-25 02:22:34 +00:00
Ryan Gustafson
8b068981d5 Dogfood now contains UseArrayListInsteadOfVector. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6277 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-06-25 02:20:18 +00:00
Ryan Gustafson
2b5111124c Dogfood now contains LoggerIsNotStaticFinal. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6276 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-06-25 01:42:03 +00:00
Ryan Gustafson
5cf71863ee Dogfood now contains SwitchStmtsShouldHaveDefault. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6275 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-06-25 01:21:49 +00:00
Ryan Gustafson
0839364579 Dogfood now contains MissingBreakInSwitch. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6274 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-06-25 01:06:59 +00:00