740 Commits

Author SHA1 Message Date
Andreas Dangel
42da2b89f2 [doc] Use category instead of rulesets 2017-11-13 21:29:24 +01:00
Andreas Dangel
58b996a634 [core] Add all rules of a ruleset, if the ruleset itself is deprecated
that is: The ruleset only contains deprecated rules.
2017-11-11 14:06:50 +01:00
Clément Fournier
bf3ce9d37a Allow null value for numeric properties 2017-11-11 12:20:43 +01:00
Andreas Dangel
0e389af616 [core] Add old RuleSetFactory constructor back for API backwards compatibility 2017-11-11 12:07:13 +01:00
Andreas Dangel
ba3e2bc788 [core] RuleSetFactory: Filter by minimumPriority at the end
-   Resolves #394
2017-11-11 12:03:45 +01:00
Andreas Dangel
06a1244e15 [doc] Add unit test for all rulesets and fix existing rulesets 2017-11-10 14:03:05 +01:00
Clément Fournier
c1ccc26de8 Fix #725: numeric property descriptors now check their default value 2017-11-09 21:25:41 +01:00
Andreas Dangel
d0f0c467a0 Merge branch 'pr-717' 2017-11-08 20:54:12 +01:00
Clément Fournier
33b22cb7de Remove ruledef dir 2017-11-08 19:08:45 +01:00
Clément Fournier
d3f72c27bd Adapt to changes on master 2017-11-08 19:08:01 +01:00
Clément Fournier
3dfdef1467 Correct override behaviour 2017-11-08 18:57:10 +01:00
Clément Fournier
b7caf2ff76 Remove rule factory singleton 2017-11-08 18:57:10 +01:00
Clément Fournier
f98ac47045 Inline ruleset schema constants 2017-11-08 18:57:10 +01:00
Clément Fournier
b5761ec2a1 Fix documentation 2017-11-08 18:57:10 +01:00
Clément Fournier
e3bc90c1eb Use enum constants to identify nodes 2017-11-08 18:57:10 +01:00
Clément Fournier
86b0bb4cd7 Rule references use rule factory. Properties declared in a rule ref throw an exception while parsing 2017-11-08 18:57:10 +01:00
Clément Fournier
845e7ca7a8 Plug into RuleSetFactory 2017-11-08 18:56:09 +01:00
Clément Fournier
d933deed6b Fix merge conflicts 2017-11-08 18:52:53 +01:00
Clément Fournier
8a048fd18d Rule factory and builder 2017-11-08 18:52:53 +01:00
Andreas Dangel
6bba28acbe Add categories.properties files 2017-11-07 22:23:17 +01:00
Clément Fournier
7d85448659 Merge branch 'master' into fx-designer 2017-11-07 19:34:02 +01:00
Juan Martín Sotuyo Dodero
f9f96b84fe [java] merge UnnecessaryFinalModifier into UnnecessaryModifier
- I take the chance to also flag final resources in try-with-resources
 - This resolves #411
 - This resolves #676
 - The rule is now using the rulechain
2017-11-07 00:34:00 -03:00
Juan Martín Sotuyo Dodero
25da0c86f2 Merge branch 'pr-697' 2017-11-06 13:41:27 -03:00
Clément Fournier
9f10c9ca5c Fix core and pom bug 2017-11-05 23:14:31 +01:00
Juan Martín Sotuyo Dodero
9e1342f30a Merge branch 'pr-696' 2017-11-04 19:48:28 -03:00
Juan Martín Sotuyo Dodero
8d381daeb3 Merge branch 'pr-669' 2017-11-04 19:40:14 -03:00
Juan Martín Sotuyo Dodero
5d6a03612e Rename builder method 2017-11-04 19:19:39 -03:00
Juan Martín Sotuyo Dodero
e7e5e13a7d Merge branch 'pr-703' 2017-11-04 18:18:13 -03:00
Andreas Dangel
e064efbad3 [apex] Move AvoidHardCodingId Rule to errorprone 2017-11-04 20:16:04 +01:00
Andreas Dangel
d0b3845ba0 Consider renamed rule MisleadingVariableName in RuleSetFactoryCompatibility 2017-11-04 19:57:31 +01:00
Andreas Dangel
e1a588f499 Merge branch 'master' into ruleset-categories 2017-11-04 19:53:21 +01:00
Andreas Dangel
04c8d0a6c9 Merge branch 'pr-687' 2017-11-04 19:40:56 +01:00
Andreas Dangel
e9425e34d8 [apex] Reorganize rules into categories 2017-11-03 14:05:40 +01:00
Andreas Dangel
c9952e613c [core] fix references to new rules for v6.0.0 2017-11-03 12:04:45 +01:00
Clément Fournier
fc0cb45f49 Merge branch 'master' into properties-builder 2017-11-01 18:21:54 +01:00
Clément Fournier
6b50104cb5 Corrections for PR #669 2017-11-01 18:17:57 +01:00
Clément Fournier
63a35c2967 Merge branch 'master' of https://github.com/pmd/pmd into fx-designer 2017-11-01 15:29:32 +01:00
Juan Martín Sotuyo Dodero
c466179c2a Handle SecurityErrors on bad auxclasspath entries 2017-10-31 01:53:03 -03:00
Matias Comercio
9348c54afb Fix PR - 1
- Remove unnecessary asserts for checking setup
- Improve `for` loop performance in AbstractNode.removeChildAtIndex method
- Remove unnecessary detachment of the node being removed children
2017-10-30 15:39:16 -03:00
Andreas Dangel
42973c4291 [java] Reorganize rulesets into new categories
Best Practices, Code Style, Design, Documentation, Error Prone,
Multithreading, Performance, Security
2017-10-29 21:11:59 +01:00
Matias Comercio
2466ba7163 Add remove & removeChildAtIndex to Node interface
- Implement these methods at AbstractNode.
- Add AbstractNodeTest class with test cases for the implemented methods.
  - Add JUnitParams dependency: https://github.com/Pragmatists/JUnitParams
  - Implement these test cases using JUnitParams features
2017-10-29 13:18:06 -03:00
gonzalo
91b8a22b42 Update GenericToken specialToken method to obtain only comment tokens 2017-10-28 14:42:44 -03:00
gonzalo
e8fdbdbca4 Update GenericToken interface to expose directly region methods 2017-10-28 14:42:44 -03:00
gonzalo
26461e59c1 Simplify method name in GenericToken && improve ant task replacetoken 2017-10-28 14:42:44 -03:00
gonzalo
95835b8134 Update getter in GenericToken 2017-10-28 14:42:44 -03:00
gonzalo
00ed0a1eab Add RegionByLineImpl javadoc 2017-10-28 14:42:44 -03:00
gonzalo
2d01332635 Convert GenericToken from class to interface && Add RegionByLine 2017-10-28 14:42:44 -03:00
Juan Martín Sotuyo Dodero
1308b2c7fa [core] Changes to execution classpath invalidate cache
- Resolves #603
2017-10-25 18:03:13 -03:00
Juan Martín Sotuyo Dodero
20093c809a Rework ruleset loading
- ResourceLoader is now instantiable, and we can tell which classloader
to use to get resources
 - We will always use the execution classloader, or just add the paths
added by ant, but *never* the auxclasspath
 - The classpath added by Ant won't get into the auxclasspath either
2017-10-24 18:07:09 -03:00
Juan Martín Sotuyo Dodero
42d965844f Avoid duplicate code 2017-10-23 17:46:21 -03:00