Commit Graph

1969 Commits

Author SHA1 Message Date
Juan Martín Sotuyo Dodero
b8accbb01a Merge branch 'master' into issue-1325 2018-09-08 22:11:35 -03:00
Juan Martín Sotuyo Dodero
d14c7a9636 Use typeres to detect proper AtomicBooleans 2018-09-08 22:04:11 -03:00
Andreas Dangel
06be510702 [java] ConsecutiveLiteralAppends: Fix further FPs/FNs 2018-09-07 16:31:58 +02:00
Andreas Dangel
212bf46be8 [java] LinguisticNaming should support AtomicBooleans
Fixes #1334
2018-09-07 15:21:01 +02:00
Andreas Dangel
7d3f287f38 [java] False positive in ConsecutiveLiteralAppends
Fixes #1325
2018-09-07 14:30:16 +02:00
Clément Fournier
492f1798d8 Fix tests 2018-09-04 11:44:16 +02:00
Clément Fournier
16f0633193 Fix #1329 2018-09-04 11:34:34 +02:00
Andreas Dangel
291d36d841 [maven-release-plugin] prepare for next development iteration 2018-09-02 14:27:42 +02:00
Andreas Dangel
b98bd0bb96 [maven-release-plugin] prepare release pmd_releases/6.7.0 2018-09-02 14:27:33 +02:00
Juan Martín Sotuyo Dodero
dc19269491 Merge branch 'master' into issue-1323 2018-09-01 20:16:13 -03:00
Andreas Dangel
7ebcb30aaa No need to check for missing ':' 2018-09-01 21:41:05 +02:00
Andreas Dangel
d0efb3cad7 Merge branch 'pr-1319' 2018-09-01 21:32:08 +02:00
Andreas Dangel
58b1985509 Merge branch 'pr-1324' 2018-09-01 21:32:03 +02:00
Andreas Dangel
2fb3cd13cb [java] AvoidUsingHardCodedIP false positive for ":bee"
"::bee" (two colons) is a valid IPv6 address, while ":bee"
is not.

Refs #1323
2018-09-01 21:12:29 +02:00
Juan Martín Sotuyo Dodero
ded5c1ca51 Add 'as' a a valid transformation prefix 2018-09-01 16:07:13 -03:00
Andreas Dangel
a30d23e587 [java] LinguisticNaming - make tranform method names configurable
Follow-up for #1252
2018-08-31 11:29:55 +02:00
Juan Martín Sotuyo Dodero
6ef3b5a583 [java] Remove no longer used property
- Fixes #1323
2018-08-30 13:54:59 -03:00
Juan Martín Sotuyo Dodero
df64d8bfce Merge branch 'master' into deprecate-old-naming-conventions-rules 2018-08-27 12:58:18 -03:00
Juan Martín Sotuyo Dodero
982effe744 Merge branch 'pr-1297' 2018-08-27 04:20:34 -03:00
Juan Martín Sotuyo Dodero
26f5a41c47 [java] OneDeclarationPerLine should check fields too 2018-08-27 04:12:39 -03:00
Clément Fournier
40ce9313ae Deprecate R[UN]SIGNEDSHIFT
No usages to report
2018-08-20 18:08:21 +02:00
Andreas Dangel
71ce6c2eae [java] use pmd-java:typeIs always with the prefix "pmd-java".
Jaxen ignores the prefix, Saxon will require it.
So, it's more consistent to use the prefix always.
2018-08-17 20:27:09 +02:00
Andreas Dangel
27ac0944b5 [java] Use typeresolution for various (J)Unit rules 2018-08-17 20:20:10 +02:00
Andreas Dangel
b9b19ec3ab Merge branch 'pr-1256' 2018-08-17 19:12:53 +02:00
Clément Fournier
e17a965e03 Merge branch 'master' into deprecate-old-naming-conventions-rules 2018-08-17 16:29:51 +02:00
Clément Fournier
101a2c4100 Merge branch 'master' into split-field-naming-conventions 2018-08-17 15:55:42 +02:00
Clément Fournier
5526cae376 Fix pr comments 2018-08-17 15:54:03 +02:00
Clément Fournier
944c1222d2 Separate treatment of public and non-public constants 2018-08-15 18:35:42 +02:00
Andreas Dangel
89f6ae5806 [java] InvalidSlf4jMessageFormat: Avoid using findDescendantsOfType
to limit the scope of searched nodes
2018-08-14 10:58:41 +02:00
Andreas Dangel
74ed544500 [java] InvalidSlf4jMessageFormat false positive: too many arguments with string concatenation operator
Fixes #1291

If there are multiple Literals for the first parameter, we assume,
they are concatenated together and sum up all placeholders.
Such String literals are concatenated already by the java compiler,
so splitting a String in that way has no negative impact.

This change also makes use of the RuleChain.
2018-08-14 10:58:41 +02:00
Juan Martín Sotuyo Dodero
62612dc507 Merge branch 'pr-1299' 2018-08-13 12:06:46 -03:00
Andreas Dangel
f773581459 [core] PMD stops processing file completely, if one rule in a rule chain fails
Fixes #1300
2018-08-13 11:21:04 +02:00
Andreas Dangel
f8bb0488d8 [java] RedundantFieldInitializer - NumberFormatException with Long
Fixes #1298
2018-08-13 09:55:02 +02:00
Clément Fournier
19b9c841dc Checkstyle 2018-08-13 09:09:26 +02:00
Clément Fournier
c9cb88e55c Deprecate old rules 2018-08-13 05:55:30 +02:00
Clément Fournier
7bc0305835 Add tests 2018-08-13 01:09:48 +02:00
Clément Fournier
e4566ea17a Add FieldNamingConventionsRule, document ast 2018-08-13 00:46:31 +02:00
Clément Fournier
44e23e7d2e Make classloaders final in JTypeQName 2018-08-12 23:16:31 +02:00
Clément Fournier
0ae88f7cd0 Merge branch 'pr-1252' 2018-08-12 19:27:20 +02:00
Clément Fournier
c3ea6de8e0 Move LinguisticNaming to 6.7.0 2018-08-12 19:25:13 +02:00
Andreas Dangel
802104525a LinguisticNaming: add additional property to avoid too many FPs
by default for transform methods
2018-08-07 19:32:38 +02:00
Andreas Dangel
89f027a64f LinguisticNaming: fix Boolean false-positive 2018-08-07 19:21:56 +02:00
Danny van Heumen
4c0b18068f [java] UselessParentheses: Fix false positive for assignment within parentheses in condition statement. 2018-08-06 23:15:12 +02:00
Andreas Dangel
7bdb10bccd Merge branch 'master' into linguistic-antipatterns 2018-08-06 21:08:45 +02:00
Andreas Dangel
62254aa6c2 Fix review comments for LinguisticNamingRule
* Added specific messages for the different types of linguistic patterns detected
* Fix support for multiple field/variable declaration
2018-08-06 20:54:16 +02:00
Alex Shesterov
f2cb480595 Add tests UseAssertEqualsInsteadOfAssertTrue,UseAssertNullInsteadOfAssertTrue,UseAssertSameInsteadOfAssertTrue,UnnecessaryBooleanAssertion (https://github.com/pmd/pmd/issues/940) 2018-08-06 11:38:21 +00:00
Alex Shesterov
fadbbbba02 Add tests UseAssertEqualsInsteadOfAssertTrue,UseAssertNullInsteadOfAssertTrue,UseAssertSameInsteadOfAssertTrue,UnnecessaryBooleanAssertion (https://github.com/pmd/pmd/issues/940) 2018-08-06 09:25:49 +00:00
Alex Shesterov
2dbb332f00 Add tests and enhance description for JUnit4TestShouldUseTestAnnotation (https://github.com/pmd/pmd/issues/940) 2018-08-06 09:05:03 +00:00
Alex Shesterov
2ead1237d6 Add tests and enhance descriptions for JUnit4TestShouldUseBeforeAnnotation,JUnit4TestShouldUseAfterAnnotation (https://github.com/pmd/pmd/issues/940) 2018-08-06 08:35:48 +00:00
Andreas Dangel
1306a2b859 Merge branch 'pr-1267' 2018-08-06 09:09:45 +02:00