4094 Commits

Author SHA1 Message Date
Tom Copeland
c1c4f2e9d2 Added support for JDK 1.5
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4077 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-19 13:59:16 +00:00
Radim Kubacki
f65b70ca27 updating to PMD-3.4
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4075 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-17 01:29:00 +00:00
Radim Kubacki
5ff072aaba updated to PMD3.4, fixed creating of RuleViolation in AbstractRules
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4074 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-16 17:24:22 +00:00
Tom Copeland
e1dc4a114e import cleanup
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4073 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-15 22:42:14 +00:00
Tom Copeland
774f68e93f Faster, more readable, more concise StringToString
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4072 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-15 19:48:20 +00:00
Tom Copeland
7475320929 Fixed bug 1380969 - UnusedPrivateMethod no longer flags private static methods that are only invoked in a static context from a field declaration.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4071 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-15 15:51:59 +00:00
Tom Copeland
433bd30a14 Shifting more code into the framework
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4070 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-15 15:27:41 +00:00
Tom Copeland
2221283340 more links
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4069 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-15 15:13:20 +00:00
Tom Copeland
ff0b08035a More links
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4068 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-14 23:22:47 +00:00
Tom Copeland
ec1d41be86 Fabio Insaccanebbia's implementation of UseArraysAsList in the optimizations ruleset, thanks Fabio!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4067 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-14 23:03:56 +00:00
Tom Copeland
526f835bf3 Fabio Insaccanebbia's implementation of UseArraysAsList in the optimizations ruleset, thanks Fabio!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4066 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-14 23:01:48 +00:00
Tom Copeland
1a59f57240 Trying a different font here
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4065 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-14 23:01:37 +00:00
Tom Copeland
c0a4006dec More code in the framework, less code in the rule... good times
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4064 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-14 22:20:47 +00:00
Tom Copeland
fd9b9b6e3e Added Fabio Insaccanebbia's implementation of AvoidConstantsInterface; thx Fabio!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4063 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-14 14:44:58 +00:00
Tom Copeland
f75ad93b2c Added David Corley's Javascript report, more details are here: http://tomcopeland.blogs.com/juniordeveloper/2005/12/demo_of_some_ni.html
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4062 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-14 14:26:33 +00:00
Tom Copeland
f0a48190cf better test case... we should catch some of these...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4061 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-13 23:16:01 +00:00
Tom Copeland
8c465324e5 Fixed bug 1379701 - CompareObjectsWithEquals no longer flags comparisons of array elements. Thanks to George Sexton for the report!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4060 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-13 23:13:34 +00:00
Tom Copeland
e1021e2f39 More links for names
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4059 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-13 23:06:17 +00:00
Tom Copeland
924f5e42f4 Fixed bug 1277373 - InefficientStringBuffering no longer flags concatenations that involve a static final String.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4058 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-13 22:46:33 +00:00
Tom Copeland
c7304c93cc Some comments on a better symbol API
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4057 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-12 22:03:56 +00:00
Tom Copeland
771bca32bc Fixed a FIXME; NullAssignment is a bit faster now. Also moved a utility method up into SimpleNode; I think this is something that either Wouter or Allan had suggested a while back...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4056 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-12 21:56:24 +00:00
Tom Copeland
e673e02398 Fixed bug 1371741 - UncommentedEmptyConstructor no longer flags constructors that consist of a this() or a super() invocation. Thanks to Johan for the patch!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4055 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-12 14:31:10 +00:00
Tom Copeland
70c69f7e68 Fixed bug 1378358 - StringInstantiation no longer throws ClassCastExceptions on certain allocation patterns. Thanks to Bruce Kelly for the report!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4054 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-12 00:54:18 +00:00
Tom Copeland
7e46a5ac34 Fixed a FIXME; more symbol table usage and less aimless looping
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4053 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-10 01:54:01 +00:00
Tom Copeland
2a58a6ee31 Rebuilt JavaCC parser with JavaCC 4.0beta1. As far as I can see, the speed is about the same as JavaCC 3.2.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4052 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-10 01:30:24 +00:00
Tom Copeland
dc569f9c0c Added current CLASSPATH to pmd.bat.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4051 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-09 20:08:27 +00:00
Tom Copeland
d27c7d04c5 Tweaked textrenderer
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4050 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-09 19:20:14 +00:00
Tom Copeland
92bd69e8e1 Fixed bug 1376756 - UselessOverridingMethod no longer throws an exception on overloaded methods.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4049 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-09 16:46:12 +00:00
Tom Copeland
7ab93baff5 Renamed InefficientStringBufferAppend to AppendCharacterWithChar
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4048 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-09 14:22:12 +00:00
Tom Copeland
247f5d06cc Fixed bug 1376760 - InefficientStringBuffering no longer throws a NullPointerException when processing certain expressions.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4047 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-09 01:01:43 +00:00
Tom Copeland
4cdc84d6b1 Allan Caplan's implementation of InefficientStringBufferAppend, thanks Allan!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4046 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-08 22:43:59 +00:00
Tom Copeland
de503c7d68 Modified renderers to support disabling printing of suppressed warnings. Introduced a new AbstractRenderer class that all Renderers can extends to get the current behavior - that is, suppressed violations are printed. Thanks to Wouter Zelle for the suggestion!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4045 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-08 22:19:04 +00:00
Tom Copeland
2edee46592 rls preps
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4043 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-08 14:30:12 +00:00
Tom Copeland
68b29b63dd real name
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4042 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-07 14:43:34 +00:00
Tom Copeland
3c30f87645 Fixed a bug in UseStringBufferLength; it no longers fails with an exception on expressions like StringBuffer.toString.equals(x)
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4041 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-07 14:30:32 +00:00
Tom Copeland
0ffa485b78 Fixed bug 1375290 - @SuppressWarnings annotations are now implemented correctly; they accept one blank argument to suppress all warnings.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4040 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-07 14:13:15 +00:00
Tom Copeland
e36d15c239 Implemented UseAssertNullInsteadOfAssertTrue; thx to Wim Deblauwe for the suggestion!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4039 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-06 15:08:12 +00:00
Tom Copeland
845cf1e773 A bit more on bug 1373510 - UseAssertSameInsteadOfAssertTrue no longer has a typo in its message, and its message is more clear.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4038 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-06 14:51:27 +00:00
Tom Copeland
5888025a5c Fixed bug 1373510 - UseAssertSameInsteadOfAssertTrue no longer has a typo in its message, and its message is more clear.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4037 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-05 22:52:11 +00:00
Tom Copeland
bc65b92d52 UnusedFormalParameter now catches unused constructor parameters, and its warning message now reflects whether it caught a method or a constructor param.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4036 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-05 22:44:19 +00:00
Tom Copeland
1a0bf9097f New article
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4035 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-05 22:19:59 +00:00
Jiger Patel
a1af2b6e78 Updated to PMD 3.4
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4034 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-05 06:58:32 +00:00
Tom Copeland
200bf7d6e8 Added links to latest rls and notes; thx to Elliotte Rusty Harold for the suggestion
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4033 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-03 20:21:42 +00:00
Tom Copeland
72f8fcd08e import cleanup
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4032 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-02 21:43:22 +00:00
Tom Copeland
19c5f9f2dd Updated to PMD 3.4; cleaned up examples in preferences panel; new location for JDev installs
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4031 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-02 21:38:35 +00:00
Tom Copeland
60f5fa71bb Fixed bug 1371980 - InefficientStringBuffering no longer flags StringBuffer methods other than append().
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4030 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-02 21:16:22 +00:00
Tom Copeland
632d50d123 Partially fixed bug 1371753 - UnnecessaryLocalBeforeReturn message now reflects the fact that that rule flags all types
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4029 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-02 15:11:54 +00:00
Tom Copeland
1baf5b609a Fixed bug 1371757 - Misleading example in AvoidSynchronizedAtMethodLevel
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4028 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-02 15:08:21 +00:00
Tom Copeland
2df14d9c69 Fixed bug 1277373 - InefficientStringBuffering now catches more cases.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4027 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-01 22:31:16 +00:00
Tom Copeland
2098512e01 Applied Allan Caplan's IntegerInstantiation new rule patch, thanks Allan!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4026 51baf565-9d33-0410-a72c-fc3788e3496d
2005-12-01 22:11:14 +00:00