4029 Commits

Author SHA1 Message Date
Tom Copeland
29f462f361 Reverted to previous version to get bug fix
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4224 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-11 03:48:19 +00:00
Tom Copeland
f68bd93fd5 Restored bugfix (enum visit)
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4223 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-11 03:45:50 +00:00
Tom Copeland
635841e62b Oops, hadn't checked these tests in
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4222 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-11 03:39:01 +00:00
Tom Copeland
ac80c6705a Checking in latest generated grammar
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4221 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-11 03:35:07 +00:00
Tom Copeland
d3b53a4cbb Reverting to previous version to restore bugfix change
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4220 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-11 03:33:36 +00:00
Tom Copeland
ebd624c17b All tests pass now, w00t!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4219 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-10 14:31:34 +00:00
Tom Copeland
2d69336a92 Huge reformatting checkin
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4218 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-10 14:26:32 +00:00
Tom Copeland
7e810c2409 Latest source from Pieter, everything compiles and all the tests pass with the exception of a few missing rules in basic-jsp.xml
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4217 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-10 14:15:31 +00:00
Tom Copeland
ce48af0bee Compiling again, good times
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4216 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-09 22:09:32 +00:00
Radim Kubacki
45a712ee4a updating version
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4215 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-09 14:06:30 +00:00
Radim Kubacki
9376ba1fb4 Attempt to fix AssertionError when getting input reader - getDocument should not cause init of editor if the file is not opened
http://www.netbeans.org/issues/show_bug.cgi?id=71141


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4214 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-09 14:02:42 +00:00
Tom Copeland
a43d7d89e0 Some more flailing about... there's something simple that's going to make this work, I think...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4213 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-09 03:13:10 +00:00
Tom Copeland
e47b22eef8 Fixed jar Class-Path attr
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4212 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-08 15:06:47 +00:00
Tom Copeland
a26172a2a1 Rules are now run in the order in which they're listed in a ruleset file. Internally, they're now stored in a List vs a Set, and RuleSet.getRules() now returns a Collection.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4211 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-08 15:00:59 +00:00
Tom Copeland
49320aea1f Ah, that's right, this was a hack. Hooray for unit tests, which exposed this deviousness!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4210 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-08 14:53:30 +00:00
Tom Copeland
eb1eaab67f SAXException, not SaxException - doh!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4209 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-08 14:32:42 +00:00
Tom Copeland
aeffeaec3d Fixed compilation problems, JSP tests are not yet working, but all other tests run
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4208 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-08 14:24:11 +00:00
Tom Copeland
0361e0d4b5 Initial checkin of JSP support; code is not yet compiling
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4207 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-07 03:14:33 +00:00
Philippe Herlin
617871db1e Fix fragment howto about the plugin-id
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4206 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-06 21:39:23 +00:00
Philippe Herlin
9ff5641b80 Prepare release v3.1.4
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4205 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-06 21:38:49 +00:00
Philippe Herlin
dae8974bf4 Apply a patch to PMD v3.5
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4202 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-06 21:15:15 +00:00
Radim Kubacki
991779b3be http://www.netbeans.org/issues/show_bug.cgi?id=72298 - mnemonics in options dialog
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4201 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-06 15:04:47 +00:00
Radim Kubacki
cea45ee1e7 http://www.netbeans.org/issues/show_bug.cgi?id=72199 - underline color changed to yellow like warning rather than red (error)
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4200 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-06 13:36:12 +00:00
Tom Copeland
a180e9b191 Fixed bug 1415663 - PMD no longer fails to parse abstract classes declared in a method.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4199 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-05 03:09:44 +00:00
Tom Copeland
1db35d70fa Fixed bug 1415333 - CyclomaticComplexity no longer errors out on JDK 1.5 enums.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4198 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-04 20:36:35 +00:00
Tom Copeland
1a0e5b39c1 Fixed bug 1415326 - JUnitTestsShouldContainAsserts no longer errors out on JDK 1.5 generics.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4197 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-04 18:53:49 +00:00
Tom Copeland
63b99fbcbb Minor refactoring
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4196 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-03 23:20:31 +00:00
Tom Copeland
2d26de182f UseIndexOfChar now catches cases involving lastIndexOf.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4195 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-03 23:09:51 +00:00
Tom Copeland
8d8aa460a7 Removed duplicate copy of UseIndexOfChar definition
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4194 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-03 23:02:33 +00:00
Tom Copeland
0eb8b74ae7 Fixed bug 1416164 - InefficientStringBuffering no longer reports false positives on the three argument version of StringBuffer.append().
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4193 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-03 22:52:18 +00:00
Radim Kubacki
aa5af02970 http://www.netbeans.org/issues/show_bug.cgi?id=72215 - NPE when a rule has no example
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4192 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-03 16:21:40 +00:00
Allan Caplan
0a4214aeb1 Fixed to use getUsages
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4191 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-03 02:39:44 +00:00
Allan Caplan
709988e74e This is the rule proposed by Brian in
http://sourceforge.net/forum/forum.php?thread_id=1431090&forum_id=188194

This code finds any case where


string.trim().length()==0

comparison is made. Code only looks for 0 specifically,
so if a static instance variable is used to specify 0
it's ignored.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4190 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-03 01:04:18 +00:00
Tom Copeland
a3d1537618 Moved Allan up to the committers section, good times!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4189 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-02 02:26:54 +00:00
Radim Kubacki
74b6df5d7a http://www.netbeans.org/issues/show_bug.cgi?id=72017 - NPE when running on some non Java files
more reliably closing progress handle
and finally I've writen a test for this


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4188 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-01 15:29:59 +00:00
Tom Copeland
f204d3613a Fixed bug 1421409 - Ant task now has setter to allow minimumPriority attribute to be used. Thanks to Paul Smith for the patch!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4187 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-01 14:14:32 +00:00
Tom Copeland
546ec29849 Added 'releases' ruleset for 3.3
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4186 51baf565-9d33-0410-a72c-fc3788e3496d
2006-02-01 13:55:45 +00:00
Tom Copeland
916bc2849c Added more rules to 35.xml; added 34.xml
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4185 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-31 06:21:18 +00:00
Tom Copeland
17f255d314 noting Didier's recent reports
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4184 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-31 06:15:44 +00:00
Tom Copeland
5c06e89a6f Implemented RFE 1415487 - Added a rulesets/releases/35.xml ruleset contains rules new to release 3.5. Should retrofit previous releases as well. Thanks to Elliotte Rusty Harold for the suggestion!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4183 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-31 06:14:24 +00:00
Tom Copeland
39caedcfba Implemented RFE 1415487 - Added a rulesets/releases/35.xml ruleset contains rules new to release 3.5. Should retrofit previous releases as well. Thanks to Elliotte Rusty Harold for the suggestion!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4182 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-31 06:14:23 +00:00
Tom Copeland
fb15abd025 Fixed bug 1416167 - AppendCharacterWithChar now catches cases involving escaped characters. Thanks to Allan Caplan for the fix!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4181 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-31 05:58:42 +00:00
Tom Copeland
695fc2d64b Fixed bug 1418424 - ConsecutiveLiteralAppends no longer flags appends in separate methods
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4180 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-31 01:47:45 +00:00
Tom Copeland
17ba896996 *** empty log message ***
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4178 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-31 01:11:54 +00:00
Tom Copeland
bb3f37efa6 rls preps
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4177 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-31 01:08:43 +00:00
Tom Copeland
cda6ece2db corrected name
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4176 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-31 00:13:43 +00:00
Tom Copeland
6a4b879438 rls preps
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4175 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-30 23:14:11 +00:00
Tom Copeland
f5716a9fea rls preps; updated to work with 1013 final and pmd-3.5
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4174 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-30 16:47:48 +00:00
Tom Copeland
b1fa90e9e2 Added xml libs to Class-Path attribute, changed name of OptimalAdvisor
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4173 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-30 14:26:19 +00:00
Tom Copeland
f8b46ea1bd Erik Thauvin suggested this way to avoid problems with quotes in IDEA paths; thanks Erik!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4172 51baf565-9d33-0410-a72c-fc3788e3496d
2006-01-30 13:55:20 +00:00