hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity
4,557 Commits 16 Branches 123 Tags
Commit Graph

4557 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Xavier Le Vourch
d1f45bb555 SourceType made Comparable 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4721 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-20 22:50:18 +00:00
Xavier Le Vourch
91614290e7 pmd requires javac 1.4 or newer 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4720 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-20 22:44:37 +00:00
Xavier Le Vourch
fef103761e java 1.4 is needed to run pmd 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4719 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-20 22:40:30 +00:00
Tom Copeland
2aa188e17e The remainder of the fixes from Aaron, thanks much! 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4718 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-20 19:56:36 +00:00
Tom Copeland
7c6cba0e76 Oops 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4717 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-20 19:51:22 +00:00
Tom Copeland
ddf3533bbf Fixed false negatives in UseArraysAsList, thanks to Fabio Insaccanebbia for the patch! 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4716 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-20 19:38:12 +00:00
Tom Copeland
2fb2fcd14d Now a rule can access the SourceType via the RuleContext 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4715 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-20 15:38:09 +00:00
Xavier Le Vourch
5fb4c57b46 use of entrySet to iterate over Maps. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4714 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-20 06:03:04 +00:00
Brian Remedios
2e0477cdb1 renamed poorly-named interface 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4713 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-20 02:44:37 +00:00
Brian Remedios
b66c99dc6c minor performance tweak & import set cleanup 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4712 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-20 02:42:07 +00:00
Brian Remedios
fa760a735c minor optimization 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4711 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-20 02:40:49 +00:00
Brian Remedios
d120170a5e minor cleanup (Vector -> ArrayList), etc 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4710 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-20 02:40:14 +00:00
Tom Copeland
dff3475e32 Fixed bug 1580859 - AvoidDecimalLiteralsInBigDecimalConstructor now catches more cases, thanks to Ryan Gustafson for the fix! 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4709 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-20 01:57:47 +00:00
Tom Copeland
67e3695637 Fixed JDK 1.5 source parsing bug 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4708 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-19 21:10:09 +00:00
Tom Copeland
923173a3e9 Fixed bug 1579615 - OverrideBothEqualsAndHashcode no longer throws an Exception on equals methods that don't have Object as a parameter type. Thanks to Wouter Zelle for the report and the fix! 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4707 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-19 20:45:24 +00:00
Tom Copeland
de197ba845 *** empty log message *** 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4706 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-19 18:14:40 +00:00
Tom Copeland
7b1671ca6d Improvements to equals from Sven Jacob 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4705 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-19 18:14:32 +00:00
Tom Copeland
ad0bec0843 Some tweaks from Aaron Optimizer Digulla 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4704 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-19 15:28:27 +00:00
Brian Remedios
ce424d73a2 refactored type lookup functionality with a new TypeMap 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4703 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-18 13:26:10 +00:00
Allan Caplan
f0e67f2dbc Soliciting feedback. Please see: https://sourceforge.net/forum/message.php?msg_id=3968620 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4702 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-18 00:22:16 +00:00
Allan Caplan
82a7af9b27 Temporary check in - looking for feedback, some working code for symbol resolution 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4701 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-17 16:50:34 +00:00
Xavier Le Vourch
4461137169 Spelling 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4700 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-17 04:34:58 +00:00
Brian Remedios
f32e56c7c8 added property descriptors & references to them 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4699 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-17 02:37:43 +00:00
Brian Remedios
1ea1900e09 added property descriptors & references to them 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4698 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-17 02:28:09 +00:00
Brian Remedios
a2744c7eae added property descriptors & references to them 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4697 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-17 02:22:18 +00:00
Brian Remedios
99246f8819 added property descriptors & references to them 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4696 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-17 02:10:16 +00:00
Brian Remedios
9039d018c8 added property descriptors & references to them 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4695 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-17 02:04:43 +00:00
Brian Remedios
e54bf36d7a replaced getImage().equals with utility method hasImageEqualTo (cleaner & handles nulls) 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4694 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-17 01:07:18 +00:00
Brian Remedios
3969dcbf7c minor performance tweaks 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4693 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-17 01:01:33 +00:00
Brian Remedios
e4a9e4128b replaced getImage().equals with utility method hasImageEqualTo (cleaner & handles nulls) 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4692 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-17 00:48:10 +00:00
Brian Remedios
56a8619c4e revised method call 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4691 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-17 00:27:46 +00:00
Brian Remedios
ad68c535bb updated to use revised API 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4690 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-17 00:24:21 +00:00
Brian Remedios
834b9848d6 rm calls to deprecated methods in test suite 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4689 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-17 00:18:07 +00:00
Allan Caplan
9c0eef920c Fixed bugs 1060761 / 1433119 & RFE 1196954 - CloseResource now takes an optional parameter to identify closure methods 
Using strings to identify the parameter, and not the property descriptor as the JUnit test did not pass using the property descriptor.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4688 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-17 00:13:16 +00:00
Brian Remedios
bb51e44aaf updated test suite to accommodate API change 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4687 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-17 00:00:18 +00:00
Brian Remedios
54124e6034 replaced new Integers with constants 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4686 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-16 23:39:13 +00:00
Allan Caplan
2395305df3 Fixing Integer.valueOf 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4685 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-16 23:35:27 +00:00
Allan Caplan
75c4980c4c Fixing Integer.valueOf 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4684 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-16 23:05:13 +00:00
Brian Remedios
9797a8857d revised API to use descriptors as property keys rather than strings 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4683 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-16 20:55:31 +00:00
Allan Caplan
0e8bf7c3ab Implemented RFE 1566313 - allow minimumpriority attribute to be set at command line 
used same attribute as the ant task, minimumpriority, but used all lower case to keep in line with other command line params


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4682 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-16 19:10:42 +00:00
Allan Caplan
da63ae1c76 Applied patch 1565532 Java NCSS checks from Jason Bennett 
Changes made:
- Changed classes to Ncss* to maintain consistency between them and the rule name
- Added JUnit tests. Ran against NCSS current release to validate code size
- Moved to codesize package


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4681 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-16 15:42:45 +00:00
Allan Caplan
2378d27100 Implemented patch 1577540 from Jason Bennet 
Patch is for Feature Request ] 1434274 - UseCollectionIsEmpty
Thanks Jason!

Some small tweaks: Moved some null checks around for performance, added JUnit test.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4680 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-16 14:40:51 +00:00
Tom Copeland
d366791ce8 Trying to get under the SF quota 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4679 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-16 14:24:48 +00:00
Allan Caplan
d71a09c431 Testing for bug 1432595 :False +: MissingStaticMethodInNonInstantiatableClass 
Not reproducable


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4678 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-16 13:35:18 +00:00
Tom Copeland
b3ae8d05cf More complexity measurement cleanups from Jason Bennett; thanks Jason! 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4677 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-16 13:25:23 +00:00
Allan Caplan
3975d821c3 Adding tests for defect report: http://sourceforge.net/tracker/index.php?func=detail&aid=1531158&group_id=56262&atid=479921 
Could not reproduce - issue may have been fixed


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4676 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-16 13:15:40 +00:00
Tom Copeland
cdc30a26d1 More tweaks from Peter 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4675 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-16 12:56:31 +00:00
Tom Copeland
e1871526ed Er, I mean, a better 'create rule XML' panel from _Peter Van de Voorde_ 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4674 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-16 12:54:29 +00:00
Tom Copeland
0560184d06 A better 'create rule XML' panel from Sven Jacob 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4673 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-16 12:52:11 +00:00
Brian Remedios
ee22ca56c2 minor optimization 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4672 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-16 04:03:18 +00:00