nixpkgs/.github/PULL_REQUEST_TEMPLATE.md

###### Motivation for this change


###### Things done

Please check what applies. Note that these are not hard requirements but mereley serve as information for reviewers.

- [ ] Tested using sandboxing
  ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS,
    or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)
    on non-NixOS)
- Built on platform(s)
   - [ ] NixOS
   - [ ] macOS
   - [ ] Linux
- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
- [ ] Tested execution of all binary files (usually in `./result/bin/`)
- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

---
Update PR template with motivation for changes I'm seeing a lot of PRs that only include the checklist, when the main thing I care about when I'm reviewing a PR is what the author was thinking when they decided to make the change. 2016-05-24 11:59:46 +00:00			`###### Motivation for this change`


Simplify contributing * Highlight the top mistakes directly in CONTRIBUTING.md * Remove unecessary cruft from the PR template 2016-04-09 16:53:24 +00:00			`###### Things done`
PULL_REQUEST_TEMPLATE: fix issues raised in 3c84ae406 2016-02-28 09:26:21 +00:00
Pull request template: clarify the purpose of the template 2017-07-22 16:04:19 +00:00			`Please check what applies. Note that these are not hard requirements but mereley serve as information for reviewers.`

github PR template: reformulate the sandboxing help It's been reported that when running through nix daemon, sandboxing can't be turned on by passing `--option` (silently ignored), so let's not suggest that way. https://github.com/NixOS/nixpkgs/issues/14866#issuecomment-214619909 2016-04-26 07:14:39 +00:00			`- [ ] Tested using sandboxing`
PULL_REQUEST_TEMPLATE: rename chroot to sandbox See https://github.com/NixOS/nix/commit/b39622a487e2978bd32c9faf2f651aec1f9815c1 2016-09-02 19:41:43 +00:00			`([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS,`
			or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)
github PR template: reformulate the sandboxing help It's been reported that when running through nix daemon, sandboxing can't be turned on by passing `--option` (silently ignored), so let's not suggest that way. https://github.com/NixOS/nixpkgs/issues/14866#issuecomment-214619909 2016-04-26 07:14:39 +00:00			`on non-NixOS)`
.github/PULL_REQUEST_TEMPLATE.md: use individual checkboxes for tested OSes 2016-03-16 08:46:05 +00:00			`- Built on platform(s)`
			`- [ ] NixOS`
Update PULL_REQUEST_TEMPLATE.md Follow the rebranding of OS X into macOS 2016-11-04 15:49:40 +00:00			`- [ ] macOS`
.github/PULL_REQUEST_TEMPLATE.md: use individual checkboxes for tested OSes 2016-03-16 08:46:05 +00:00			`- [ ] Linux`
github/pr-template: Add note about NixOS tests On several occasions I've seen people bumping packages which have NixOS tests but without actually running them. While this probably won't prevent such occasions entirely, at least it serves as an additional checklist item so contributors don't forget about these tests. Signed-off-by: aszlig <aszlig@redmoonstudios.org> 2017-06-23 03:33:06 +00:00			`- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))`
PULL_REQUEST_TEMPLATE.md: clarify a few things 2016-02-28 08:49:55 +00:00			- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
			- [ ] Tested execution of all binary files (usually in `./result/bin/`)
PULL_REQUEST_TEMPLATE: init 2016-02-18 16:26:17 +00:00			`- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).`

			`---`