jolheiser/nixpkgs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #119915 from evils/review-review

Browse Source 
docs: correct some english
This commit is contained in:
Domen Kožar 2021-04-20 09:40:15 +01:00 committed by GitHub
commit 39cce06a6b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
doc/contributing/reviewing-contributions.xml
View File

@ -170,60 +170,60 @@
</para>
<para>
Reviewing process:
Review process:
</para>
<itemizedlist>
<listitem>
<para>
Ensure that the package versioning is fitting the guidelines.
Ensure that the package versioning fits the guidelines.
</para>
</listitem>
<listitem>
<para>
Ensure that the commit name is fitting the guidelines.
Ensure that the commit name fits the guidelines.
</para>
</listitem>
<listitem>
<para>
Ensure that the meta field contains correct information.
Ensure that the meta fields contain correct information.
</para>
<itemizedlist>
<listitem>
<para>
License must be checked to be fitting upstream license.
License must match the upstream license.
</para>
</listitem>
<listitem>
<para>
Platforms should be set or the package will not get binary substitutes.
Platforms should be set (or the package will not get binary substitutes).
</para>
</listitem>
<listitem>
<para>
A maintainer must be set. This can be the package submitter or a community member that accepts to take maintainership of the package.
Maintainers must be set. This can be the package submitter or a community member that accepts taking up maintainership of the package.
</para>
</listitem>
</itemizedlist>
</listitem>
<listitem>
<para>
Ensure that the code contains no typos.
Report detected typos.
</para>
</listitem>
<listitem>
<para>
Ensure the package source.
Ensure the package source:
</para>
<itemizedlist>
<listitem>
<para>
Mirrors urls should be used when available.
Uses mirror URLs when available.
</para>
</listitem>
<listitem>
<para>
The most appropriate function should be used (e.g. packages from GitHub should use <literal>fetchFromGitHub</literal>).
Uses the most appropriate functions (e.g. packages from GitHub should use <literal>fetchFromGitHub</literal>).
</para>
</listitem>
</itemizedlist>