Merge pull request #119915 from evils/review-review

docs: correct some english
This commit is contained in:
Domen Kožar 2021-04-20 09:40:15 +01:00 committed by GitHub
commit 39cce06a6b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -170,60 +170,60 @@
</para> </para>
<para> <para>
Reviewing process: Review process:
</para> </para>
<itemizedlist> <itemizedlist>
<listitem> <listitem>
<para> <para>
Ensure that the package versioning is fitting the guidelines. Ensure that the package versioning fits the guidelines.
</para> </para>
</listitem> </listitem>
<listitem> <listitem>
<para> <para>
Ensure that the commit name is fitting the guidelines. Ensure that the commit name fits the guidelines.
</para> </para>
</listitem> </listitem>
<listitem> <listitem>
<para> <para>
Ensure that the meta field contains correct information. Ensure that the meta fields contain correct information.
</para> </para>
<itemizedlist> <itemizedlist>
<listitem> <listitem>
<para> <para>
License must be checked to be fitting upstream license. License must match the upstream license.
</para> </para>
</listitem> </listitem>
<listitem> <listitem>
<para> <para>
Platforms should be set or the package will not get binary substitutes. Platforms should be set (or the package will not get binary substitutes).
</para> </para>
</listitem> </listitem>
<listitem> <listitem>
<para> <para>
A maintainer must be set. This can be the package submitter or a community member that accepts to take maintainership of the package. Maintainers must be set. This can be the package submitter or a community member that accepts taking up maintainership of the package.
</para> </para>
</listitem> </listitem>
</itemizedlist> </itemizedlist>
</listitem> </listitem>
<listitem> <listitem>
<para> <para>
Ensure that the code contains no typos. Report detected typos.
</para> </para>
</listitem> </listitem>
<listitem> <listitem>
<para> <para>
Ensure the package source. Ensure the package source:
</para> </para>
<itemizedlist> <itemizedlist>
<listitem> <listitem>
<para> <para>
Mirrors urls should be used when available. Uses mirror URLs when available.
</para> </para>
</listitem> </listitem>
<listitem> <listitem>
<para> <para>
The most appropriate function should be used (e.g. packages from GitHub should use <literal>fetchFromGitHub</literal>). Uses the most appropriate functions (e.g. packages from GitHub should use <literal>fetchFromGitHub</literal>).
</para> </para>
</listitem> </listitem>
</itemizedlist> </itemizedlist>