jolheiser/nixpkgs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pythonPackages.pkgconfig: use same setupHook as pkgconfig

Browse Source 
This setupHook is necessary for actually using pkgconfig. Without this
setupHook, you need to put both pythonPackages.pkgconfig and pkgconfig
into your buildInputs, just to get the setuphook of the latter.

Previously, pythonPackages.pkgconfig depended on pkgconfig as a
propagatedBuildInput, so this setupHook was propagated down to
dependents. That was changed to a regular nativeBuildInput, so now
this setupHook change is necessary for packages to only depend on
pythonPackages.pkgconfig.

A possible alternative is extracting out a common pkgconfigHook
package and having both pythonPackages.pkgconfig and pkgconfig depend
on that with propagatedBuildInputs. That might be necessary to avoid
the buildHook running twice?
This commit is contained in:
Spencer Baugh 2019-02-12 19:17:05 +00:00 committed by Frederik Rietdijk
parent 50b1d64534
commit 46f2b49b44
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkgs/development/python-modules/pkgconfig/default.nix
View File

@ -4,6 +4,8 @@ buildPythonPackage rec {
pname = "pkgconfig";
version = "1.4.0";
setupHook = pkgconfig.setupHook;
src = fetchPypi {
inherit pname version;
sha256 = "048c3b457da7b6f686b647ab10bf09e2250e4c50acfe6f215398a8b5e6fcdb52";