jolheiser/nixpkgs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix chrootenv segfaulting on exit

Browse Source 
glibc 2.27 (and possibly other versions) can't handle an `nopenfd` value larger than 2^19 in `ntfw`, which is problematic if you've set the maximum number of fds per process to a value higher than that.
This commit is contained in:
Las 2019-05-26 17:19:06 +02:00 committed by GitHub
parent 567b63c78f
commit 50c215df4a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pkgs/build-support/build-fhs-userenv/chrootenv/chrootenv.c
View File

@ -19,6 +19,10 @@
#include <sys/types.h>
#include <sys/wait.h>
int min(int a, int b) {
return a > b ? b : a;
}
const gchar *bind_blacklist[] = {"bin", "etc", "host", "usr", "lib", "lib64", "lib32", "sbin", NULL};
void bind_mount(const gchar *source, const gchar *target) {
@ -126,7 +130,9 @@ int main(gint argc, gchar **argv) {
int status;
fail_if(waitpid(cpid, &status, 0) != cpid);
fail_if(nftw(prefix, nftw_remove, getdtablesize(),
// glibc 2.27 (and possibly other versions) can't handle
// an nopenfd value larger than 2^19
fail_if(nftw(prefix, nftw_remove, min(getdtablesize(), 1<<19),
FTW_DEPTH | FTW_MOUNT | FTW_PHYS));
if (WIFEXITED(status))