This largely reverts commit 599312739e3a338f923e6c22ab183178ca49c7b6.
The main reason is that it breaks the plugins, because the mentioned
commit didn't change the attributes for the plugins as well.
But instead of just fixing the attributes when we import the plugin
packages, let's just override pythonPackages in all-packages.nix.
Right now, Beets is in transition to Python 3, so we don't need to wait
that long until we can remove the dependency on Python 2:
https://github.com/beetbox/beets/releases/tag/v1.4.1
Once Python 3 support is no longer beta, we can just change this by
changing one line only instead of several.
Tested this by building beets with both external plugins.
Signed-off-by: aszlig <aszlig@redmoonstudios.org>
Cc: @FRidh
Packaging itself is pretty much straightforward, the tests however
revealed a few issues, which I have fixed with a small patch that has
been upstreamed at https://github.com/karlch/vimiv/pull/32.
The other sed-based patches in postPatch are mostly NixOS-specific.
Signed-off-by: aszlig <aszlig@redmoonstudios.org>
There's no reason to disable ALL tests just because only one particular
test module is failing.
Tested on i686-linux and x86_64-linux against these Python versions:
Python 2.6: The interpreter itself doesn't build
Python 2.7: Successful for both architectures
Python 3.3: Successful for both architectures
Python 3.4: Successful for both architectures
Python 3.5: Successful for both architectures
Python 3.6: One of the dependencies of pillow doesn't build (pytest)
Tests for PyPy still fail, which is why the doCheck attribute is only
set to false if we're building for PyPy.
Signed-off-by: aszlig <aszlig@redmoonstudios.org>
Cc: @desiderius, @goibhniu, @prikhi
pytest plugins should not propagate pytest. Instead, packages depending
on pytest and plugins, should explicitly depend on both the plugin(s)
and pytest. This change will more easily allow packages to depend on
another version of pytest when needed.
- rename to PyLTI to follow upstream
- remove overriding because it is not necessary; newer mock can be used,
and modules python packages should be fixed to not propagate pytest (see
separate commit).
cc maintainer @layus
This reverts commit c1b919ff5c13103017e750fb6a7a1dfdeaf23394. That kind of
change is a maintenance nightmare because it unconditionally overrides the
package's version specified in hackage-packages.nix with something else, i.e.
no future update will ever have an effect. This is not the proper way to do it.
The proper way is to add the relevant commit from Github as a patch.
