Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/gpodder/versions.
These checks were done:
- built on NixOS
- Warning: no invocation of /nix/store/8rqasrwlljygffj6i4nf8v8v75bhc255-gpodder-3.10.3/bin/gpo had a zero exit code or showed the expected version
- /nix/store/8rqasrwlljygffj6i4nf8v8v75bhc255-gpodder-3.10.3/bin/gpodder passed the binary check.
- Warning: no invocation of /nix/store/8rqasrwlljygffj6i4nf8v8v75bhc255-gpodder-3.10.3/bin/gpodder-migrate2tres had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/8rqasrwlljygffj6i4nf8v8v75bhc255-gpodder-3.10.3/bin/..gpo-wrapped-wrapped had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/8rqasrwlljygffj6i4nf8v8v75bhc255-gpodder-3.10.3/bin/.gpo-wrapped had a zero exit code or showed the expected version
- /nix/store/8rqasrwlljygffj6i4nf8v8v75bhc255-gpodder-3.10.3/bin/..gpodder-wrapped-wrapped passed the binary check.
- /nix/store/8rqasrwlljygffj6i4nf8v8v75bhc255-gpodder-3.10.3/bin/.gpodder-wrapped passed the binary check.
- Warning: no invocation of /nix/store/8rqasrwlljygffj6i4nf8v8v75bhc255-gpodder-3.10.3/bin/..gpodder-migrate2tres-wrapped-wrapped had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/8rqasrwlljygffj6i4nf8v8v75bhc255-gpodder-3.10.3/bin/.gpodder-migrate2tres-wrapped had a zero exit code or showed the expected version
- 3 of 9 passed binary check by having a zero exit code.
- 0 of 9 passed binary check by having the new version present in output.
- found 3.10.3 with grep in /nix/store/8rqasrwlljygffj6i4nf8v8v75bhc255-gpodder-3.10.3
- directory tree listing: https://gist.github.com/40569f5fea3ccd68574abaead2e57c56
- du listing: https://gist.github.com/7491af6e9fa6d0fbe76c75499dba579b
The `buildPython*` function computes name from `pname` and `version`.
This change removes `name` attribute from all expressions in
`pkgs/development/python-modules`.
While at it, some other minor changes were made as well, such as
replacing `fetchurl` calls with `fetchPypi`.
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/fldigi/versions.
These checks were done:
- built on NixOS
- /nix/store/87mml563vxqamznb9i9kfyi1pz9ldkxj-fldigi-4.0.17/bin/fldigi passed the binary check.
- Warning: no invocation of /nix/store/87mml563vxqamznb9i9kfyi1pz9ldkxj-fldigi-4.0.17/bin/flarq had a zero exit code or showed the expected version
- 1 of 2 passed binary check by having a zero exit code.
- 0 of 2 passed binary check by having the new version present in output.
- found 4.0.17 with grep in /nix/store/87mml563vxqamznb9i9kfyi1pz9ldkxj-fldigi-4.0.17
- directory tree listing: https://gist.github.com/fa90913d77a29b869e48c2c455710bd7
- du listing: https://gist.github.com/9172dd2cacb00accaffafe285aacea29
In particular, this contains Firefox-related and libgcrypt updates.
Other larger rebuilds would apparently need lots of time to catch up
on Hydra, due to nontrivial rebuilds in other branches than staging.
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/gpodder/versions.
These checks were done:
- built on NixOS
- Warning: no invocation of /nix/store/d43pzkl3230xay7l9wh65whsmsf9lwxa-gpodder-3.10.2/bin/gpo had a zero exit code or showed the expected version
- /nix/store/d43pzkl3230xay7l9wh65whsmsf9lwxa-gpodder-3.10.2/bin/gpodder passed the binary check.
- Warning: no invocation of /nix/store/d43pzkl3230xay7l9wh65whsmsf9lwxa-gpodder-3.10.2/bin/gpodder-migrate2tres had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/d43pzkl3230xay7l9wh65whsmsf9lwxa-gpodder-3.10.2/bin/..gpo-wrapped-wrapped had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/d43pzkl3230xay7l9wh65whsmsf9lwxa-gpodder-3.10.2/bin/.gpo-wrapped had a zero exit code or showed the expected version
- /nix/store/d43pzkl3230xay7l9wh65whsmsf9lwxa-gpodder-3.10.2/bin/..gpodder-wrapped-wrapped passed the binary check.
- /nix/store/d43pzkl3230xay7l9wh65whsmsf9lwxa-gpodder-3.10.2/bin/.gpodder-wrapped passed the binary check.
- Warning: no invocation of /nix/store/d43pzkl3230xay7l9wh65whsmsf9lwxa-gpodder-3.10.2/bin/..gpodder-migrate2tres-wrapped-wrapped had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/d43pzkl3230xay7l9wh65whsmsf9lwxa-gpodder-3.10.2/bin/.gpodder-migrate2tres-wrapped had a zero exit code or showed the expected version
- 3 of 9 passed binary check by having a zero exit code.
- 0 of 9 passed binary check by having the new version present in output.
- found 3.10.2 with grep in /nix/store/d43pzkl3230xay7l9wh65whsmsf9lwxa-gpodder-3.10.2
- directory tree listing: https://gist.github.com/cca3f358e73f8f49b3d0dcd3e5549728
- du listing: https://gist.github.com/54e8debaadfab87d705cbf72656b4f35
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/quodlibet/versions.
These checks were done:
- built on NixOS
- Warning: no invocation of /nix/store/3p27i5pd743r3jxcpffgm4646xmcx5x7-quodlibet-4.1.0/bin/exfalso had a zero exit code or showed the expected version
- /nix/store/3p27i5pd743r3jxcpffgm4646xmcx5x7-quodlibet-4.1.0/bin/operon passed the binary check.
- Warning: no invocation of /nix/store/3p27i5pd743r3jxcpffgm4646xmcx5x7-quodlibet-4.1.0/bin/quodlibet had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/3p27i5pd743r3jxcpffgm4646xmcx5x7-quodlibet-4.1.0/bin/..exfalso-wrapped-wrapped had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/3p27i5pd743r3jxcpffgm4646xmcx5x7-quodlibet-4.1.0/bin/.exfalso-wrapped had a zero exit code or showed the expected version
- /nix/store/3p27i5pd743r3jxcpffgm4646xmcx5x7-quodlibet-4.1.0/bin/..operon-wrapped-wrapped passed the binary check.
- /nix/store/3p27i5pd743r3jxcpffgm4646xmcx5x7-quodlibet-4.1.0/bin/.operon-wrapped passed the binary check.
- Warning: no invocation of /nix/store/3p27i5pd743r3jxcpffgm4646xmcx5x7-quodlibet-4.1.0/bin/..quodlibet-wrapped-wrapped had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/3p27i5pd743r3jxcpffgm4646xmcx5x7-quodlibet-4.1.0/bin/.quodlibet-wrapped had a zero exit code or showed the expected version
- 3 of 9 passed binary check by having a zero exit code.
- 0 of 9 passed binary check by having the new version present in output.
- found 4.1.0 with grep in /nix/store/3p27i5pd743r3jxcpffgm4646xmcx5x7-quodlibet-4.1.0
- directory tree listing: https://gist.github.com/296d4e647e2235036b698f635ea58ee1
- du listing: https://gist.github.com/78b82ba179474dd128d2bd74355001fe
Lots of packages are missing versions in their name. This adds them
where appropriate. These were found with this command:
$ nix-env -qa -f. | grep -v '\-[0-9A-Za-z.-_+]*$' | grep -v '^hook$'
See issue #41007.
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/csound/versions.
These checks were done:
- built on NixOS
- /nix/store/a8lvlqn930nsjmak9km1nj3xa51iclfy-csound-6.11.0/bin/csound passed the binary check.
- /nix/store/a8lvlqn930nsjmak9km1nj3xa51iclfy-csound-6.11.0/bin/csbeats passed the binary check.
- Warning: no invocation of /nix/store/a8lvlqn930nsjmak9km1nj3xa51iclfy-csound-6.11.0/bin/csdebugger had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/a8lvlqn930nsjmak9km1nj3xa51iclfy-csound-6.11.0/bin/atsa had a zero exit code or showed the expected version
- /nix/store/a8lvlqn930nsjmak9km1nj3xa51iclfy-csound-6.11.0/bin/csanalyze passed the binary check.
- Warning: no invocation of /nix/store/a8lvlqn930nsjmak9km1nj3xa51iclfy-csound-6.11.0/bin/cvanal had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/a8lvlqn930nsjmak9km1nj3xa51iclfy-csound-6.11.0/bin/dnoise had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/a8lvlqn930nsjmak9km1nj3xa51iclfy-csound-6.11.0/bin/envext had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/a8lvlqn930nsjmak9km1nj3xa51iclfy-csound-6.11.0/bin/extractor had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/a8lvlqn930nsjmak9km1nj3xa51iclfy-csound-6.11.0/bin/het_export had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/a8lvlqn930nsjmak9km1nj3xa51iclfy-csound-6.11.0/bin/het_import had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/a8lvlqn930nsjmak9km1nj3xa51iclfy-csound-6.11.0/bin/hetro had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/a8lvlqn930nsjmak9km1nj3xa51iclfy-csound-6.11.0/bin/lpanal had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/a8lvlqn930nsjmak9km1nj3xa51iclfy-csound-6.11.0/bin/lpc_export had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/a8lvlqn930nsjmak9km1nj3xa51iclfy-csound-6.11.0/bin/lpc_import had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/a8lvlqn930nsjmak9km1nj3xa51iclfy-csound-6.11.0/bin/mixer had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/a8lvlqn930nsjmak9km1nj3xa51iclfy-csound-6.11.0/bin/pvanal had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/a8lvlqn930nsjmak9km1nj3xa51iclfy-csound-6.11.0/bin/pvlook had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/a8lvlqn930nsjmak9km1nj3xa51iclfy-csound-6.11.0/bin/pv_export had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/a8lvlqn930nsjmak9km1nj3xa51iclfy-csound-6.11.0/bin/pv_import had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/a8lvlqn930nsjmak9km1nj3xa51iclfy-csound-6.11.0/bin/scale had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/a8lvlqn930nsjmak9km1nj3xa51iclfy-csound-6.11.0/bin/sndinfo had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/a8lvlqn930nsjmak9km1nj3xa51iclfy-csound-6.11.0/bin/srconv had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/a8lvlqn930nsjmak9km1nj3xa51iclfy-csound-6.11.0/bin/src_conv had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/a8lvlqn930nsjmak9km1nj3xa51iclfy-csound-6.11.0/bin/sdif2ad had a zero exit code or showed the expected version
- /nix/store/a8lvlqn930nsjmak9km1nj3xa51iclfy-csound-6.11.0/bin/scsort passed the binary check.
- Warning: no invocation of /nix/store/a8lvlqn930nsjmak9km1nj3xa51iclfy-csound-6.11.0/bin/extract had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/a8lvlqn930nsjmak9km1nj3xa51iclfy-csound-6.11.0/bin/cs had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/a8lvlqn930nsjmak9km1nj3xa51iclfy-csound-6.11.0/bin/csb64enc had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/a8lvlqn930nsjmak9km1nj3xa51iclfy-csound-6.11.0/bin/makecsd had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/a8lvlqn930nsjmak9km1nj3xa51iclfy-csound-6.11.0/bin/scot had a zero exit code or showed the expected version
- 4 of 31 passed binary check by having a zero exit code.
- 0 of 31 passed binary check by having the new version present in output.
- found 6.11.0 with grep in /nix/store/a8lvlqn930nsjmak9km1nj3xa51iclfy-csound-6.11.0
- directory tree listing: https://gist.github.com/a9a7303309eb2e6e6ce70fc3f368e8af
- du listing: https://gist.github.com/c8d61a997a4e56d47eab852cdae66f01
"platforms.gnu" has been linux-only since at least 17.03:
$ nix eval -f channel:nixos-17.03 lib.platforms.gnu
[ "i686-linux" "x86_64-linux" "armv5tel-linux" "armv6l-linux" "armv7l-linux" "aarch64-linux" "mips64el-linux" ]
Unlike platforms.linux, platforms.gnu indicates "must use glibc"
which for the most part is not intended.
Replacing platforms.gnu with platforms.linux would be the same "today"
but let's err on preserving existing behavior and be optimistic
about platforms these packages work on.
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/kid3/versions.
These checks were done:
- built on NixOS
- ran ‘/nix/store/frn5bzzva0ysc1vk9adf7lwmlqg28br9-kid3-3.6.1/bin/kid3-cli -h’ got 0 exit code
- ran ‘/nix/store/frn5bzzva0ysc1vk9adf7lwmlqg28br9-kid3-3.6.1/bin/kid3-cli --help’ got 0 exit code
- ran ‘/nix/store/frn5bzzva0ysc1vk9adf7lwmlqg28br9-kid3-3.6.1/bin/kid3-cli help’ got 0 exit code
- found 3.6.1 with grep in /nix/store/frn5bzzva0ysc1vk9adf7lwmlqg28br9-kid3-3.6.1
- directory tree listing: https://gist.github.com/b9be08ae08dde4714bfceaebaf277eab
Following legacy packing conventions, `isArm` was defined just for
32-bit ARM instruction set. This is confusing to non packagers though,
because Aarch64 is an ARM instruction set.
The official ARM overview for ARMv8[1] is surprisingly not confusing,
given the overall state of affairs for ARM naming conventions, and
offers us a solution. It divides the nomenclature into three levels:
```
ISA: ARMv8 {-A, -R, -M}
/ \
Mode: Aarch32 Aarch64
| / \
Encoding: A64 A32 T32
```
At the top is the overall v8 instruction set archicture. Second are the
two modes, defined by bitwidth but differing in other semantics too, and
buttom are the encodings, (hopefully?) isomorphic if they encode the
same mode.
The 32 bit encodings are mostly backwards compatible with previous
non-Thumb and Thumb encodings, and if so we can pun the mode names to
instead mean "sets of compatable or isomorphic encodings", and then
voilà we have nice names for 32-bit and 64-bit arm instruction sets
which do not use the word ARM so as to not confused either laymen or
experienced ARM packages.
[1]: https://developer.arm.com/products/architecture/a-profile
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/flacon/versions.
These checks were done:
- built on NixOS
- ran ‘/nix/store/0m9jr6wv7w3imscxq1lha4q9nrajj7xx-flacon-4.1.0/bin/flacon -h’ got 0 exit code
- ran ‘/nix/store/0m9jr6wv7w3imscxq1lha4q9nrajj7xx-flacon-4.1.0/bin/flacon --help’ got 0 exit code
- ran ‘/nix/store/0m9jr6wv7w3imscxq1lha4q9nrajj7xx-flacon-4.1.0/bin/.flacon-wrapped -h’ got 0 exit code
- ran ‘/nix/store/0m9jr6wv7w3imscxq1lha4q9nrajj7xx-flacon-4.1.0/bin/.flacon-wrapped --help’ got 0 exit code
- found 4.1.0 with grep in /nix/store/0m9jr6wv7w3imscxq1lha4q9nrajj7xx-flacon-4.1.0
- directory tree listing: https://gist.github.com/5db6cc1fd7c7f049d13a305eb9ab5199
The `clementine` package is actually released under Apache license, but
requires the unfree `libspotify` package to build.
Now `nixpkgs.clementine` points to the free derivation and
`nixpkgs.clementineUnfree` has been introduced for the package bundled
with spotify support.
Fixes#38315
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/praat/versions.
These checks were done:
- built on NixOS
- ran `/nix/store/ip7a4lqz98n8dx635131vi3pijyv3kci-praat-6.0.38/bin/praat --help` got 0 exit code
- ran `/nix/store/ip7a4lqz98n8dx635131vi3pijyv3kci-praat-6.0.38/bin/praat --version` and found version 6.0.38
- found 6.0.38 with grep in /nix/store/ip7a4lqz98n8dx635131vi3pijyv3kci-praat-6.0.38
- directory tree listing: https://gist.github.com/3cbb0648e4b084a658f6dd5b7c8ed3a4
Semi-automatic update generated by https://github.com/ryantm/nix-update tools. These checks were done:
- built on NixOS
- ran `/nix/store/23kh3gax6a023mi2r3q31fd1mixa1k14-fluidsynth-1.1.10/bin/fluidsynth -h` got 0 exit code
- ran `/nix/store/23kh3gax6a023mi2r3q31fd1mixa1k14-fluidsynth-1.1.10/bin/fluidsynth --help` got 0 exit code
- ran `/nix/store/23kh3gax6a023mi2r3q31fd1mixa1k14-fluidsynth-1.1.10/bin/fluidsynth help` got 0 exit code
- ran `/nix/store/23kh3gax6a023mi2r3q31fd1mixa1k14-fluidsynth-1.1.10/bin/fluidsynth -V` and found version 1.1.10
- ran `/nix/store/23kh3gax6a023mi2r3q31fd1mixa1k14-fluidsynth-1.1.10/bin/fluidsynth -v` and found version 1.1.10
- ran `/nix/store/23kh3gax6a023mi2r3q31fd1mixa1k14-fluidsynth-1.1.10/bin/fluidsynth --version` and found version 1.1.10
- ran `/nix/store/23kh3gax6a023mi2r3q31fd1mixa1k14-fluidsynth-1.1.10/bin/fluidsynth version` and found version 1.1.10
- ran `/nix/store/23kh3gax6a023mi2r3q31fd1mixa1k14-fluidsynth-1.1.10/bin/fluidsynth -h` and found version 1.1.10
- ran `/nix/store/23kh3gax6a023mi2r3q31fd1mixa1k14-fluidsynth-1.1.10/bin/fluidsynth --help` and found version 1.1.10
- ran `/nix/store/23kh3gax6a023mi2r3q31fd1mixa1k14-fluidsynth-1.1.10/bin/fluidsynth help` and found version 1.1.10
- found 1.1.10 with grep in /nix/store/23kh3gax6a023mi2r3q31fd1mixa1k14-fluidsynth-1.1.10
- directory tree listing: https://gist.github.com/fbd821b325f18bdbc65812caeb1e0ecc
Semi-automatic update generated by https://github.com/ryantm/nix-update tools. These checks were done:
- built on NixOS
/tmp/tmp.FSRC6h0qrp /home/ryantm/.cache/nixpkgs
/home/ryantm/.cache/nixpkgs
- ran `/nix/store/b7qyswz8glvmami13ij30d7xxsi6631n-kid3-3.6.0/bin/kid3-cli -h` got 0 exit code
- ran `/nix/store/b7qyswz8glvmami13ij30d7xxsi6631n-kid3-3.6.0/bin/kid3-cli --help` got 0 exit code
- ran `/nix/store/b7qyswz8glvmami13ij30d7xxsi6631n-kid3-3.6.0/bin/kid3-cli -h` and found version 3.6.0
- ran `/nix/store/b7qyswz8glvmami13ij30d7xxsi6631n-kid3-3.6.0/bin/kid3-cli --help` and found version 3.6.0
- found 3.6.0 with grep in /nix/store/b7qyswz8glvmami13ij30d7xxsi6631n-kid3-3.6.0
- found 3.6.0 in filename of file in /nix/store/b7qyswz8glvmami13ij30d7xxsi6631n-kid3-3.6.0
- directory tree listing: https://gist.github.com/55e96f99bdc127e8e0ab453dc59880e8
Uses the HTTPS url for cases where the existing URL has a permanent
redirect. For each domain, at least one fixed derivation URL was
downloaded to test the domain is properly serving downloads.
Also fixes jbake source URL, which was broken.
Semi-automatic update generated by https://github.com/ryantm/nix-update tools. These checks were done:
- built on NixOS
- Warning: no binary found that responded to help or version flags. (This warning appears even if the package isn't expected to have binaries.)
- found 0.9.0 with grep in /nix/store/qykrhn0p2fv48gyckvdgw9r621cy2s3y-samplv1-0.9.0
- found 0.9.0 in filename of file in /nix/store/qykrhn0p2fv48gyckvdgw9r621cy2s3y-samplv1-0.9.0
Semi-automatic update generated by https://github.com/ryantm/nix-update tools. These checks were done:
- built on NixOS
- Warning: no binary found that responded to help or version flags. (This warning appears even if the package isn't expected to have binaries.)
- found 0.9.0 with grep in /nix/store/hwmra92c366yp6nk74clkyan2bx7hxym-padthv1-0.9.0
- found 0.9.0 in filename of file in /nix/store/hwmra92c366yp6nk74clkyan2bx7hxym-padthv1-0.9.0
Semi-automatic update generated by https://github.com/ryantm/nix-update tools.
This update was made based on information from https://repology.org/metapackage/snd/versions.
These checks were done:
- built on NixOS
- ran `/nix/store/caxkfgbcv6kplihpx8gbivz6l5sisnv5-snd-18.2/bin/snd --help` got 0 exit code
- ran `/nix/store/caxkfgbcv6kplihpx8gbivz6l5sisnv5-snd-18.2/bin/snd --version` and found version 18.2
- ran `/nix/store/caxkfgbcv6kplihpx8gbivz6l5sisnv5-snd-18.2/bin/snd --help` and found version 18.2
- found 18.2 with grep in /nix/store/caxkfgbcv6kplihpx8gbivz6l5sisnv5-snd-18.2
- directory tree listing: https://gist.github.com/549e1eef8a929e09d72499dc97a47aa2
Semi-automatic update generated by https://github.com/ryantm/nix-update tools. These checks were done:
- built on NixOS
- Warning: no binary found that responded to help or version flags. (This warning appears even if the package isn't expected to have binaries.)
- found 3.14.2 with grep in /nix/store/anzim7y47xa3m530qzq91n9wl8ys1kk2-Mopidy-Iris-3.14.2
- directory tree listing: https://gist.github.com/96a0fc1d9812e5c4e6659fd37c7b21c6
