nixpkgs/nixos/modules/installer/cd-dvd
Adam Joseph c0085404bd lib/systems/inspect.nix: remove isPowerPC
Very confusingly, the `isPowerPC` predicate in
`lib/systems/inspect.nix` does *not* match `powerpc64le`!

This is because `isPowerPC` is defined as

  isPowerPC      = { cpu = cpuTypes.powerpc; };

Where `cpuTypes.powerpc` is:

  { bits = 32; significantByte = bigEndian; family = "power"; };

This means that the `isPowerPC` predicate actually only matches the
subset of machines marketed under this name which happen to be 32-bit
and running in big-endian mode which is equivalent to:

  with stdenv.hostPlatform; isPower && isBigEndian && is32bit

This seems like a sharp edge that people could easily cut themselves
on.  In fact, that has already happened: in
`linux/kernel/common-config.nix` there is a test which will always
fail:

  (stdenv.hostPlatform.isPowerPC && stdenv.hostPlatform.is64bit)

A more subtle case of the strict isPowerPC being used instead of the
moreg general isPower accidentally are the GHC expressions:

  Update pkgs/development/compilers/ghc/8.10.7.nix
  Update pkgs/development/compilers/ghc/8.8.4.nix
  Update pkgs/development/compilers/ghc/9.2.2.nix
  Update pkgs/development/compilers/ghc/9.0.2.nix
  Update pkgs/development/compilers/ghc/head.nix

Since the remaining legitimate use sites of isPowerPC are so few, remove
the isPowerPC predicate completely. The alternative expression above is
noted in the release notes as an alternative.

Co-authored-by: sternenseemann <sternenseemann@systemli.org>
2022-05-25 09:45:42 +02:00
..
channel.nix nixos: Fix channel copying in installer tests with systemd stage 1 2022-04-17 18:31:35 -04:00
installation-cd-base.nix installation-cd-base: fix eval 2022-05-08 11:08:10 +03:00
installation-cd-graphical-base.nix Remove mkDefault 2022-05-17 10:36:59 +02:00
installation-cd-graphical-calamares-gnome.nix installation-cd: add calamares-gnome cd 2022-05-03 12:19:20 -04:00
installation-cd-graphical-calamares-plasma5.nix installation-cd: add calamares-plasma5 cd 2022-05-03 12:19:20 -04:00
installation-cd-graphical-calamares.nix installation-cd: add calamares-gnome cd 2022-05-03 12:19:20 -04:00
installation-cd-graphical-gnome.nix installation-cd: add calamares-gnome cd 2022-05-03 12:19:20 -04:00
installation-cd-graphical-plasma5-new-kernel.nix
installation-cd-graphical-plasma5.nix installation-cd: add calamares-plasma5 cd 2022-05-03 12:19:20 -04:00
installation-cd-minimal-new-kernel.nix
installation-cd-minimal.nix
iso-image.nix lib/systems/inspect.nix: remove isPowerPC 2022-05-25 09:45:42 +02:00
sd-image-aarch64-new-kernel.nix
sd-image-aarch64.nix
sd-image-armv7l-multiplatform.nix
sd-image-raspberrypi.nix
sd-image.nix
system-tarball-fuloong2f.nix
system-tarball-pc-readme.txt
system-tarball-pc.nix
system-tarball-sheevaplug.nix nixos/filesystems: Make most simple filesystems compatible with systemd 2022-04-24 16:32:34 +02:00
system-tarball.nix