nixpkgs/pkgs
Ivan ca8b128aa1 credstash: add standalone Python application (#51807)
credstash was only available as a library. Provide it as a standalone
application as well.

In order for this to work, I needed to remove the copy of
the library that's placed in $out/bin and marked executable
during the install phase. Other than the patched shebang and
executable bit, it's identical to the library that's installed to
$out/lib/python3.7/site-packages.

Before the postFixup has run `wrapPythonPrograms`, $out/bin contains
two Python files -- credstash and credstash.py -- where bin/credstash
is the executable you'd expect a user to invoke from the command-line
and bin/credstash.py contains the credstash module, which bin/credstash
imports.

After `wrapPythonPrograms` has run, bin/credstash is a shell
wrapper around the bin/.credstash-wrapped python entrypoint, and
bin/credstash.py is shell wrapper around bin/.credstash.py-wrapped.
Invoking bin/credstash execs bin/.credstash-wrapped, and that python
script attempts to import the credstash module from bin/credstash.py,
the shell wrapper, rather than either bin/.credstash.py-wrapped or
lib/python3.7/site-packages/credstash.py.

This leads to an error:

    $ credstash get mykey
    Traceback (most recent call last):
      File "/nix/store/hk6yma716w6141lcdh509d6qyyi7zm0i-python3.7-credstash-1.15.0/bin/.credstash-wrapped", line 8, in <module>
        from credstash import main
      File "/nix/store/hk6yma716w6141lcdh509d6qyyi7zm0i-python3.7-credstash-1.15.0/bin/credstash.py", line 2
        export PATH='/nix/store/6lm4gi5iv8fbf1b1mm6g3gfnnv63f1gn-python3-3.7.1/bin:/nix/store/hk6yma716w6141lcdh509d6qyyi7zm0i-python3.7-credstash-1.15.0/bin:/nix/store/2n13gf1zdr39ir5dynxlkqndxgy36g08-python3.7-setuptools-40.4.3/bin:/nix/store/mhnqwpa4y1l81zi4cwx989i8h8z9g67l-python3.7-jmespath-0.9.0/bin:/nix/store/qc6q3a2nv4211wyh7q319v6zzd3ab6pc-python3.7-docutils-0.14/bin'${PATH:+':'}$PATH
                  ^
    SyntaxError: invalid syntax

If we try using `dontWrapPythonPrograms` to resolve this, runtime
dependency lookups fail:

    $ credstash get mykey
    Traceback (most recent call last):
      File "/run/current-system/sw/bin/credstash", line 7, in <module>
        from credstash import main
      File "/nix/store/8rmldlvlv1z1xl7w02dy7f5qhkzdrg8z-python3.7-credstash-1.15.0/bin/credstash.py", line 26, in <module>
        import boto3
    ModuleNotFoundError: No module named 'boto3'

I was able to resolve things by simply removing bin/credstash.py before
the postFixup phase has a chance to wrap any executables. Now the
executable imports the library correctly:

 (shell wrapper)
  bin/credstash
        │      (python executable)
        └─> bin/.credstash-wrapped
                   │                        (python library)
                   └─> lib/python3.7/site-packages/credstash.py
2018-12-11 10:49:27 +01:00
..
applications Merge pull request #51812 from samueldr/fix/altcoins-and-boost165 2018-12-10 17:35:12 +01:00
build-support Merge staging-next into master 2018-12-08 16:29:21 +01:00
common-updater common-updater, firefox: fix updater for firefox 2018-11-16 23:04:54 +09:00
data Merge pull request #51763 from pbogdan/add-ant-theme 2018-12-10 22:39:27 +01:00
desktops gnome3.gnome-session: prevent crash when launching wayland sessions 2018-12-10 10:27:00 +01:00
development credstash: add standalone Python application (#51807) 2018-12-11 10:49:27 +01:00
games steam: ran update-runtime.py 2018-12-10 13:50:06 +01:00
misc seafile-shared: 6.2.8 -> 6.2.9 2018-12-10 15:50:29 +01:00
os-specific Merge pull request #51756 from markuskowa/upd-lvm2 2018-12-10 22:02:02 +00:00
servers Merge pull request #51719 from marsam/postgresql-build-icu-support 2018-12-10 01:52:54 +02:00
shells oh-my-zsh: 2018-11-02 -> 2018-11-27 2018-12-10 09:54:19 -05:00
stdenv Merge master into staging-next 2018-12-07 15:22:35 +01:00
test Merge pull request #50212 from matthewbauer/host-emulator 2018-11-29 19:34:20 -06:00
tools Merge pull request #51756 from markuskowa/upd-lvm2 2018-12-10 22:02:02 +00:00
top-level credstash: add standalone Python application (#51807) 2018-12-11 10:49:27 +01:00