kannonier8/blender
1
0
Fork 0
forked from bartvdbraak/blender
Code Pull Requests Activity

[#7299] Orbit around selected causes panning to be reversed

Browse Source 
The actual "bug" is much more general than simple viewmove. In fact, any time the center (for viewmove, or transform, or ...) on which initgrabz is called was behind the camera (in perspective, then), all mouse motion where reversed.

What I added is a special handling case that reverts those situation to the default case (center = viewport offset).

This changes the behavior for those case to something much more predictable/useable, but I doubt anyone expected it to work incorrectly, so I'd say that's alright.

This covers other cases than transform and viewmove (which are the only ones I really tested), but I don't expect breakage elsewhere.

If anyone disagrees with the change, feel free to offer a better solution.
This commit is contained in:
Martin Poirier 2007-09-06 21:35:51 +00:00
parent bd7ebb0abc
commit 0ec6abd2d1
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
source/blender/src/view.c
View File

@ -152,6 +152,11 @@ void initgrabz(float x, float y, float z)
* (accounting for near zero values) * (accounting for near zero values)
* */ * */
if (G.vd->zfac < 1.e-6f && G.vd->zfac > -1.e-6f) G.vd->zfac = 1.0f; if (G.vd->zfac < 1.e-6f && G.vd->zfac > -1.e-6f) G.vd->zfac = 1.0f;
/* Negative zfac means x, y, z was behind the camera (in perspective).
* This gives flipped directions, so revert back to ok default case.
*/
if (G.vd->zfac < 0.0f) G.vd->zfac = 1.0f;
} }
void window_to_3d(float *vec, short mx, short my) void window_to_3d(float *vec, short mx, short my)