kannonier8/blender
1
0
Fork 0
forked from bartvdbraak/blender
Code Pull Requests Activity

Workaround #29205: Crash while using Edge Split modifier (while rotating vertices in edit mode with edge split viewable)

Browse Source 
This bug is caused by exactly the same reason as #26316: differences in how new vertices/edges
are getting calculated first and how they're adding later. In some cases extra vertices are
creating which weren't counted before.

This patch prevents crash in such situations, but result mesh can be a bit wrong.
This should work fine in bmesh, so think it's acceptable to have such workaround
before actual fix coming with bmesh.
This commit is contained in:
Sergey Sharybin 2011-11-10 08:29:22 +00:00
parent c2d6fc4da3
commit 1e035381d1
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
source/blender/modifiers/intern/MOD_edgesplit.c
View File

@ -1029,12 +1029,17 @@ static void split_edge(SmoothEdge *edge, SmoothVert *vert, SmoothMesh *mesh)
vert2 = smoothvert_copy(vert, mesh);
/* replace vert with its copy in visited_faces (must be done after
* edge replacement so edges have correct vertices)
*/
repdata.find = vert;
repdata.replace = vert2;
BLI_linklist_apply(visited_faces, face_replace_vert, &repdata);
/* bug [#29205] which is caused by exactly the same reason as [#26316]
this check will only prevent crash without fixing actual issue and
some vertices can stay unsplitted when they should (sergey) */
if(vert2) {
/* replace vert with its copy in visited_faces (must be done after
* edge replacement so edges have correct vertices)
*/
repdata.find = vert;
repdata.replace = vert2;
BLI_linklist_apply(visited_faces, face_replace_vert, &repdata);
}
/* copying and replacing is done; the mesh should be consistent.
* now propagate the split to the vertex at the other end