kannonier8/blender
1
0
Fork 0
forked from bartvdbraak/blender
Code Pull Requests Activity

Commit r33378 adds a red alert to search buttons which have items which are not in the list.

Browse Source 
Disable this for pointer buttons since this was intended for vgroups & uvlayers.

Pointer buttons often reference ID's which can be in the 1000+, lookups like this on each button draw is not useful since invalid pointers here will likely crash on scene evaluation.
This commit is contained in:
Campbell Barton 2011-04-05 07:13:23 +00:00
parent dcb26e4e47
commit 2b90eb18e2
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
source/blender/editors/interface/interface_regions.c
View File

@ -1091,9 +1091,17 @@ void ui_searchbox_free(bContext *C, ARegion *ar)
/* XXX weak: search_func adds all partial matches... */
void ui_but_search_test(uiBut *but)
{
uiSearchItems *items= MEM_callocN(sizeof(uiSearchItems), "search items");
uiSearchItems *items;
int x1;
/* possibly very large lists (such as ID datablocks) only
* only validate string RNA buts (not pointers) */
if(but->rnaprop && RNA_property_type(but->rnaprop) != PROP_STRING) {
return;
}
items= MEM_callocN(sizeof(uiSearchItems), "search items");
/* setup search struct */
items->maxitem= 10;
items->maxstrlen= 256;