kannonier8/blender
1
0
Fork 0
forked from bartvdbraak/blender
Code Pull Requests Activity

Fix T80967: Alembic, crash when the imported sim from Houdini starts

Browse Source 
Compare mesh loop count with number of loop normals before reading the
loop normals.

Houdini doesn't always write the correct loop normals to Alembic. When a
mesh is animated and then replaced by a fluid simulation, Houdini will
still write the original mesh's loop normals, but the mesh
verts/loops/polys are from the simulation. In such cases the normals
cannot be mapped to the mesh, so it's better to ignore them.
This commit is contained in:
Sybren A. Stüvel 2020-09-28 14:12:33 +02:00
parent b88a9cf171
commit 3158fc2593
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
source/blender/io/alembic/intern/abc_reader_mesh.cc
View File

@ -271,10 +271,19 @@ static void process_loop_normals(CDStreamConfig &config, const N3fArraySamplePtr
return;
}
Mesh *mesh = config.mesh;
if (loop_count != mesh->totloop) {
/* This happens in certain Houdini exports. When a mesh is animated and then replaced by a
* fluid simulation, Houdini will still write the original mesh's loop normals, but the mesh
* verts/loops/polys are from the simulation. In such cases the normals cannot be mapped to the
* mesh, so it's better to ignore them. */
process_no_normals(config);
return;
}
float(*lnors)[3] = static_cast<float(*)[3]>(
MEM_malloc_arrayN(loop_count, sizeof(float[3]), "ABC::FaceNormals"));
Mesh *mesh = config.mesh;
MPoly *mpoly = mesh->mpoly;
const N3fArraySample &loop_normals = *loop_normals_ptr;
int abc_index = 0;