kannonier8/blender
1
0
Fork 0
forked from bartvdbraak/blender
Code Pull Requests Activity

Bugfix: avoid reading from an OpenGL buffer mapped write-only.

Browse Source 
When set to solid-shading, GPU_update_grid_buffers was calling
normal_quad_v3 to output into a mapped buffer, but normal_quad_v3
reads as well as writes.

This fix actually makes a huge performance difference with my drivers
(Gallium/Radeon).
This commit is contained in:
Nicholas Bishop 2012-02-28 05:00:28 +00:00
parent 79fbd39aab
commit 87ddcab933
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
source/blender/gpu/intern/gpu_buffers.c
View File

@ -1427,11 +1427,14 @@ void GPU_update_grid_buffers(GPU_Buffers *buffers, DMGridData **grids,
that is what opengl will use */
for(j = 0; j < gridsize-1; ++j) {
for(k = 0; k < gridsize-1; ++k) {
normal_quad_v3(vert_data[(j+1)*gridsize + (k+1)].no,
float fno[3];
normal_quad_v3(fno,
grid[(j+1)*gridsize + k].co,
grid[(j+1)*gridsize + k+1].co,
grid[j*gridsize + k+1].co,
grid[j*gridsize + k].co);
copy_v3_v3(vert_data[(j+1)*gridsize + (k+1)].no, fno);
}
}
}