forked from bartvdbraak/blender
Tweaks to make it easier to update bone motion paths (without the active bone needing to have any paths itself)
This commit introduces the following changes: * Modified the poll callback on the "Update Paths" operator for bones so that it only checks if there are bones that have motion paths (instead of checking whether the active bone has paths). This makes it easier to update paths without having to first select one that has them - useful when the paths are all on hidden/hard-to-select bones. * Add a readonly property, "has_motion_paths" to the animviz.motion_path RNA struct, providing easier access to the internal flag used above. This makes it possible for the UI to display the "Update" button without having to check various bones for motion paths. Notes: * The flag being used in these changes already existed, and was only really intended for internal use. However, since it was already used in many places for determining if auto-update of all bone paths was needed (e.g. after certain editing ops), it should be safe to use here too. * The update_paths operator currently bakes all paths when activated, so there's currently no loss of functionality with changing to not checking if the active bone has any paths (e.g. we couldn't only update the active bone only either). That is still listed as a todo in the code.
This commit is contained in:
parent
c01ffefb68
commit
c5f59f5854
@ -852,12 +852,12 @@ class VIEW3D_PT_tools_posemode(View3DPanel, Panel):
|
|||||||
|
|
||||||
draw_keyframing_tools(context, layout)
|
draw_keyframing_tools(context, layout)
|
||||||
|
|
||||||
pchan = context.active_pose_bone
|
ob = context.object
|
||||||
mpath = pchan.motion_path if pchan else None
|
avs = ob.pose.animation_visualization
|
||||||
|
|
||||||
col = layout.column(align=True)
|
col = layout.column(align=True)
|
||||||
col.label(text="Motion Paths:")
|
col.label(text="Motion Paths:")
|
||||||
if mpath:
|
if avs.motion_path.has_motion_paths:
|
||||||
row = col.row(align=True)
|
row = col.row(align=True)
|
||||||
row.operator("pose.paths_update", text="Update")
|
row.operator("pose.paths_update", text="Update")
|
||||||
row.operator("pose.paths_clear", text="", icon='X')
|
row.operator("pose.paths_clear", text="", icon='X')
|
||||||
|
@ -265,8 +265,8 @@ void POSE_OT_paths_calculate(wmOperatorType *ot)
|
|||||||
static int pose_update_paths_poll(bContext *C)
|
static int pose_update_paths_poll(bContext *C)
|
||||||
{
|
{
|
||||||
if (ED_operator_posemode_exclusive(C)) {
|
if (ED_operator_posemode_exclusive(C)) {
|
||||||
bPoseChannel *pchan = CTX_data_active_pose_bone(C);
|
Object *ob = CTX_data_active_object(C);
|
||||||
return (pchan && pchan->mpath);
|
return (ob->pose->avs.path_bakeflag & MOTIONPATH_BAKE_HAS_PATHS) != 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
return false;
|
return false;
|
||||||
|
@ -174,6 +174,7 @@ static void rna_def_animviz_motion_path(BlenderRNA *brna)
|
|||||||
RNA_def_property_ui_text(prop, "Use Bone Heads",
|
RNA_def_property_ui_text(prop, "Use Bone Heads",
|
||||||
"For PoseBone paths, use the bone head location when calculating this path");
|
"For PoseBone paths, use the bone head location when calculating this path");
|
||||||
|
|
||||||
|
/* FIXME: Motion Paths are not currently editable... */
|
||||||
prop = RNA_def_property(srna, "is_modified", PROP_BOOLEAN, PROP_NONE);
|
prop = RNA_def_property(srna, "is_modified", PROP_BOOLEAN, PROP_NONE);
|
||||||
RNA_def_property_boolean_sdna(prop, NULL, "flag", MOTIONPATH_FLAG_EDIT);
|
RNA_def_property_boolean_sdna(prop, NULL, "flag", MOTIONPATH_FLAG_EDIT);
|
||||||
RNA_def_property_ui_text(prop, "Edit Path", "Path is being edited");
|
RNA_def_property_ui_text(prop, "Edit Path", "Path is being edited");
|
||||||
@ -364,6 +365,12 @@ static void rna_def_animviz_paths(BlenderRNA *brna)
|
|||||||
"(only for 'Around Current Frame' Onion-skinning method)");
|
"(only for 'Around Current Frame' Onion-skinning method)");
|
||||||
RNA_def_property_update(prop, NC_SPACE | ND_SPACE_VIEW3D, NULL); /* XXX since this is only for 3d-view drawing */
|
RNA_def_property_update(prop, NC_SPACE | ND_SPACE_VIEW3D, NULL); /* XXX since this is only for 3d-view drawing */
|
||||||
|
|
||||||
|
|
||||||
|
/* Readonly Property - Do any motion paths exist/need updating? (Mainly for bone paths) */
|
||||||
|
prop = RNA_def_property(srna, "has_motion_paths", PROP_BOOLEAN, PROP_NONE);
|
||||||
|
RNA_def_property_boolean_sdna(prop, NULL, "path_bakeflag", MOTIONPATH_BAKE_HAS_PATHS);
|
||||||
|
RNA_def_property_clear_flag(prop, PROP_EDITABLE); /* NOTE: This is really an internal state var for convenience, so don't allow edits! */
|
||||||
|
RNA_def_property_ui_text(prop, "Has Motion Paths", "Are there any bone paths that will need updating (read-only)");
|
||||||
}
|
}
|
||||||
|
|
||||||
/* --- */
|
/* --- */
|
||||||
|
Loading…
Reference in New Issue
Block a user