kannonier8/blender
1
0
Fork 0
forked from bartvdbraak/blender
Code Pull Requests Activity

Fix T69182: Auto-Smooth does not work on Alembic meshes without normals

Browse Source 
The auto-smoothing flag can now be used by artists when the Alembic file
does not contain custom loop normals.

- Auto-smoothing disabled: mesh is flat-shaded.
- Auto-smoothing enabled: works as usual; set angle to 180° to ensure
  a 100% smoothed mesh.
This commit is contained in:
Sybren A. Stüvel 2019-10-17 11:18:46 +02:00
parent 2afbd14c59
commit dffe702d78
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
source/blender/alembic/intern/abc_mesh.cc
View File

@ -885,7 +885,8 @@ static void process_normals(CDStreamConfig &config, const AbcMeshData &mesh_data
if (!mesh_data.loop_normals) {
BKE_mesh_calc_normals(config.mesh);
config.mesh->flag &= ~ME_AUTOSMOOTH;
/* Don't touch the ME_AUTOSMOOTH flag in this case. It can be used by artists to toggle between
* flat/smooth shaded when the Alembic mesh doesn't contain loop normals. */
return;
}
@ -1018,7 +1019,10 @@ static void read_mesh_sample(const std::string &iobject_full_name,
abc_mesh_data.face_counts = sample.getFaceCounts();
abc_mesh_data.face_indices = sample.getFaceIndices();
abc_mesh_data.positions = sample.getPositions();
abc_mesh_data.poly_flag_smooth = false;
/* The auto-smoothing flag can be used by artists when the Alembic file does not contain custom
* loop normals. Auto-smoothing only works when polys are marked as smooth. */
abc_mesh_data.poly_flag_smooth = (config.mesh->flag & ME_AUTOSMOOTH);
read_normals_params(abc_mesh_data, schema.getNormalsParam(), selector);