Extend existing editmesh connect tool so it can connect across multiple faces.

only use this when 2 vertices are selected, otherwise use the same behavior as before.

This works a little like a fast knife tool, but it only cuts straight lines and doesnt depend on the view-port.

Examples:
- http://www.graphicall.org/ftp/ideasman42/mesh_connect_pair.png
- http://www.graphicall.org/ftp/ideasman42/mesh_connect_pair_curve.png
This commit is contained in:
Campbell Barton 2013-06-22 17:25:02 +00:00
parent 240fb6fa26
commit e4bb913510
6 changed files with 590 additions and 4 deletions

@ -43,6 +43,7 @@ set(SRC
operators/bmo_bevel.c
operators/bmo_bridge.c
operators/bmo_connect.c
operators/bmo_connect_pair.c
operators/bmo_create.c
operators/bmo_dissolve.c
operators/bmo_dupe.c

@ -840,6 +840,26 @@ static BMOpDefine bmo_connect_verts_def = {
BMO_OPTYPE_FLAG_UNTAN_MULTIRES | BMO_OPTYPE_FLAG_NORMALS_CALC | BMO_OPTYPE_FLAG_SELECT_FLUSH,
};
/*
* Connect Verts.
*
* Split faces by adding edges that connect **verts**.
*/
static BMOpDefine bmo_connect_vert_pair_def = {
"connect_vert_pair",
/* slots_in */
{{"verts", BMO_OP_SLOT_ELEMENT_BUF, {BM_VERT}},
{{'\0'}},
},
/* slots_out */
{{"edges.out", BMO_OP_SLOT_ELEMENT_BUF, {BM_EDGE}},
{{'\0'}},
},
bmo_connect_vert_pair_exec,
BMO_OPTYPE_FLAG_UNTAN_MULTIRES | BMO_OPTYPE_FLAG_NORMALS_CALC | BMO_OPTYPE_FLAG_SELECT_FLUSH,
};
/*
* Extrude Faces.
*
@ -1685,6 +1705,7 @@ const BMOpDefine *bmo_opdefines[] = {
&bmo_collapse_def,
&bmo_collapse_uvs_def,
&bmo_connect_verts_def,
&bmo_connect_vert_pair_def,
&bmo_contextual_create_def,
#ifdef WITH_BULLET
&bmo_convex_hull_def,

@ -40,6 +40,7 @@ void bmo_bridge_loops_exec(BMesh *bm, BMOperator *op);
void bmo_collapse_exec(BMesh *bm, BMOperator *op);
void bmo_collapse_uvs_exec(BMesh *bm, BMOperator *op);
void bmo_connect_verts_exec(BMesh *bm, BMOperator *op);
void bmo_connect_vert_pair_exec(BMesh *bm, BMOperator *op);
void bmo_contextual_create_exec(BMesh *bm, BMOperator *op);
void bmo_convex_hull_exec(BMesh *bm, BMOperator *op);
void bmo_create_circle_exec(BMesh *bm, BMOperator *op);

@ -23,7 +23,7 @@
/** \file blender/bmesh/operators/bmo_connect.c
* \ingroup bmesh
*
* Connect verts across faces (splits faces) and bridge tool.
* Connect verts across faces (splits faces).
*/
#include "MEM_guardedalloc.h"

@ -0,0 +1,546 @@
/*
* ***** BEGIN GPL LICENSE BLOCK *****
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation; either version 2
* of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software Foundation,
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*
* Contributor(s): Campbell Barton.
*
* ***** END GPL LICENSE BLOCK *****
*/
/** \file blender/bmesh/operators/bmo_connect_pair.c
* \ingroup bmesh
*
* Connect vertex pair across multiple faces (splits faces).
*/
#include "MEM_guardedalloc.h"
#include "BLI_math.h"
#include "BLI_utildefines.h"
#include "bmesh.h"
#include "intern/bmesh_operators_private.h" /* own include */
#include "BLI_mempool.h"
#include "BLI_listbase.h"
/**
* Method for connecting across many faces.
*
* - use the line between both verts and their normal average to construct a matrix.
* - using the matrix, we can find all intersecting verts/edges and build connection data.
* - then walk the connected data and find the shortest path (as we do with other shortest-path functions).
* - if the connection can't be found - fail.
* - with the connection found, split all edges tagging verts (or tag verts that sit on the intersection).
* - run the standard connect operator.
*/
#define CONNECT_EPS 0.0001f
#define VERT_OUT 1
// #define DEBUG_PRINT
typedef struct PathContext {
ListBase state_lb;
float matrix[3][3];
float axis_sep;
BMVert *v_a, *v_b;
BLI_mempool *link_pool;
} PathContext;
/**
* Single linked list where each item contains state and points to previous path item.
*/
typedef struct PathLink {
struct PathLink *next;
BMElem *ele; /* edge or vert */
BMElem *ele_from; /* edge or face we game from (not 'next->ele') */
} PathLink;
typedef struct PathLinkState {
struct PathLinkState *next, *prev;
/* chain of links */
struct PathLink *link_last;
/* length along links */
float dist;
float co_prev[3];
} PathLinkState;
/* only the x axis */
static float mul_v1_m3v3(float M[3][3], const float a[3])
{
return M[0][0] * a[0] + M[1][0] * a[1] + M[2][0] * a[2];
}
static int state_isect_co_pair(const PathContext *pc,
const float co_a[3], const float co_b[3])
{
const float diff_a = mul_v1_m3v3((float (*)[3])pc->matrix, co_a) - pc->axis_sep;
const float diff_b = mul_v1_m3v3((float (*)[3])pc->matrix, co_b) - pc->axis_sep;
const int test_a = (fabsf(diff_a) < CONNECT_EPS) ? 0 : (diff_a < 0.0f) ? -1 : 1;
const int test_b = (fabsf(diff_b) < CONNECT_EPS) ? 0 : (diff_b < 0.0f) ? -1 : 1;
if ((test_a && test_b) && (test_a != test_b)) {
return 1; /* on either side */
}
else {
return 0;
}
}
static int state_isect_co_exact(const PathContext *pc,
const float co[3])
{
const float diff = mul_v1_m3v3((float (*)[3])pc->matrix, co) - pc->axis_sep;
return (fabsf(diff) < CONNECT_EPS);
}
static float state_calc_co_pair_fac(const PathContext *pc,
const float co_a[3], const float co_b[3])
{
float diff_a, diff_b, diff_tot;
diff_a = fabsf(mul_v1_m3v3((float (*)[3])pc->matrix, co_a) - pc->axis_sep);
diff_b = fabsf(mul_v1_m3v3((float (*)[3])pc->matrix, co_b) - pc->axis_sep);
diff_tot = (diff_a + diff_b);
return (diff_tot > FLT_EPSILON) ? (diff_a / diff_tot) : 0.5f;
}
static void state_calc_co_pair(const PathContext *pc,
const float co_a[3], const float co_b[3],
float r_co[3])
{
const float fac = state_calc_co_pair_fac(pc, co_a, co_b);
interp_v3_v3v3(r_co, co_a, co_b, fac);
}
/**
* Ideally we wouldn't need this and for most cases we don't.
* But when a face has vertices that are on the boundary more then once this becomes tricky.
*/
static bool state_link_find(PathLinkState *state, BMElem *ele)
{
PathLink *link = state->link_last;
BLI_assert(ELEM3(ele->head.htype, BM_VERT, BM_EDGE, BM_FACE));
if (link) {
do {
if (link->ele == ele) {
return true;
}
} while ((link = link->next));
}
return false;
}
static void state_link_add(PathContext *pc, PathLinkState *state,
BMElem *ele, BMElem *ele_from)
{
PathLink *step_new = BLI_mempool_alloc(pc->link_pool);
BLI_assert(ele != ele_from);
BLI_assert(state_link_find(state, ele) == false);
#ifdef DEBUG_PRINT
printf("%s: adding to state %p:%d, %.4f - ", __func__, state, BLI_findindex(&pc->state_lb, state), state->dist);
if (ele->head.htype == BM_VERT) {
printf("vert %d, ", BM_elem_index_get(ele));
}
else if (ele->head.htype == BM_EDGE) {
printf("edge %d, ", BM_elem_index_get(ele));
}
else {
BLI_assert(0);
}
if (ele_prev == NULL) {
printf("from NULL\n");
}
else if (ele_prev->head.htype == BM_EDGE) {
printf("from edge %d\n", BM_elem_index_get(ele_prev));
}
else if (ele_prev->head.htype == BM_FACE) {
printf("from face %d\n", BM_elem_index_get(ele_prev));
}
else {
BLI_assert(0);
}
#endif
/* track distance */
{
float co[3];
if (ele->head.htype == BM_VERT) {
copy_v3_v3(co, ((BMVert *)ele)->co);
}
else if (ele->head.htype == BM_EDGE) {
state_calc_co_pair(pc, ((BMEdge *)ele)->v1->co, ((BMEdge *)ele)->v2->co, co);
}
else {
BLI_assert(0);
}
/* tally distance */
if (ele_from) {
state->dist += len_v3v3(state->co_prev, co);
}
copy_v3_v3(state->co_prev, co);
}
step_new->ele = ele;
step_new->ele_from = ele_from;
step_new->next = state->link_last;
state->link_last = step_new;
}
static PathLinkState *state_dupe_add(PathContext *pc,
PathLinkState *state, const PathLinkState *state_orig)
{
state = MEM_mallocN(sizeof(*state), __func__);
*state = *state_orig;
BLI_addhead(&pc->state_lb, state);
return state;
}
/* walk around the face edges */
static PathLinkState *state_step__face_edges(PathContext *pc,
PathLinkState *state, const PathLinkState *state_orig,
BMLoop *l_iter, BMLoop *l_last)
{
do {
if (state_isect_co_pair(pc, l_iter->v->co, l_iter->next->v->co)) {
BMElem *ele_next = (BMElem *)l_iter->e;
BMElem *ele_next_from = (BMElem *)l_iter->f;
if (state_link_find(state, ele_next) == false) {
if (state_orig->link_last != state->link_last) {
state = state_dupe_add(pc, state, state_orig);
}
state_link_add(pc, state, ele_next, ele_next_from);
}
}
} while ((l_iter = l_iter->next) != l_last);
return state;
}
/* walk around the face verts */
static PathLinkState *state_step__face_verts(PathContext *pc,
PathLinkState *state, const PathLinkState *state_orig,
BMLoop *l_iter, BMLoop *l_last)
{
do {
if (state_isect_co_exact(pc, l_iter->v->co)) {
BMElem *ele_next = (BMElem *)l_iter->v;
BMElem *ele_next_from = (BMElem *)l_iter->f;
if (state_link_find(state, ele_next) == false) {
if (state_orig->link_last != state->link_last) {
state = state_dupe_add(pc, state, state_orig);
}
state_link_add(pc, state, ele_next, ele_next_from);
}
}
} while ((l_iter = l_iter->next) != l_last);
return state;
}
static bool state_step(PathContext *pc, PathLinkState *state)
{
PathLinkState state_orig = *state;
BMElem *ele = state->link_last->ele;
const void *ele_from = state->link_last->ele_from;
if (ele->head.htype == BM_EDGE) {
BMEdge *e = (BMEdge *)ele;
BMIter liter;
BMLoop *l_start;
BM_ITER_ELEM (l_start, &liter, e, BM_LOOPS_OF_EDGE) {
if (l_start->f != ele_from) {
/* very similar to block below */
if (BM_vert_in_face(l_start->f, pc->v_b)) {
if (state_orig.link_last != state->link_last) {
state = state_dupe_add(pc, state, &state_orig);
}
state_link_add(pc, state, (BMElem *)pc->v_b, (BMElem *)l_start->f);
}
else {
state = state_step__face_edges(pc, state, &state_orig,
l_start->next, l_start);
}
}
}
}
else if (ele->head.htype == BM_VERT) {
BMVert *v = (BMVert *)ele;
/* vert loops */
{
BMIter liter;
BMLoop *l_start;
BM_ITER_ELEM (l_start, &liter, v, BM_LOOPS_OF_VERT) {
if (l_start->f != ele_from) {
/* very similar to block above */
if (BM_vert_in_face(l_start->f, pc->v_b)) {
BMElem *ele_next = (BMElem *)pc->v_b;
BMElem *ele_next_from = (BMElem *)l_start->f;
if (state_orig.link_last != state->link_last) {
state = state_dupe_add(pc, state, &state_orig);
}
state_link_add(pc, state, ele_next, ele_next_from);
}
else {
state = state_step__face_edges(pc, state, &state_orig,
l_start->next, l_start->prev);
if (l_start->f->len > 3) {
/* adjacent verts are handled in state_step__vert_edges */
state = state_step__face_verts(pc, state, &state_orig,
l_start->next->next, l_start->prev);
}
}
}
}
}
/* vert edges */
{
BMIter eiter;
BMEdge *e;
BM_ITER_ELEM (e, &eiter, v, BM_EDGES_OF_VERT) {
if ((BMElem *)e != ele_from) {
BMVert *v_other = BM_edge_other_vert(e, v);
if (v_other == pc->v_b) {
BMElem *ele_next = (BMElem *)pc->v_b;
BMElem *ele_next_from = (BMElem *)e;
if (state_orig.link_last != state->link_last) {
state = state_dupe_add(pc, state, &state_orig);
}
state_link_add(pc, state, ele_next, ele_next_from);
}
else {
if (state_isect_co_exact(pc, v_other->co)) {
BMElem *ele_next = (BMElem *)v_other;
BMElem *ele_next_from = (BMElem *)e;
if (state_link_find(state, ele_next) == false) {
if (state_orig.link_last != state->link_last) {
state = state_dupe_add(pc, state, &state_orig);
}
state_link_add(pc, state, ele_next, ele_next_from);
}
}
}
}
}
}
}
else {
BLI_assert(0);
}
return (state_orig.link_last != state->link_last);
}
void bmo_connect_vert_pair_exec(BMesh *bm, BMOperator *op)
{
BMOpSlot *op_verts_slot = BMO_slot_get(op->slots_in, "verts");
PathContext pc;
bool found_all;
float found_dist_best = -1.0f;
if (op_verts_slot->len != 2) {
/* fail! */
return;
}
pc.v_a = ((BMVert **)op_verts_slot->data.p)[0];
pc.v_b = ((BMVert **)op_verts_slot->data.p)[1];
/* fail! */
if (!(pc.v_a && pc.v_a)) {
return;
}
#ifdef DEBUG_PRINT
printf("%s: v_a: %d\n", __func__, BM_elem_index_get(pc.v_a));
printf("%s: v_b: %d\n", __func__, BM_elem_index_get(pc.v_b));
#endif
/* setup context */
{
pc.state_lb.first = NULL;
pc.state_lb.last = NULL;
pc.link_pool = BLI_mempool_create(sizeof(PathLink), 1, 512, BLI_MEMPOOL_SYSMALLOC);
}
/* calculate matrix */
{
float basis_dir[3];
float basis_tmp[3];
float basis_nor[3];
sub_v3_v3v3(basis_dir, pc.v_a->co, pc.v_b->co);
#if 0
add_v3_v3v3(basis_nor, pc.v_a->no, pc.v_b->no);
cross_v3_v3v3(basis_tmp, basis_nor, basis_dir);
cross_v3_v3v3(basis_nor, basis_tmp, basis_dir);
#else
/* align both normals to the directions before combining */
{
float basis_nor_a[3];
float basis_nor_b[3];
/* align normal to direction */
cross_v3_v3v3(basis_tmp, pc.v_a->no, basis_dir);
cross_v3_v3v3(basis_nor_a, basis_tmp, basis_dir);
cross_v3_v3v3(basis_tmp, pc.v_b->no, basis_dir);
cross_v3_v3v3(basis_nor_b, basis_tmp, basis_dir);
/* combine the normals */
normalize_v3(basis_nor_a);
normalize_v3(basis_nor_b);
/* for flipped faces */
if (dot_v3v3(basis_nor_a, basis_nor_b) < 0.0f) {
negate_v3(basis_nor_b);
}
add_v3_v3v3(basis_nor, basis_nor_a, basis_nor_b);
}
#endif
/* get third axis */
cross_v3_v3v3(basis_tmp, basis_dir, basis_nor);
normalize_v3_v3(pc.matrix[0], basis_tmp);
normalize_v3_v3(pc.matrix[1], basis_dir);
normalize_v3_v3(pc.matrix[2], basis_nor);
invert_m3(pc.matrix);
pc.axis_sep = mul_v1_m3v3(pc.matrix, pc.v_a->co);
}
/* add first vertex */
{
PathLinkState *state;
state = MEM_callocN(sizeof(*state), __func__);
BLI_addtail(&pc.state_lb, state);
state_link_add(&pc, state, (BMElem *)pc.v_a, NULL);
}
found_all = false;
while (pc.state_lb.first) {
PathLinkState *state, *state_next;
found_all = true;
for (state = pc.state_lb.first; state; state = state_next) {
state_next = state->next;
if (state->link_last->ele == (BMElem *)pc.v_b) {
/* pass, wait until all are found */
#ifdef DEBUG_PRINT
printf("%s: state %p loop found %.4f\n", __func__, state, state->dist);
#endif
if ((found_dist_best == -1.0f) || (found_dist_best > state->dist)) {
found_dist_best = state->dist;
}
}
else if (state_step(&pc, state)) {
if ((found_dist_best != -1.0f) && (found_dist_best <= state->dist)) {
BLI_remlink(&pc.state_lb, state);
MEM_freeN(state);
}
else {
found_all = false;
}
}
else {
/* didn't reach the end, remove it,
* links are shared between states so just free the link_pool at the end */
BLI_remlink(&pc.state_lb, state);
MEM_freeN(state);
}
}
if (found_all) {
break;
}
}
if (pc.state_lb.first == NULL) {
found_all = false;
}
if (found_all) {
PathLinkState *state, *state_best = NULL;
PathLink *link;
float state_best_dist = FLT_MAX;
/* find the best state */
for (state = pc.state_lb.first; state; state = state->next) {
if ((state_best == NULL) || (state->dist < state_best_dist)) {
state_best = state;
state_best_dist = state_best->dist;
}
}
link = state_best->link_last;
do {
if (link->ele->head.htype == BM_EDGE) {
BMEdge *e = (BMEdge *)link->ele;
BMVert *v_new;
float e_fac = state_calc_co_pair_fac(&pc, e->v1->co, e->v2->co);
v_new = BM_edge_split(bm, e, e->v1, NULL, e_fac);
BMO_elem_flag_enable(bm, v_new, VERT_OUT);
}
else if (link->ele->head.htype == BM_VERT) {
BMVert *v = (BMVert *)link->ele;
BMO_elem_flag_enable(bm, v, VERT_OUT);
}
else {
BLI_assert(0);
}
} while ((link = link->next));
}
BMO_elem_flag_enable(bm, pc.v_a, VERT_OUT);
BMO_elem_flag_enable(bm, pc.v_b, VERT_OUT);
BLI_mempool_destroy(pc.link_pool);
BLI_freelistN(&pc.state_lb);
#if 1
if (found_all) {
BMOperator op_sub;
BMO_op_initf(bm, &op_sub, 0,
"connect_verts verts=%fv", VERT_OUT);
BMO_op_exec(bm, &op_sub);
BMO_slot_copy(&op_sub, slots_out, "edges.out",
op, slots_out, "edges.out");
BMO_op_finish(bm, &op_sub);
}
#endif
}

@ -778,13 +778,30 @@ static int edbm_vert_connect(bContext *C, wmOperator *op)
BMEditMesh *em = BKE_editmesh_from_object(obedit);
BMesh *bm = em->bm;
BMOperator bmop;
int len = 0;
const bool is_pair = (bm->totvertsel == 2);
int len;
if (!EDBM_op_init(em, &bmop, op, "connect_verts verts=%hv", BM_ELEM_SELECT)) {
return OPERATOR_CANCELLED;
if (is_pair) {
if (!EDBM_op_init(em, &bmop, op, "connect_vert_pair verts=%hv", BM_ELEM_SELECT)) {
return OPERATOR_CANCELLED;
}
}
else {
if (!EDBM_op_init(em, &bmop, op, "connect_verts verts=%hv", BM_ELEM_SELECT)) {
return OPERATOR_CANCELLED;
}
}
BMO_op_exec(bm, &bmop);
len = BMO_slot_get(bmop.slots_out, "edges.out")->len;
if (len) {
if (is_pair) {
/* new verts have been added, we have to select the edges, not just flush */
BMO_slot_buffer_hflag_enable(em->bm, bmop.slots_out, "edges.out", BM_EDGE, BM_ELEM_SELECT, true);
}
}
if (!EDBM_op_finish(em, &bmop, op, true)) {
return OPERATOR_CANCELLED;
}