kannonier8/blender
1
0
Fork 0
forked from bartvdbraak/blender
Code Pull Requests Activity

Fix #29367: Vertex parent regression

Browse Source 
Regression was introduced in svn rev40343. It was caused by re-creating
EditMesh structure which was needed to solve issues with parenting to
vertices after topology changes. This would also erase derivedMesh.

Problem reported now is caused by missing derivedMesh which is used
to solve parenting and apply inverted matrix on ob->parentin, so
parented object used to stay at exactly the same position it used to
stay before parenting.

Not very nice solving of this issue: re-create derivedMesh after
re-creating EditMesh when parenting. Nicer solution would require
bigger changes and probably ful lrefactor of this tools.
This commit is contained in:
Sergey Sharybin 2011-11-23 15:44:20 +00:00
parent 0f3b1d23de
commit f48cc83b3e
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
source/blender/blenkernel/intern/object.c
View File

@ -1785,6 +1785,7 @@ static void give_parvert(Object *par, int nr, float *vec)
dm->getVertCo(dm, 0, vec);
}
}
else fprintf(stderr, "%s: DerivedMesh is needed to solve parenting, object position can be wrong now\n", __func__);
if(em)
BKE_mesh_end_editmesh(me, em);

7
source/blender/editors/object/object_relations.c
View File

@ -61,6 +61,7 @@
#include "BKE_constraint.h"
#include "BKE_curve.h"
#include "BKE_depsgraph.h"
#include "BKE_DerivedMesh.h"
#include "BKE_displist.h"
#include "BKE_global.h"
#include "BKE_fcurve.h"
@ -128,7 +129,11 @@ static int vertex_parent_set_exec(bContext *C, wmOperator *op)
load_editMesh(scene, obedit);
make_editMesh(scene, obedit);
em = BKE_mesh_get_editmesh(me);
em= BKE_mesh_get_editmesh(me);
/* derivedMesh might be needed for solving parenting,
so re-create it here */
makeDerivedMesh(scene, obedit, em, CD_MASK_BAREMESH);
eve= em->verts.first;
while(eve) {