BugFix: updateLabel can updated not allowed fields #11242 (#11242)

models/issue_label_test.go

@@ -252,9 +252,16 @@ func TestGetLabelsByIssueID(t *testing.T) {
 func TestUpdateLabel(t *testing.T) {
 	assert.NoError(t, PrepareTestDatabase())
 	label := AssertExistsAndLoadBean(t, &Label{ID: 1}).(*Label)
-	label.Color = "#ffff00"
-	label.Name = "newLabelName"
-	assert.NoError(t, UpdateLabel(label))
+	// make sure update wont overwrite it
+	update := &Label{
+		ID:          label.ID,
+		Color:       "#ffff00",
+		Name:        "newLabelName",
+		Description: label.Description,
+	}
+	label.Color = update.Color
+	label.Name = update.Name
+	assert.NoError(t, UpdateLabel(update))
 	newLabel := AssertExistsAndLoadBean(t, &Label{ID: 1}).(*Label)
 	assert.Equal(t, *label, *newLabel)
 	CheckConsistencyFor(t, &Label{}, &Repository{})